Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use of unimplemented pid() method #20028

Merged
merged 1 commit into from
Dec 2, 2022
Merged

Remove use of unimplemented pid() method #20028

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions ...ons-worker/src/main/java/io/airbyte/workers/normalization/DefaultNormalizationRunner.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,7 @@ public void close() throws Exception {
return;
}

LOGGER.info("Terminating normalization process {}...", process.pid());
LOGGER.info("Terminating normalization process...");
WorkerUtils.gentleClose(process, 1, TimeUnit.MINUTES);

/*
Expand All @@ -210,11 +210,11 @@ public void close() throws Exception {
* Did the process actually terminate? If "yes", did it do so nominally?
*/
if (process.isAlive()) {
throw new WorkerException("Normalization process " + process.pid() + " did not terminate after 1 minute.");
throw new WorkerException("Normalization process did not terminate after 1 minute.");
} else if (process.exitValue() != 0) {
throw new WorkerException("Normalization process " + process.pid() + " did not terminate normally (exit code: " + process.exitValue() + ")");
throw new WorkerException("Normalization process did not terminate normally (exit code: " + process.exitValue() + ")");
} else {
LOGGER.info("Normalization process {} successfully terminated.", process.pid());
LOGGER.info("Normalization process successfully terminated.");
}
}

Expand Down