Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

octavia-cli: undue skip_reset flag revert and update integration tests #20093

Merged
merged 2 commits into from
Dec 5, 2022

Conversation

terencecho
Copy link
Contributor

@terencecho terencecho commented Dec 5, 2022

What

Undoes the revert here: da0d9a7

Reinstating the original PR here: #18337

This PR also:

  • fixes failing integration test by adding the new field
  • fixes formatting of the code

@terencecho terencecho merged commit a1e21c9 into master Dec 5, 2022
@terencecho terencecho deleted the tcho/octavia-cli-reset-streams branch December 5, 2022 23:26
@terencecho
Copy link
Contributor Author

the .pre-commit-config.yaml file changes is related to #20087.

That was my bad, should not have been a part of this PR and should have been done in the PR linked above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants