BLOCKED: Bumps MySQL strict encrypt variant to match non-strict-encrypt #20111

ryankfu · 2022-12-06T01:04:49Z

BLOCKED

Currently blocked on destination-mysql integration tests failing on normalization with respect to numbers (values with decimal points). Shifting this work to OC engineer to further delve into

What

Bumps destination-mysql-strict-encrypt to match destination-mysql. Was initially missing as part of the changes to wrap connector logs using log4j

Slack thread explaining the reason for this change

How

Bumps Dockerfile to match destination-mysql

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

No user impact, this will have connector versions in sync

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub by running the /publish command described here
After the connector is published, connector added to connector index as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

Connector Generator

Issue acceptance criteria met
PR name follows PR naming conventions
If adding a new generator, add it to the list of scaffold modules being tested
The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
Documentation which references the generator is updated as needed

Tests

Unit

Put your unit tests output here.

Integration

Put your integration tests output here.

Acceptance

Put your acceptance tests output here.

github-actions · 2022-12-06T01:06:18Z

Affected Connector Report

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to do the following as needed:

Run integration tests
Bump connector or module version
Add changelog
Publish the new version

✅ Sources (0)

Connector	Version	Changelog	Publish

See "Actionable Items" below for how to resolve warnings and errors.

❌ Destinations (2)

Connector	Version	Changelog	Publish
`destination-mysql`	`0.1.21`	✅	❌ (diff seed version)
`destination-mysql-strict-encrypt`	`0.1.21`	✅	⚠ (not in seed)

See "Actionable Items" below for how to resolve warnings and errors.

👀 Other Modules (1)

base-normalization

Actionable Items

(click to expand)

Category	Status	Actionable Item
Version	❌ mismatch	The version of the connector is different from its normal variant. Please bump the version of the connector.
	⚠ doc not found	The connector does not seem to have a documentation file. This can be normal (e.g. basic connector like `source-jdbc` is not published or documented). Please double-check to make sure that it is not a bug.
Changelog	⚠ doc not found	The connector does not seem to have a documentation file. This can be normal (e.g. basic connector like `source-jdbc` is not published or documented). Please double-check to make sure that it is not a bug.
	❌ changelog missing	There is no chnagelog for the current version of the connector. If you are the author of the current version, please add a changelog.
Publish	⚠ not in seed	The connector is not in the seed file (e.g. `source_definitions.yaml`), so its publication status cannot be checked. This can be normal (e.g. some connectors are cloud-specific, and only listed in the cloud seed file). Please double-check to make sure that it is not a bug.
	❌ diff seed version	The connector exists in the seed file, but the latest version is not listed there. This usually means that the latest version is not published. Please use the `/publish` command to publish the latest version.

ryankfu · 2022-12-06T01:07:46Z

/test connector=connectors/destination-mysql-strict-encyrpt

🕑 connectors/destination-mysql-strict-encyrpt https://github.com/airbytehq/airbyte/actions/runs/3625472781
❌ connectors/destination-mysql-strict-encyrpt https://github.com/airbytehq/airbyte/actions/runs/3625472781
🐛

Build Failed

Test summary info:

Could not find result summary

ryankfu · 2022-12-06T01:07:55Z

/test connector=connectors/destination-mysql

🕑 connectors/destination-mysql https://github.com/airbytehq/airbyte/actions/runs/3625473132
❌ connectors/destination-mysql https://github.com/airbytehq/airbyte/actions/runs/3625473132
🐛 https://gradle.com/s/emzlkilcqwlzu

Build Failed

Test summary info:

Could not find result summary

evantahler · 2022-12-06T01:19:27Z

so what should happen is that once you /publish this connector, that (diff seed version) warning should go away, and then you can merge... let's find out!

The (not in seed) message for strict-encrypt should go away after #20110

ryankfu · 2022-12-06T01:22:28Z

/publish connector=connectors/destination-mysql-strict-encrypt run-tests=false auto-bump-version=false

🕑 Publishing the following connectors:
connectors/destination-mysql-strict-encrypt
https://github.com/airbytehq/airbyte/actions/runs/3625551637

Connector	Did it publish?	Were definitions generated?
connectors/destination-mysql-strict-encrypt	❌	❌

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

ryankfu · 2022-12-06T01:29:18Z

Just realized that 0.1.21 was not published for destination-mysql on dockerhub and that 0.1.21 was published in the past for destination-mysql-strict-encrypt so will likely let the previous publish command to complete then run publish for both destination-mysql and destination-mysql-strict-encrypt to keep them in sync

Context: #15668 (comment) indicating that the publishing process failed

EDIT: waiting on the integration tests for destination-mysql to pass before publishing the connector. destination-mysql-strict-encrypt fails because it cannot find that connector (likely because it's not seeded)

edgao · 2022-12-06T16:03:26Z

these test failures look actually problematic: Expected value -12345.678 vs Actual value "-12345.7" - I'll take a look as OC for why we're rounding off decimals

evantahler · 2022-12-06T17:00:56Z

cc @andriikorotkov, who saw this issue as well in #19993. @andriikorotkov - can you share if you've learned yet why this happens? If not, we should let the Database team work on this and we can focus on the platform work.

Bumps MySQL strict encrypt variant to match non-strict-encrypt

a70a1a6

ryankfu requested a review from a team as a code owner December 6, 2022 01:04

ryankfu requested a review from evantahler December 6, 2022 01:04

octavia-squidington-iv added area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/destination/mysql labels Dec 6, 2022

evantahler approved these changes Dec 6, 2022

View reviewed changes

grishick approved these changes Dec 6, 2022

View reviewed changes

ryankfu changed the title ~~Bumps MySQL strict encrypt variant to match non-strict-encrypt~~ BLOCKED: Bumps MySQL strict encrypt variant to match non-strict-encrypt Dec 6, 2022

natikgadzhi closed this Oct 5, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

BLOCKED: Bumps MySQL strict encrypt variant to match non-strict-encrypt #20111

BLOCKED: Bumps MySQL strict encrypt variant to match non-strict-encrypt #20111

ryankfu commented Dec 6, 2022 •

edited

Loading

github-actions bot commented Dec 6, 2022

✅ Sources (0)

❌ Destinations (2)

👀 Other Modules (1)

Actionable Items

ryankfu commented Dec 6, 2022 •

edited by github-actions bot

Loading

ryankfu commented Dec 6, 2022 •

edited by github-actions bot

Loading

evantahler commented Dec 6, 2022 •

edited

Loading

ryankfu commented Dec 6, 2022 •

edited by github-actions bot

Loading

ryankfu commented Dec 6, 2022 •

edited

Loading

edgao commented Dec 6, 2022

evantahler commented Dec 6, 2022

BLOCKED: Bumps MySQL strict encrypt variant to match non-strict-encrypt #20111

BLOCKED: Bumps MySQL strict encrypt variant to match non-strict-encrypt #20111

Conversation

ryankfu commented Dec 6, 2022 • edited Loading

BLOCKED

What

How

Recommended reading order

🚨 User Impact 🚨

Pre-merge Checklist

Community member or Airbyter

Airbyter

Community member or Airbyter

Airbyter

Tests

github-actions bot commented Dec 6, 2022

Affected Connector Report

✅ Sources (0)

❌ Destinations (2)

👀 Other Modules (1)

Actionable Items

ryankfu commented Dec 6, 2022 • edited by github-actions bot Loading

Build Failed

ryankfu commented Dec 6, 2022 • edited by github-actions bot Loading

Build Failed

evantahler commented Dec 6, 2022 • edited Loading

ryankfu commented Dec 6, 2022 • edited by github-actions bot Loading

ryankfu commented Dec 6, 2022 • edited Loading

edgao commented Dec 6, 2022

evantahler commented Dec 6, 2022

ryankfu commented Dec 6, 2022 •

edited

Loading

ryankfu commented Dec 6, 2022 •

edited by github-actions bot

Loading

ryankfu commented Dec 6, 2022 •

edited by github-actions bot

Loading

evantahler commented Dec 6, 2022 •

edited

Loading

ryankfu commented Dec 6, 2022 •

edited by github-actions bot

Loading

ryankfu commented Dec 6, 2022 •

edited

Loading