[ISSUE #15628] apply lookback window on earliest datetime between sta…

[maxi297]

…rt and cursor

What

This change addresses issue #15628 . The lookback period should be applied to whatever is the most recent datetime between the start and the cursor defined by the state.

How

Applying the lookback window on max(start_datetime, cursor_datetime) instead of the start_datetime

🚨 User Impact 🚨

There should not be any breaking changes. However starting from this version, we will pull more data if there is a lookback window defined. So assuming a source with a state including the cursor field and a lookback window:

• Before: incremental sync would start from the cursor field value defined in the state
• After: incremental sync will start from the cursor field value defined in the state minus the lookback window

[maxi297]

Do we release at every pull request?

If so, I know #20019 bumps the version and should be merged soon so I'll wait for it to be merge before working on updating the version

[brianjlai]

There isn't a strict rule and on occasion we'll package up multiple PRs into the same release for convenience, so if you want them grouped because the other PR is going out, thats fine. Just make sure the changelog reflects both changes whether you include the blurb in this PR or the other that is actually doing the release

[brianjlai]

changes look good! nice job cleaning up this method too, I don't quite remember why we had originally wrote this method in a confusing way with the multiple cursor field comparisons against the start date

[maxi297]

/publish-cdk dry-run=true

🕑 https://github.com/airbytehq/airbyte/actions/runs/3649009000
✅ https://github.com/airbytehq/airbyte/actions/runs/3649009000

[maxi297]

/publish-cdk dry-run=false

🕑 https://github.com/airbytehq/airbyte/actions/runs/3649066583
✅ https://github.com/airbytehq/airbyte/actions/runs/3649066583