Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] add note on airbyte vs singer #20198

Closed
wants to merge 1 commit into from
Closed

[docs] add note on airbyte vs singer #20198

wants to merge 1 commit into from

Conversation

swyxio
Copy link
Contributor

@swyxio swyxio commented Dec 7, 2022

to clarify question raised during conference, and answered by @johnlafleur

@gosusnp i'm wondering if we need to note anything for [Protocol v1] (#19846)?

to clarify question raised during conference
@swyxio swyxio requested a review from a team as a code owner December 7, 2022 19:40
@octavia-squidington-iv octavia-squidington-iv added the area/documentation Improvements or additions to documentation label Dec 7, 2022
Copy link
Contributor

@evantahler evantahler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 for docs!

@evantahler
Copy link
Contributor

@sw-yx What about

## Acknowledgements
We'd like to note that we were initially inspired by Singer.io's [specification](https://github.com/singer-io/getting-started/blob/master/docs/SPEC.md#singer-specification) and would like to acknowledge that some of their design choices helped us bootstrap our project. We've since made a lot of modernizations to our protocol and specification, but don't want to forget the tools that helped us get started.

@gosusnp
Copy link
Contributor

gosusnp commented Dec 7, 2022

@sw-yx, what kind of notes did you have in mind?

I was looking at the change that added some changes that are going to be tagged as part of v1 (#17486)
Updates have been done in place, I think we should go over those changes and keep some version specific documentation.

@swyxio
Copy link
Contributor Author

swyxio commented Dec 9, 2022

@evantahler it doesnt link to the comparison doc, and its position at the end makes it hard to find leading poeple to still ask us despite including that mention

@gosusnp no other notes!

@natikgadzhi
Copy link
Contributor

Haven't heard the ask in a while, and Singer seems to be, ahem, more and more out of date.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants