Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail airbytePythonDockerApply if any steps fails #20217

Merged
merged 7 commits into from
Jan 17, 2023

Conversation

girarda
Copy link
Contributor

@girarda girarda commented Dec 8, 2022

What

How

Describe the solution

Recommended reading order

  1. airbyte-connector-builder-server/run_tests.sh
  2. airbyte-connector-builder-server/run_format.sh

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the connector is published, connector added to connector index as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here
Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub and connector version bumped by running the /publish command described here
Connector Generator
  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed

Tests

Unit

Put your unit tests output here.

Integration

Put your integration tests output here.

Acceptance

Put your acceptance tests output here.

@girarda girarda changed the title Fail if any steps fails Fail airbytePythonDockerApply if any steps fails Dec 8, 2022
@girarda girarda temporarily deployed to more-secrets December 8, 2022 03:22 — with GitHub Actions Inactive
@girarda girarda marked this pull request as ready for review December 8, 2022 03:22
@girarda girarda temporarily deployed to more-secrets December 8, 2022 03:24 — with GitHub Actions Inactive
@girarda girarda temporarily deployed to more-secrets December 8, 2022 03:24 — with GitHub Actions Inactive
Copy link
Contributor

@lmossman lmossman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes make sense to me, but we should hold off on merging until the build issues in this PR are resolved and it is merged: #20218

@girarda girarda temporarily deployed to more-secrets December 9, 2022 01:33 — with GitHub Actions Inactive
@girarda girarda temporarily deployed to more-secrets December 9, 2022 01:33 — with GitHub Actions Inactive
@girarda girarda temporarily deployed to more-secrets December 14, 2022 00:08 — with GitHub Actions Inactive
@girarda girarda temporarily deployed to more-secrets December 14, 2022 00:09 — with GitHub Actions Inactive
@girarda girarda enabled auto-merge (squash) January 10, 2023 15:01
@girarda girarda temporarily deployed to more-secrets January 10, 2023 15:03 — with GitHub Actions Inactive
@girarda girarda temporarily deployed to more-secrets January 10, 2023 15:03 — with GitHub Actions Inactive
@girarda girarda temporarily deployed to more-secrets January 13, 2023 19:57 — with GitHub Actions Inactive
@girarda girarda temporarily deployed to more-secrets January 13, 2023 19:58 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

There is no coverage information present for the Files changed

Total Project Coverage 26.6% 🍏

@girarda girarda temporarily deployed to more-secrets January 17, 2023 15:25 — with GitHub Actions Inactive
@girarda girarda temporarily deployed to more-secrets January 17, 2023 15:26 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

Airbyte Code Coverage

There is no coverage information present for the Files changed

Total Project Coverage 26.59% 🍏

@girarda girarda merged commit e93c8f7 into master Jan 17, 2023
@girarda girarda deleted the alex/fix_connector_builder_tests branch January 17, 2023 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants