Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create documentation for Destination namespace example settings #20255

Conversation

matter-q
Copy link
Contributor

@matter-q matter-q commented Dec 8, 2022

What

Closes #20137

How

Added "Learn more" link to documentation namespace

For test purposes, use the variable: REACT_APP_NEW_STREAMS_TABLE=true

Result

image

@matter-q matter-q requested a review from a team as a code owner December 8, 2022 18:32
@octavia-squidington-iv octavia-squidington-iv added area/platform issues related to the platform area/frontend Related to the Airbyte webapp labels Dec 8, 2022
@dizel852 dizel852 self-requested a review December 9, 2022 13:08
Copy link
Contributor

@dizel852 dizel852 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
Tested locally
Passing to @edmundito for final review

@dizel852 dizel852 requested a review from edmundito December 9, 2022 13:09
@edmundito edmundito requested review from krishnaglick and removed request for edmundito December 9, 2022 21:09
Copy link
Contributor

@krishnaglick krishnaglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Link is there and works.

- Added "Learn more" link to documentation namespace
@matter-q matter-q force-pushed the mark/create-documentation-for-Destination-namespace-example-settings branch from 9ed8e09 to 1af767e Compare December 12, 2022 19:23
@matter-q matter-q merged commit 5f4d43d into master Dec 12, 2022
@matter-q matter-q deleted the mark/create-documentation-for-Destination-namespace-example-settings branch December 12, 2022 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/frontend Related to the Airbyte webapp area/platform issues related to the platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create documentation for Destination namespace example settings
4 participants