Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restore containerOrchestrator image value #20313

Merged
merged 2 commits into from
Dec 13, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -671,6 +671,12 @@ public interface Configs {

// Container Orchestrator

/**
* Define if Airbyte should use the container orchestrator. Internal-use only.
* Should always be set to true - otherwise causes syncs to be run on workers instead.
*/
boolean getContainerOrchestratorEnabled();

/**
* Get the name of the container orchestrator secret. Internal-use only.
*/
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,7 @@ public class EnvConfigs implements Configs {
private static final String CONFIGS_DATABASE_INITIALIZATION_TIMEOUT_MS = "CONFIGS_DATABASE_INITIALIZATION_TIMEOUT_MS";
private static final String JOBS_DATABASE_MINIMUM_FLYWAY_MIGRATION_VERSION = "JOBS_DATABASE_MINIMUM_FLYWAY_MIGRATION_VERSION";
private static final String JOBS_DATABASE_INITIALIZATION_TIMEOUT_MS = "JOBS_DATABASE_INITIALIZATION_TIMEOUT_MS";
private static final String CONTAINER_ORCHESTRATOR_ENABLED = "CONTAINER_ORCHESTRATOR_ENABLED";
private static final String CONTAINER_ORCHESTRATOR_SECRET_NAME = "CONTAINER_ORCHESTRATOR_SECRET_NAME";
private static final String CONTAINER_ORCHESTRATOR_SECRET_MOUNT_PATH = "CONTAINER_ORCHESTRATOR_SECRET_MOUNT_PATH";
private static final String CONTAINER_ORCHESTRATOR_IMAGE = "CONTAINER_ORCHESTRATOR_IMAGE";
Expand Down Expand Up @@ -1057,6 +1058,11 @@ public Set<Integer> getTemporalWorkerPorts() {
return Arrays.stream(ports.split(",")).map(Integer::valueOf).collect(Collectors.toSet());
}

@Override
public boolean getContainerOrchestratorEnabled() {
return getEnvOrDefault(CONTAINER_ORCHESTRATOR_ENABLED, false, Boolean::valueOf);
}

@Override
public String getContainerOrchestratorSecretName() {
return getEnvOrDefault(CONTAINER_ORCHESTRATOR_SECRET_NAME, null);
Expand Down
1 change: 1 addition & 0 deletions airbyte-workers/src/main/resources/application.yml
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ airbyte:
specific-resource-defaults-enabled: ${CONNECTOR_SPECIFIC_RESOURCE_DEFAULTS_ENABLED:false}
container:
orchestrator:
enabled: ${CONTAINER_ORCHESTRATOR_ENABLED:false}
image: ${CONTAINER_ORCHESTRATOR_IMAGE:}
java-opts: ${CONTAINER_ORCHESTRATOR_JAVA_OPTS:}
secret-mount-path: ${CONTAINER_ORCHESTRATOR_SECRET_MOUNT_PATH:}
Expand Down
1 change: 1 addition & 0 deletions charts/airbyte-worker/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -347,6 +347,7 @@ secrets: {}
# JOB_KUBE_MAIN_CONTAINER_IMAGE_PULL_POLICY:

# # Launch a separate pod to orchestrate sync steps
# CONTAINER_ORCHESTRATOR_ENABLED: true
# CONTAINER_ORCHESTRATOR_IMAGE:

# # Open Telemetry Configuration
Expand Down
1 change: 1 addition & 0 deletions charts/airbyte/templates/env-configmap.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@ data:
WORKFLOW_FAILURE_RESTART_DELAY_SECONDS: ""
USE_STREAM_CAPABLE_STATE: "true"
AUTO_DETECT_SCHEMA: "false"
CONTAINER_ORCHESTRATOR_ENABLED: {{ .Values.worker.containerOrchestrator.enabled | quote }}
CONTAINER_ORCHESTRATOR_IMAGE: {{ .Values.worker.containerOrchestrator.image | quote }}
WORKERS_MICRONAUT_ENVIRONMENTS: "control-plane"
CRON_MICRONAUT_ENVIRONMENTS: "control-plane"
Expand Down
9 changes: 8 additions & 1 deletion charts/airbyte/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -795,7 +795,14 @@ worker:

hpa:
enabled: false

## Container Orchestrator
## enabled -- Enable or disable Orchestrator
## image -- Orchestrator image

containerOrchestrator:
enabled: true
image: ""

## @section Metrics parameters
metrics:
enabled: false
Expand Down
1 change: 1 addition & 0 deletions kube/overlays/dev-integration-test/.env
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,7 @@ JOB_KUBE_NODE_SELECTORS=
JOB_KUBE_MAIN_CONTAINER_IMAGE_PULL_POLICY=

# Launch a separate pod to orchestrate sync steps
CONTAINER_ORCHESTRATOR_ENABLED=true
CONTAINER_ORCHESTRATOR_IMAGE=

# Cloud Storage Configuration
Expand Down
1 change: 1 addition & 0 deletions kube/overlays/dev/.env
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,7 @@ JOB_KUBE_NODE_SELECTORS=
JOB_KUBE_MAIN_CONTAINER_IMAGE_PULL_POLICY=

# Launch a separate pod to orchestrate sync steps
CONTAINER_ORCHESTRATOR_ENABLED=true
CONTAINER_ORCHESTRATOR_IMAGE=

# Cloud Storage Configuration
Expand Down
1 change: 1 addition & 0 deletions kube/overlays/stable-with-resource-limits/.env
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,7 @@ JOB_KUBE_NODE_SELECTORS=
JOB_KUBE_MAIN_CONTAINER_IMAGE_PULL_POLICY=

# Launch a separate pod to orchestrate sync steps
CONTAINER_ORCHESTRATOR_ENABLED=true
CONTAINER_ORCHESTRATOR_IMAGE=

CONNECTOR_SPECIFIC_RESOURCE_DEFAULTS_ENABLED=true
Expand Down
1 change: 1 addition & 0 deletions kube/overlays/stable/.env
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,7 @@ JOB_KUBE_NODE_SELECTORS=
JOB_KUBE_MAIN_CONTAINER_IMAGE_PULL_POLICY=

# Launch a separate pod to orchestrate sync steps
CONTAINER_ORCHESTRATOR_ENABLED=true
CONTAINER_ORCHESTRATOR_IMAGE=

# Cloud Storage Configuration
Expand Down
5 changes: 5 additions & 0 deletions kube/resources/worker.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -220,6 +220,11 @@ spec:
secretKeyRef:
name: airbyte-secrets
key: STATE_STORAGE_MINIO_SECRET_ACCESS_KEY
- name: CONTAINER_ORCHESTRATOR_ENABLED
valueFrom:
configMapKeyRef:
name: airbyte-env
key: CONTAINER_ORCHESTRATOR_ENABLED
- name: CONTAINER_ORCHESTRATOR_IMAGE
valueFrom:
configMapKeyRef:
Expand Down