Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🪟 🔧 Refactor column selection callback #20544

Merged
merged 1 commit into from
Jan 2, 2023
Merged

🪟 🔧 Refactor column selection callback #20544

merged 1 commit into from
Jan 2, 2023

Conversation

josephkmh
Copy link
Contributor

@josephkmh josephkmh commented Dec 15, 2022 •
edited
Loading

What

@ambirdsall had a good suggestion to refactor the callback function when toggling a selected column/field: #20267 (comment)

This PR is a refactor that does not change any behavior. The callback for handling a field selection/deselection is pulled out of the StreamFieldTable component up into the CatalogSection component.

@octavia-squidington-iv octavia-squidington-iv added area/platform issues related to the platform area/frontend Related to the Airbyte webapp labels Dec 15, 2022
@josephkmh josephkmh assigned josephkmh and unassigned josephkmh Dec 15, 2022
@josephkmh josephkmh requested a review from ambirdsall December 15, 2022 20:36
@josephkmh josephkmh marked this pull request as ready for review December 15, 2022 20:39
@josephkmh josephkmh requested a review from a team as a code owner December 15, 2022 20:39
ambirdsall
ambirdsall approved these changes Dec 16, 2022
View reviewed changes
Copy link
Contributor

@ambirdsall ambirdsall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, and getting onSelectedFieldsUpdate to match the handleFieldToggle signature makes the hand-off to StreamFieldTable squeaky clean.

@josephkmh josephkmh mentioned this pull request Dec 22, 2022
Merged
@josephkmh josephkmh merged commit d71273d into master Jan 2, 2023
@josephkmh josephkmh deleted the joey/refactor-column-selection-callback branch January 2, 2023 16:22
This was referenced Jan 6, 2023
Closed
Closed
@github-actions github-actions bot mentioned this pull request Jan 6, 2023
Closed
This was referenced Jan 6, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ambirdsall ambirdsall ambirdsall approved these changes

Assignees
No one assigned
Labels
area/frontend Related to the Airbyte webapp area/platform issues related to the platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@josephkmh @ambirdsall @octavia-squidington-iv