-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Utilize React-Lazy for Code Splitting #20605
Merged
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
804f0f3
Top level lazy loading
krishnaglick fd9cb70
Lazyloading for Datepicker
krishnaglick 8561421
Cleanup export
krishnaglick 0c7996b
Better datepicker lazy loading
krishnaglick 0a9f21f
Sources routes lazy loaded
krishnaglick 20db48f
More connection page optimization
krishnaglick 42b03a4
Merge branch 'master' into kc/react-lazy-poc
krishnaglick e6e41d9
Merge branch 'master' into kc/react-lazy-poc
krishnaglick 6de4761
Cloud pass
krishnaglick 3964c4a
Merge branch 'master' into kc/react-lazy-poc
krishnaglick 7bb0fd8
Merge branch 'master' into kc/react-lazy-poc
krishnaglick c104018
Merge branch 'master' into kc/react-lazy-poc
krishnaglick 0c9ac15
Joseph code review
krishnaglick File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -162,3 +162,5 @@ export const DatePicker: React.FC<DatePickerProps> = ({ | |
</div> | ||
); | ||
}; | ||
|
||
export default DatePicker; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
export { DatePicker } from "./DatePicker"; | ||
export { DatePicker as default } from "./DatePicker"; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -94,3 +94,5 @@ export const AcceptEmailInvite: React.FC = () => { | |
</> | ||
); | ||
}; | ||
|
||
export default AcceptEmailInvite; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -36,3 +36,5 @@ export const DefaultView: React.FC = () => { | |
/> | ||
); | ||
}; | ||
|
||
export default DefaultView; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 4 additions & 0 deletions
4
airbyte-webapp/src/packages/cloud/views/auth/ConfirmPasswordResetPage/index.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1,5 @@ | ||
import { ResetPasswordConfirmPage } from "./ConfirmPasswordResetPage"; | ||
|
||
export * from "./ConfirmPasswordResetPage"; | ||
|
||
export default ResetPasswordConfirmPage; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 1 addition & 3 deletions
4
airbyte-webapp/src/packages/cloud/views/auth/LoginPage/index.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1 @@ | ||
import LoginPage from "./LoginPage"; | ||
|
||
export { LoginPage }; | ||
export { LoginPage as default } from "./LoginPage"; |
2 changes: 1 addition & 1 deletion
2
airbyte-webapp/src/packages/cloud/views/auth/ResetPasswordPage/index.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
import ResetPasswordPage from "./ResetPasswordPage"; | ||
|
||
export { ResetPasswordPage }; | ||
export default ResetPasswordPage; |
2 changes: 1 addition & 1 deletion
2
airbyte-webapp/src/packages/cloud/views/auth/SignupPage/index.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
import SignupPage from "./SignupPage"; | ||
|
||
export { SignupPage }; | ||
export default SignupPage; |
4 changes: 3 additions & 1 deletion
4
airbyte-webapp/src/packages/cloud/views/auth/components/PersonQuoteCover/index.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1,3 @@ | ||
export { PersonQuoteCover } from "./PersonQuoteCover"; | ||
import { PersonQuoteCover } from "./PersonQuoteCover"; | ||
|
||
export default PersonQuoteCover; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
import Auth from "./Auth"; | ||
import { Auth } from "./Auth"; | ||
|
||
export { Auth }; | ||
export default Auth; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
import CreditsPage from "./CreditsPage"; | ||
|
||
export { CreditsPage }; | ||
export default CreditsPage; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
import WorkspacesPage from "./WorkspacesPage"; | ||
|
||
export { WorkspacesPage }; | ||
export default WorkspacesPage; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -250,3 +250,5 @@ export const CreationFormPage: React.FC = () => { | |
</> | ||
); | ||
}; | ||
|
||
export default CreationFormPage; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1,3 @@ | ||
export { SpeakeasyRedirectPage } from "./SpeakeasyRedirectPage"; | ||
import { SpeakeasyRedirectPage } from "./SpeakeasyRedirectPage"; | ||
|
||
export default SpeakeasyRedirectPage; |
2 changes: 1 addition & 1 deletion
2
airbyte-webapp/src/pages/destination/AllDestinationsPage/index.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
export { AllDestinationsPage } from "./AllDestinationsPage"; | ||
export { AllDestinationsPage as default } from "./AllDestinationsPage"; |
2 changes: 1 addition & 1 deletion
2
airbyte-webapp/src/pages/destination/DestinationItemPage/index.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
export { DestinationItemPage } from "./DestinationItemPage"; | ||
export { DestinationItemPage as default } from "./DestinationItemPage"; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -75,3 +75,5 @@ export const DestinationOverviewPage = () => { | |
</> | ||
); | ||
}; | ||
|
||
export default DestinationOverviewPage; |
2 changes: 1 addition & 1 deletion
2
airbyte-webapp/src/pages/destination/DestinationSettingsPage/index.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
export { DestinationSettingsPage } from "./DestinationSettingsPage"; | ||
export { DestinationSettingsPage as default } from "./DestinationSettingsPage"; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a specific reason we're only wanting this for OSS and don't have it in the cloud routes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No! I've gone ahead and done a Cloud pass too :)