Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable auto detect schema activity bits #20615

Merged
merged 7 commits into from
Dec 19, 2022
Merged

Disable auto detect schema activity bits #20615

merged 7 commits into from
Dec 19, 2022

Conversation

jdpgrailsdev
Copy link
Contributor

What

  • Disable auto detect schema bits that prevent data plane from running

How

  • Disable usage of ConfigFetchActivity

@octavia-squidington-iv octavia-squidington-iv added area/platform issues related to the platform area/worker Related to worker labels Dec 16, 2022
@jdpgrailsdev jdpgrailsdev temporarily deployed to more-secrets December 16, 2022 23:49 — with GitHub Actions Inactive
@jdpgrailsdev jdpgrailsdev temporarily deployed to more-secrets December 16, 2022 23:49 — with GitHub Actions Inactive
@jdpgrailsdev jdpgrailsdev temporarily deployed to more-secrets December 16, 2022 23:53 — with GitHub Actions Inactive
@jdpgrailsdev jdpgrailsdev temporarily deployed to more-secrets December 16, 2022 23:53 — with GitHub Actions Inactive
alovew
alovew reviewed Dec 17, 2022
View reviewed changes
airbyte-workers/src/test/java/io/airbyte/workers/temporal/sync/SyncWorkflowTest.java Outdated
@@ -255,6 +256,7 @@ void testReplicationFailure() {
}

@Test
@Disabled
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need to disable all these? I think we can just remove verifyShouldRefreshSchema and verifyRefreshSchema

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alovew You are correct. We figured that out after doing the blanket disable. I believe that we only ended up disabling one test and just commented out the references to those verifications in the others.

@jdpgrailsdev jdpgrailsdev temporarily deployed to more-secrets December 17, 2022 00:11 — with GitHub Actions Inactive
@jdpgrailsdev jdpgrailsdev temporarily deployed to more-secrets December 17, 2022 00:11 — with GitHub Actions Inactive
@jdpgrailsdev jdpgrailsdev temporarily deployed to more-secrets December 17, 2022 00:14 — with GitHub Actions Inactive
@jdpgrailsdev jdpgrailsdev temporarily deployed to more-secrets December 17, 2022 00:15 — with GitHub Actions Inactive
@jdpgrailsdev jdpgrailsdev temporarily deployed to more-secrets December 17, 2022 00:29 — with GitHub Actions Inactive
@jdpgrailsdev jdpgrailsdev temporarily deployed to more-secrets December 17, 2022 00:29 — with GitHub Actions Inactive
@jdpgrailsdev jdpgrailsdev temporarily deployed to more-secrets December 17, 2022 00:33 — with GitHub Actions Inactive
@jdpgrailsdev jdpgrailsdev temporarily deployed to more-secrets December 17, 2022 00:33 — with GitHub Actions Inactive
@git-phu git-phu temporarily deployed to more-secrets December 19, 2022 17:29 — with GitHub Actions Inactive
@git-phu git-phu temporarily deployed to more-secrets December 19, 2022 17:29 — with GitHub Actions Inactive
@git-phu
Copy link
Contributor

git-phu commented Dec 19, 2022

/approve-and-merge reason="Fix to allow data planes to run without requiring direct database connectivity, which was the intended behavior"

@octavia-approvington
Copy link
Contributor

After a careful ML study,
we think this looks okay.
imagine code being okay

@octavia-approvington octavia-approvington merged commit c0838f8 into master Dec 19, 2022
@octavia-approvington octavia-approvington deleted the jonathan/p0-fix-data-plan-config-fetch branch December 19, 2022 21:36
@github-actions github-actions bot mentioned this pull request Dec 27, 2022
Merged
This was referenced Jan 6, 2023
Closed
Closed
This was referenced Jan 6, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@octavia-approvington octavia-approvington octavia-approvington approved these changes

@alovew alovew alovew approved these changes

@benmoriceau benmoriceau benmoriceau approved these changes

@git-phu git-phu git-phu approved these changes

@pmossman pmossman Awaiting requested review from pmossman

Assignees
No one assigned
Labels
area/platform issues related to the platform area/worker Related to worker
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jdpgrailsdev @git-phu @octavia-approvington @benmoriceau @alovew @octavia-squidington-iv