-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🪟 🐛 Fix non-breaking schema changes preference issues #20625
Conversation
@@ -153,6 +153,7 @@ | |||
"connectionForm.nonBreakingChangesPreference.label": "Non-breaking schema updates detected*", | |||
"connectionForm.nonBreakingChangesPreference.message": "Set how Airbyte handles syncs when it detects a non-breaking schema change in the source", | |||
"connectionForm.nonBreakingChangesPreference.ignore": "Ignore", | |||
"connectionForm.nonBreakingChangesPreference.disable": "Disable connection", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made this "Disable connection" instead of "Pause sync" as shown in the design because we don't really have a concept of pausing in the UI and this is what will actually happen - @andyjih thoughts?
@@ -11,12 +11,13 @@ import { useConnectionFormService } from "hooks/services/ConnectionForm/Connecti | |||
|
|||
import styles from "./NonBreakingChangesPreferenceField.module.scss"; | |||
|
|||
const SUPPORTED_PREFERENCES = [NonBreakingChangesPreference.ignore, NonBreakingChangesPreference.disable]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We may add more options in the future that may not have an i18n string or may need to wait on the backend, so they need to be supported manually.
.connectorLabel { | ||
max-width: 328px; | ||
margin-right: variables.$spacing-xl; | ||
vertical-align: top; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably copied from the Schedule field. That also needs to be cleaned up but I omitted it here because of the scope of the PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved pending a thumbs up on wording!
6252665
to
129e378
Compare
What
Fixes three issues: