Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source Amazon Ads: fix bug with handling: "Report date is too far in the past." #20662

Merged
merged 14 commits into from
Jan 4, 2023
Merged

Source Amazon Ads: fix bug with handling: "Report date is too far in the past." #20662

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
aeea0ec
fix bug with handling: "Report date is too far in the past."
grubberr Dec 19, 2022
1e26ead
amazon-ads.md updated
grubberr Dec 19, 2022
b0894f8
Merge branch 'master' into grubberr/oncall-1211-source-amazon-ads
grubberr Dec 21, 2022
e5da9d1
check min start_date
grubberr Dec 21, 2022
ccd8d3c
test_check improved
grubberr Dec 21, 2022
1d2a8ea
comments added
grubberr Dec 21, 2022
d95cbf7
Merge branch 'master' into grubberr/oncall-1211-source-amazon-ads
grubberr Dec 22, 2022
3c331f1
fix comment
grubberr Dec 22, 2022
bcb8b3f
acceptance-test-config.yml - migrate to new format
grubberr Dec 22, 2022
eef0ce5
expected_records.txt -> expected_records.jsonl
grubberr Jan 4, 2023
3af2d93
Merge branch 'master' into grubberr/oncall-1211-source-amazon-ads
grubberr Jan 4, 2023
c3152b2
auto-bump connector version
octavia-squidington-iii Jan 4, 2023
4986f1d
Merge branch 'master' into grubberr/oncall-1211-source-amazon-ads
grubberr Jan 4, 2023
5f529d1
Merge branch 'master' into grubberr/oncall-1211-source-amazon-ads
grubberr Jan 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/source-amazon-ads/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,5 +13,5 @@ ENV AIRBYTE_ENTRYPOINT "python /airbyte/integration_code/main.py"
ENTRYPOINT ["python", "/airbyte/integration_code/main.py"]


LABEL io.airbyte.version=0.1.25
LABEL io.airbyte.version=0.1.26
LABEL io.airbyte.name=airbyte/source-amazon-ads
2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/source-amazon-ads/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

from setuptools import find_packages, setup

MAIN_REQUIREMENTS = ["airbyte-cdk~=0.2", "requests_oauthlib~=1.3.1", "pendulum~=2.1.2"]
MAIN_REQUIREMENTS = ["airbyte-cdk~=0.16", "requests_oauthlib~=1.3.1", "pendulum~=2.1.2"]

TEST_REQUIREMENTS = [
"pytest~=6.1",
Expand Down
2 changes: 1 addition & 1 deletion ...s/connectors/source-amazon-ads/source_amazon_ads/streams/report_streams/report_streams.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ class ReportStream(BasicAmazonAdsStream, ABC):
# Check if the connector received an error: 'Report date is too far in the past. Reports are only available for 60 days.'
# In theory, it does not have to get such an error because the connector correctly calculates the start date,
# but from practice, we can still catch such errors from time to time.
(406, "Report date is too far in the past."),
(406, re.compile(r"^Report date is too far in the past\.")),
grubberr marked this conversation as resolved.
Show resolved Hide resolved
]

def __init__(self, config: Mapping[str, Any], profiles: List[Profile], authenticator: Oauth2Authenticator):
Expand Down
1 change: 1 addition & 0 deletions docs/integrations/sources/amazon-ads.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,7 @@ Information about expected report generation waiting time you may find [here](ht

| Version | Date | Pull Request | Subject |
|:--------|:-----------|:---------------------------------------------------------|:----------------------------------------------------------------------------------------------------------------|
| 0.1.26 | 2022-12-19 | [20662](https://github.com/airbytehq/airbyte/pull/20662) | Fix bug with handling: "Report date is too far in the past." |
| 0.1.25 | 2022-11-08 | [18985](https://github.com/airbytehq/airbyte/pull/18985) | Remove "report_wait_timeout", "report_generation_max_retries" from config |
| 0.1.24 | 2022-10-19 | [17475](https://github.com/airbytehq/airbyte/pull/17475) | Add filters for state on brand, product and display campaigns |
| 0.1.23 | 2022-09-06 | [16342](https://github.com/airbytehq/airbyte/pull/16342) | Add attribution reports |
Expand Down