-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix a bug where the OAuthAuthenticator was misnamed #20700
Merged
octavia-approvington
merged 5 commits into
master
from
brian/fix_small_handwritten_schema_definitions
Dec 20, 2022
Merged
fix a bug where the OAuthAuthenticator was misnamed #20700
octavia-approvington
merged 5 commits into
master
from
brian/fix_small_handwritten_schema_definitions
Dec 20, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
girarda
approved these changes
Dec 20, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢
clnoll
approved these changes
Dec 20, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Contributor
Author
Contributor
Author
/approve-and-merge reason=”small fix an issue w/ schema validation identified and blocking a community developer” |
octavia-approvington
approved these changes
Dec 20, 2022
octavia-approvington
deleted the
brian/fix_small_handwritten_schema_definitions
branch
December 20, 2022 21:16
This was referenced Jan 6, 2023
This was referenced Jan 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
#20422 (comment)
Fixes a small bug where the correct component name in our existing code was
OAuthAuthenticator
, but in the handwritten schema I accidentally named itDeclarativeOauthAuthenticator
which impacted someone developing an integration using that component.How
Correctly renames the component in the schema used to validate manifests:
Example of correct manifest which was tested against: