Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix a bug where the OAuthAuthenticator was misnamed #20700

Merged

Conversation

brianjlai
Copy link
Contributor

What

#20422 (comment)

Fixes a small bug where the correct component name in our existing code was OAuthAuthenticator, but in the handwritten schema I accidentally named it DeclarativeOauthAuthenticator which impacted someone developing an integration using that component.

How

Correctly renames the component in the schema used to validate manifests:

Example of correct manifest which was tested against:

authenticator:
  type: "OAuthAuthenticator"
  token_refresh_endpoint: "{{ config['token_refresh_endpoint'] }}"
  client_id: "{{ config['client_id'] }}"
  client_secret: "{{ config['client_secret'] }}"
  refresh_token: ""
  refresh_request_body: 
    audience: "{{ config['graphql_endpoint'] }}"
  grant_type: "client_credentials"

@brianjlai brianjlai requested a review from a team as a code owner December 20, 2022 05:22
@octavia-squidington-iv octavia-squidington-iv added the CDK Connector Development Kit label Dec 20, 2022
Copy link
Contributor

@girarda girarda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

Copy link
Contributor

@clnoll clnoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@brianjlai
Copy link
Contributor Author

brianjlai commented Dec 20, 2022

/publish-cdk dry-run=true

🕑 https://github.com/airbytehq/airbyte/actions/runs/3744029086
https://github.com/airbytehq/airbyte/actions/runs/3744029086

@brianjlai
Copy link
Contributor Author

brianjlai commented Dec 20, 2022

/publish-cdk dry-run=false

🕑 https://github.com/airbytehq/airbyte/actions/runs/3744087927
https://github.com/airbytehq/airbyte/actions/runs/3744087927

@brianjlai
Copy link
Contributor Author

/approve-and-merge reason=”small fix an issue w/ schema validation identified and blocking a community developer”

@octavia-approvington
Copy link
Contributor

Approve this
imagine the commander saying yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CDK Connector Development Kit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants