Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🪟 🔧 Fixed passed props to <CheckBoxControl /> which cause error in console #20711

Merged
merged 5 commits into from
Jan 12, 2023
Merged

🪟 🔧 Fixed passed props to <CheckBoxControl /> which cause error in console #20711

merged 5 commits into from
Jan 12, 2023

Conversation

dizel852
Copy link
Contributor

What

Fixes passed prop to <CheckBoxControl /> which cause error in console

How

Remove unnecessary passed props to <CheckBoxControl />:

  • checkbox - redundant prop
  • message={meta.touched && meta.error && formatMessage({ id: meta.error })} - there is no error message for this type of control

image

@dizel852 dizel852 requested a review from a team as a code owner December 20, 2022 13:25
@octavia-squidington-iv octavia-squidington-iv added area/platform issues related to the platform area/frontend Related to the Airbyte webapp labels Dec 20, 2022
@dizel852 dizel852 requested review from YatsukBogdan1 and matter-q and removed request for a team December 20, 2022 13:25
@dizel852 dizel852 requested a review from a team December 20, 2022 13:45
YatsukBogdan1
YatsukBogdan1 approved these changes Dec 20, 2022
View reviewed changes
Copy link
Contributor

@YatsukBogdan1 YatsukBogdan1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dizel852 dizel852 requested a review from edmundito December 20, 2022 13:46
@edmundito
Copy link
Contributor

edmundito commented Dec 20, 2022 •
edited
Loading

Would you mind cleaning up the props type/interface in CheckBoxControl as well? Looks like the checkbox: boolean prop is there but is it needed?

@dizel852
Copy link
Contributor Author

dizel852 commented Dec 20, 2022 •
edited
Loading

Would you mind cleaning up the props type/interface in CheckBoxControl as well? Looks like the checkbox: boolean prop is there but is it needed?

Sure, I wanted to make a "tiny" fix, but okay will fix that also. 👍

@dizel852 dizel852 self-assigned this Dec 21, 2022
@octavia-squidington-iv octavia-squidington-iv removed the area/platform issues related to the platform label Jan 10, 2023
@dizel852 dizel852 merged commit f50d6f5 into master Jan 12, 2023
@dizel852 dizel852 deleted the vlad/fixed-passed-bollean-prop-console-error branch January 12, 2023 11:45
@octavia-squidington-iii octavia-squidington-iii mentioned this pull request Jan 12, 2023
Merged
jbfbell pushed a commit that referenced this pull request Jan 13, 2023
@dizel852 @jbfbell
🪟 🔧 Fixed passed props to <CheckBoxControl /> which cause error in …
64702d7 
…console (#20711)

* fixed sourceDefinitionId and destinationDefinitionId

* clean up props
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YatsukBogdan1 YatsukBogdan1 YatsukBogdan1 approved these changes

@edmundito edmundito edmundito approved these changes

@matter-q matter-q Awaiting requested review from matter-q

Assignees

@dizel852 dizel852

Labels
area/frontend Related to the Airbyte webapp team/platform-move
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dizel852 @edmundito @YatsukBogdan1 @octavia-squidington-iv