Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SurveyCTO: Docs Fix #20749

Merged
merged 24 commits into from
Mar 15, 2023
Merged

SurveyCTO: Docs Fix #20749

merged 24 commits into from
Mar 15, 2023

Conversation

siddhant3030
Copy link
Contributor

@siddhant3030 siddhant3030 commented Dec 21, 2022 •
edited
Loading

What

Describe what the change is solving

The SurveyCTO connector had some misinformation in the docs. This PR is to fix the docs for the SurveyCTO.

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions

@octavia-squidington-iv octavia-squidington-iv added area/documentation Improvements or additions to documentation community labels Dec 21, 2022
@marcosmarxm
Copy link
Member

@siddhant3030 Airbyte is in code freeze. I'll able to merge your contribution next week only.

@siddhant3030
Copy link
Contributor Author

@marcosmarxm can we merge this PR?

@siddhant3030
Copy link
Contributor Author

@sajarin any update on this?

@siddhant3030
Copy link
Contributor Author

@marcosmarxm any update on this?

@siddhant3030
Copy link
Contributor Author

@marcosmarxm please merge this if this looks ok.

@marcosmarxm marcosmarxm merged commit 585fad6 into airbytehq:master Mar 15, 2023
adriennevermorel pushed a commit to adriennevermorel/airbyte that referenced this pull request Mar 17, 2023
@siddhant3030 @sajarin @adriennevermorel
fixing the docs for surveycto (airbytehq#20749)
af3fcd5 
Co-authored-by: Sajarin <sajarindider@gmail.com>
erohmensing pushed a commit that referenced this pull request Mar 22, 2023
@siddhant3030 @sajarin @erohmensing
fixing the docs for surveycto (#20749)
2d91de5 
Co-authored-by: Sajarin <sajarindider@gmail.com>
erohmensing pushed a commit that referenced this pull request Mar 22, 2023
@siddhant3030 @sajarin @erohmensing
fixing the docs for surveycto (#20749)
e4adda5 
Co-authored-by: Sajarin <sajarindider@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcosmarxm marcosmarxm marcosmarxm approved these changes

Assignees
No one assigned
Labels
area/documentation Improvements or additions to documentation community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@siddhant3030 @marcosmarxm @octavia-squidington-iv @sajarin