Highlight invalid cursor or primary key in new connection streams table #20756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
octavia-squidington-iv
added
area/platform
edmundito
requested review from
teallarson and
edmundito
and removed request for
a team
matter-q
changed the title
matter-q
force-pushed
the
mark/highlight-invalid-cursor-or-primary-key-in-new-connection-streams-table
branch
from
4d09e37 to
26d8c8d
Compare
added 2 commits
January 3, 2023 13:57
- Added error handling for Cursor and Primary Key
- Added individual error handling for Cursor and Primary Key - Added feature variable to encapsulate new changes with new streams table
matter-q
force-pushed
the
mark/highlight-invalid-cursor-or-primary-key-in-new-connection-streams-table
branch
from
a7f0b6d to
b6e118d
Compare
matter-q
changed the title
- Added individual error handling for Cursor and Primary Key - Added feature variable to encapsulate new changes with new streams table
|
@matter-q The storybook failed to build |
- Added individual error handling for Cursor and Primary Key - Added feature variable to encapsulate new changes with new streams table
|
@matter-q While testing, I noticed an edge case that I didn't realize when creating the original ticket. You can use a hubspot source to reproduce this:
Notice that the sync mode is empty in one of the rows and should also be highlighted red:
Does it make sense to fix it in this PR? |
edmundito
reviewed
Jan 3, 2023
airbyte-webapp/src/pages/ConnectionPage/pages/ConnectionItemPage/ConnectionReplicationTab.tsx
Outdated
Show resolved
Hide resolved
airbyte-webapp/src/views/Connection/ConnectionForm/formConfig.tsx
Outdated
Show resolved
Hide resolved
I think it's better to fix in this PR |
added 3 commits
January 4, 2023 01:41
- Added individual error handling for Cursor and Primary Key - Added feature variable to encapsulate new changes with new streams table
- Added individual error handling for Cursor and Primary Key - Added feature variable to encapsulate new changes with new streams table
- Added individual error handling for Cursor and Primary Key - Added feature variable to encapsulate new changes with new streams table
|
Followed up over standup - The sync mode issue will be skipped for now and resolved separately as part of the larger bulk edit mode behavior |
edmundito
approved these changes
Jan 4, 2023
matter-q
deleted the
mark/highlight-invalid-cursor-or-primary-key-in-new-connection-streams-table
branch
This was referenced Jan 6, 2023
This was referenced Jan 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Closes #19918
How
Added error state for required fields for new connection streams table
For test purposes, use the environment variable: REACT_APP_NEW_STREAMS_TABLE=true
Loom
https://www.loom.com/share/4c8c6dac261d48728bbd2803315dcbcb