Source Google Analytics Data API: prepare connector to сertification #20769
Conversation
roman-yermilov-gl
requested review from
grubberr,
davydov-d,
arsenlosenko,
bazarnov,
artem1205,
lazebnyi and
darynaishchenko
octavia-squidington-iv
added
area/connectors
| from source_google_analytics_data_api.authenticator import GoogleServiceKeyAuthenticator | ||
|
|
||
|
|
||
| private_key = """ |
There was a problem hiding this comment.
it looks like a real key, can we replace it with some kind of dummy string?
There was a problem hiding this comment.
What's wrong with it looks like a real key ?
There was a problem hiding this comment.
it makes me think it is real
There was a problem hiding this comment.
Of course it is real. But again, what is wrong with it?
There was a problem hiding this comment.
Private keys should not be committed to public repositories
There was a problem hiding this comment.
This private key does not belong to any Airbyte account or any other account in the Universe
There was a problem hiding this comment.
Does it matter if only I know it?
There was a problem hiding this comment.
well in case this remains in the code and gets merged, I bet I'm not the last person to ask about this key - so the answer is yes
There was a problem hiding this comment.
I will uncover the mystery of the origin of this private key to every reviewer, or they can solve it by themselves by reading our discussion
...tions/connectors/source-google-analytics-data-api/source_google_analytics_data_api/source.py
Show resolved
Hide resolved
| """ | ||
|
|
||
|
|
||
| def test_authenticator(mocker): |
There was a problem hiding this comment.
nit: requests_mock is a better option to mock http requests, since is less erroneous (see #18931)
…s; test coverage 90%
roman-yermilov-gl
force-pushed
the
ryermilov/source-google-analytics-data-api-to-beta
branch
from
f09437a to
9841bb3
Compare
roman-yermilov-gl
force-pushed
the
ryermilov/source-google-analytics-data-api-to-beta
branch
from
9841bb3 to
b0c57b1
Compare
roman-yermilov-gl
changed the title
roman-yermilov-gl
force-pushed
the
ryermilov/source-google-analytics-data-api-to-beta
branch
from
b0c57b1 to
8b03744
Compare
roman-yermilov-gl
changed the title
- Added validation for reports defined by user to avoid errors like KeyError 'name' - Added 429 error handling: return empty data and keep going - Streams without 'date' dimension are considered to be a full refresh streams - Fixed type and description of `date_ranges_start_date` field
roman-yermilov-gl
force-pushed
the
ryermilov/source-google-analytics-data-api-to-beta
branch
from
8b03744 to
4ee2e54
Compare
What
date_ranges_start_datefield