Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Destination-bigquery: add ability to impersonate another GCP account #20788

Closed
wants to merge 5 commits into from

Conversation

grishick
Copy link
Contributor

What

This PR is based on Impersonation PR by @marcelopio and adds testing for credential impersonation. In order to add more test cases, I had to refactor BigQueryDestinationTest

@grishick grishick changed the title Greg/bigquery impersonate Destination-bigquery: add ability to impersonate another GCP account Dec 22, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Dec 22, 2022

Affected Connector Report

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to do the following as needed:

  • Run integration tests
  • Bump connector or module version
  • Add changelog
  • Publish the new version

✅ Sources (0)

Connector Version Changelog Publish
  • See "Actionable Items" below for how to resolve warnings and errors.

✅ Destinations (2)

Connector Version Changelog Publish
destination-bigquery 1.2.9
destination-bigquery-denormalized 1.2.9
  • See "Actionable Items" below for how to resolve warnings and errors.

👀 Other Modules (1)

  • base-normalization

Actionable Items

(click to expand)

Category Status Actionable Item
Version
mismatch
The version of the connector is different from its normal variant. Please bump the version of the connector.

doc not found
The connector does not seem to have a documentation file. This can be normal (e.g. basic connector like source-jdbc is not published or documented). Please double-check to make sure that it is not a bug.
Changelog
doc not found
The connector does not seem to have a documentation file. This can be normal (e.g. basic connector like source-jdbc is not published or documented). Please double-check to make sure that it is not a bug.

changelog missing
There is no chnagelog for the current version of the connector. If you are the author of the current version, please add a changelog.
Publish
not in seed
The connector is not in the seed file (e.g. source_definitions.yaml), so its publication status cannot be checked. This can be normal (e.g. some connectors are cloud-specific, and only listed in the cloud seed file). Please double-check to make sure that it is not a bug.

diff seed version
The connector exists in the seed file, but the latest version is not listed there. This usually means that the latest version is not published. Please use the /publish command to publish the latest version.

@grishick
Copy link
Contributor Author

grishick commented Dec 22, 2022

/test connector=connectors/destination-bigquery

🕑 connectors/destination-bigquery https://github.com/airbytehq/airbyte/actions/runs/3754145341
❌ connectors/destination-bigquery https://github.com/airbytehq/airbyte/actions/runs/3754145341
🐛 https://gradle.com/s/ollbu3eudut24

Build Failed

Test summary info:

Could not find result summary

@grishick grishick requested review from edgao and jbfbell December 23, 2022 01:04
@grishick
Copy link
Contributor Author

grishick commented Dec 23, 2022

/test connector=connectors/destination-bigquery

🕑 connectors/destination-bigquery https://github.com/airbytehq/airbyte/actions/runs/3762316180

@grishick grishick force-pushed the greg/bigquery-impersonate branch from b0a245e to ad30dd4 Compare December 23, 2022 01:08
@grishick
Copy link
Contributor Author

Note: I am going to move test refactoring into a separate PR.

@grishick
Copy link
Contributor Author

grishick commented Dec 23, 2022

/test connector=connectors/destination-bigquery

🕑 connectors/destination-bigquery https://github.com/airbytehq/airbyte/actions/runs/3762378964

@grishick
Copy link
Contributor Author

Moving test refactoring into this PR: #20851
Closing this PR until GCS impersonation is also implemented

@grishick grishick closed this Dec 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants