Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust GitHub flow for FE chapter #20813

Merged
merged 3 commits into from
Jan 9, 2023
Merged

Adjust GitHub flow for FE chapter #20813

merged 3 commits into from
Jan 9, 2023

Conversation

timroes
Copy link
Collaborator

@timroes timroes commented Dec 22, 2022 •
edited
Loading

What

  • Remove the codeownership of the FE code from the frontend team, since the pings from other team's code was a nuisance.
  • Remove the pinging of the frontend team on team/frontend labels, due to too much noise (also the team/frontend label will be replaced by the area/frontend label)
  • Remove the design ownership over icons, since we'll need to come up with a better process next year for this.
  • Adjust labeler config to label PRs automatically with area/frontend if they touch frontend code (and no longer area/platform).

@timroes timroes temporarily deployed to more-secrets December 22, 2022 20:15 — with GitHub Actions Inactive
@timroes timroes temporarily deployed to more-secrets December 22, 2022 20:15 — with GitHub Actions Inactive
@timroes timroes temporarily deployed to more-secrets January 9, 2023 12:16 — with GitHub Actions Inactive
@timroes timroes temporarily deployed to more-secrets January 9, 2023 12:16 — with GitHub Actions Inactive
@timroes timroes merged commit 7be5950 into master Jan 9, 2023
@timroes timroes deleted the tim/label-removal branch January 9, 2023 12:53
@github-actions github-actions bot mentioned this pull request Jan 9, 2023
Closed
@octavia-squidington-iii octavia-squidington-iii mentioned this pull request Jan 12, 2023
Merged
jbfbell pushed a commit that referenced this pull request Jan 13, 2023
@timroes @jbfbell
Adjust GitHub flow for FE chapter (#20813)
44daeb5 
* Adjust GitHub flow for FE chapter

* Change labeler config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ambirdsall ambirdsall ambirdsall approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timroes @ambirdsall