[local airbyte cdk tests] update README.md to fix gradle command and … #20821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…support more docker images
girarda
reviewed
Dec 22, 2022
| @@ -112,7 +112,13 @@ Create a symlink that connects `<connector-directory>/airbyte-cdk` to your local | |||
| ln -s ../../../airbyte-cdk/python airbyte-cdk | |||
| ``` | |||
|
|
|||
| Add the following lines to your connector's `Dockerfile`, before the line that installs dependencies via `pip install -e .`: | |||
| Now that you have a symbolic link in your source, you will nedd to install it in the docker image. Depending on how the docker image is build you will have two possibilities: | |||
| 1. If image building process uses a temporary image called `builder`, add the following just after the copy of the installed packages to the folder `/usr/local`: | |||
There was a problem hiding this comment.
can you link to an example of an image use a builder tmp image for reference?
There was a problem hiding this comment.
don't we also need to run pip install when the the image does not use the builder tmp image?
There was a problem hiding this comment.
can you link to an example of an image use a builder tmp image for reference?
This Dockerfile pip install in a "builder" image and copy the files on the "real" image. This didn't seem to work for me. I assume it is because of the symlink. Therefore instead, I did add the lines:
COPY airbyte-cdk airbyte-cdk
RUN PYTHONUSERBASE=/usr/local pip install -e ./airbyte-cdk
don't we also need to run pip install when the the image does not use the builder tmp image?
Yes! This is why I kept point # 2 here
girarda
approved these changes
Dec 22, 2022
This was referenced Jan 6, 2023
This was referenced Jan 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Update documentation to allow to test a broader scope of images