-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Destination Redshift: Fix integration tests #20882
Destination Redshift: Fix integration tests #20882
Conversation
/test connector=connectors/destination-redshift
Build PassedTest summary info:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, for those unaware, this addresses a reflection issue when testing Destination Acceptance Test
due to changes from #19281
/approve-and-merge reason=” Fixes destination-redshift acceptance test failures on master. See: https://github.com/airbytehq/airbyte/actions/runs/3783267406 and currently on-call so taking this risk in favor of changes for improving FileBuffer performance" |
What
Destination Redshift: Reflection cannot access package private class RedshiftInsertDestinationAcceptanceTest
How
Made RedshiftInsertDestinationAcceptanceTest class public access
Recommended reading order
RedshiftInsertDestinationAcceptanceTest.java
🚨 User Impact 🚨
No impact