Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Source: Google Analytics 4 (GA4) - improve config validation and SAT #20889

Merged
merged 39 commits into from
Jan 9, 2023
Merged

Source: Google Analytics 4 (GA4) - improve config validation and SAT #20889

merged 39 commits into from
Jan 9, 2023

Conversation

grubberr
Copy link
Contributor

@grubberr grubberr commented Dec 27, 2022 •
edited
Loading

Signed-off-by: Sergey Chvalyuk grubberr@gmail.com

What

Try to fix next PR(s)
https://github.com/airbytehq/alpha-beta-issues/issues/281
https://github.com/airbytehq/alpha-beta-issues/issues/303
https://github.com/airbytehq/alpha-beta-issues/issues/375
https://github.com/airbytehq/alpha-beta-issues/issues/376
https://github.com/airbytehq/alpha-beta-issues/issues/421
https://github.com/airbytehq/alpha-beta-issues/issues/422
https://github.com/airbytehq/alpha-beta-issues/issues/424
https://github.com/airbytehq/alpha-beta-issues/issues/457
https://github.com/airbytehq/alpha-beta-issues/issues/592
https://github.com/airbytehq/alpha-beta-issues/issues/614
https://github.com/airbytehq/alpha-beta-issues/issues/615
https://github.com/airbytehq/alpha-beta-issues/issues/616
https://github.com/airbytehq/alpha-beta-issues/issues/648

  • SAT new format, abnormal_state added, incremental added
  • config validation greatly improved
  • STATE handling for incremental improved

Pre-merge Checklist

Expand the relevant checklist and delete the others.

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

@grubberr
bump 0.0.4
a7d986d 
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
@grubberr grubberr self-assigned this Dec 27, 2022
@grubberr
remove ChainMap
ce2bc0d 
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
@grubberr
Copy link
Contributor Author

grubberr commented Dec 27, 2022 •
edited by github-actions bot
Loading

/test connector=connectors/source-google-analytics-data-api

🕑 connectors/source-google-analytics-data-api https://github.com/airbytehq/airbyte/actions/runs/3789108475
✅ connectors/source-google-analytics-data-api https://github.com/airbytehq/airbyte/actions/runs/3789108475
Python tests coverage:

Name                                                Stmts   Miss  Cover
-----------------------------------------------------------------------
source_google_analytics_data_api/__init__.py            2      0   100%
source_google_analytics_data_api/source.py            169     48    72%
source_google_analytics_data_api/utils.py               8      3    62%
source_google_analytics_data_api/authenticator.py      44     23    48%
-----------------------------------------------------------------------
TOTAL                                                 223     74    67%
	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          12      4    67%   16-19
	 source_acceptance_test/config.py                       140      5    96%   87, 93, 238, 242-243
	 source_acceptance_test/conftest.py                     208     92    56%   36, 42-44, 49, 54, 77, 83, 89-91, 110, 115-117, 123-125, 131-132, 137-138, 143, 149, 158-167, 173-178, 193, 217, 248, 254, 262-267, 275-280, 288-301, 306-312, 319-330, 337-353
	 source_acceptance_test/plugin.py                        69     25    64%   22-23, 31, 36, 120-140, 144-148
	 source_acceptance_test/tests/test_core.py              402    115    71%   53, 58, 93-104, 109-116, 120-121, 125-126, 308, 346-363, 376-387, 391-396, 402, 435-440, 478-485, 528-530, 533, 598-606, 618-621, 626, 682-683, 689, 692, 728-738, 751-776
	 source_acceptance_test/tests/test_incremental.py       158     14    91%   52-59, 64-77, 240
	 source_acceptance_test/utils/asserts.py                 39      2    95%   62-63
	 source_acceptance_test/utils/common.py                  94     10    89%   16-17, 32-38, 72, 75
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/connector_runner.py       133     33    75%   24-27, 46-47, 50-54, 57-58, 73-75, 78-80, 83-85, 88-90, 93-95, 124-125, 159-161, 208
	 source_acceptance_test/utils/json_schema_helper.py     107     13    88%   30-31, 38, 41, 65-68, 96, 120, 192-194
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1603    336    79%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:63: Skipping TestIncremental.test_two_sequential_reads: not found in the config.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:377: The previous and actual discovered catalogs are identical.
============ 27 passed, 2 skipped, 29 warnings in 108.04s (0:01:48) ============

@grubberr
_validate_and_transform added
1146128 
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
@grubberr
custom_reports_schema.json added
19e5b5a 
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
@grubberr
"required": ["name", "dimensions", "metrics"] - added
1da5688 
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
@grubberr
source.py improved
378075d 
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
@grubberr
Copy link
Contributor Author

grubberr commented Dec 28, 2022 •
edited by github-actions bot
Loading

/test connector=connectors/source-salesforce

🕑 connectors/source-salesforce https://github.com/airbytehq/airbyte/actions/runs/3794707148
❌ connectors/source-salesforce https://github.com/airbytehq/airbyte/actions/runs/3794707148
🐛 https://gradle.com/s/ngmxb3tlc4fvq

Build Failed

Test summary info:

	 =========================== short test summary info ============================
	 FAILED integration_tests/integration_test.py::test_parallel_discover - Assert...
	 �[31m================== �[31m�[1m1 failed�[0m, �[32m5 passed�[0m, �[33m189 warnings�[0m�[31m in 35.42s�[0m�[31m ==================�[0m

@grubberr
Copy link
Contributor Author

grubberr commented Dec 28, 2022 •
edited by github-actions bot
Loading

/test connector=connectors/source-google-analytics-data-api

🕑 connectors/source-google-analytics-data-api https://github.com/airbytehq/airbyte/actions/runs/3795173513
✅ connectors/source-google-analytics-data-api https://github.com/airbytehq/airbyte/actions/runs/3795173513
Python tests coverage:

Name                                                Stmts   Miss  Cover
-----------------------------------------------------------------------
source_google_analytics_data_api/__init__.py            2      0   100%
source_google_analytics_data_api/source.py            190     55    71%
source_google_analytics_data_api/utils.py               8      3    62%
source_google_analytics_data_api/authenticator.py      44     23    48%
-----------------------------------------------------------------------
TOTAL                                                 244     81    67%
	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          12      4    67%   16-19
	 source_acceptance_test/config.py                       140      5    96%   87, 93, 238, 242-243
	 source_acceptance_test/conftest.py                     208     92    56%   36, 42-44, 49, 54, 77, 83, 89-91, 110, 115-117, 123-125, 131-132, 137-138, 143, 149, 158-167, 173-178, 193, 217, 248, 254, 262-267, 275-280, 288-301, 306-312, 319-330, 337-353
	 source_acceptance_test/plugin.py                        69     25    64%   22-23, 31, 36, 120-140, 144-148
	 source_acceptance_test/tests/test_core.py              402    115    71%   53, 58, 93-104, 109-116, 120-121, 125-126, 308, 346-363, 376-387, 391-396, 402, 435-440, 478-485, 528-530, 533, 598-606, 618-621, 626, 682-683, 689, 692, 728-738, 751-776
	 source_acceptance_test/tests/test_incremental.py       158     14    91%   52-59, 64-77, 240
	 source_acceptance_test/utils/asserts.py                 39      2    95%   62-63
	 source_acceptance_test/utils/common.py                  94     10    89%   16-17, 32-38, 72, 75
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/connector_runner.py       133     33    75%   24-27, 46-47, 50-54, 57-58, 73-75, 78-80, 83-85, 88-90, 93-95, 124-125, 159-161, 208
	 source_acceptance_test/utils/json_schema_helper.py     107     13    88%   30-31, 38, 41, 65-68, 96, 120, 192-194
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1603    336    79%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:63: Skipping TestIncremental.test_two_sequential_reads: not found in the config.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:377: The previous and actual discovered catalogs are identical.
============ 27 passed, 2 skipped, 29 warnings in 105.84s (0:01:45) ============

@grubberr
Merge branch 'master' into grubberr/source-google-analytics-data-api-…
70a92fa 
…improve-config-validation
@grubberr
validate "credentials.credentials_json"
b844d3a 
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
@grubberr
Merge branch 'master' into grubberr/source-google-analytics-data-api-…
7eaaee8 
…improve-config-validation
@grubberr
test_check_connection -> test_check
bfbbcd4 
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
@grubberr
Copy link
Contributor Author

grubberr commented Dec 30, 2022 •
edited by github-actions bot
Loading

/test connector=connectors/source-google-analytics-data-api

🕑 connectors/source-google-analytics-data-api https://github.com/airbytehq/airbyte/actions/runs/3805965209
✅ connectors/source-google-analytics-data-api https://github.com/airbytehq/airbyte/actions/runs/3805965209
Python tests coverage:

Name                                                Stmts   Miss  Cover
-----------------------------------------------------------------------
source_google_analytics_data_api/__init__.py            2      0   100%
source_google_analytics_data_api/authenticator.py      44      2    95%
source_google_analytics_data_api/source.py            200     42    79%
source_google_analytics_data_api/utils.py               8      2    75%
-----------------------------------------------------------------------
TOTAL                                                 254     46    82%
	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          12      4    67%   16-19
	 source_acceptance_test/config.py                       140      5    96%   87, 93, 238, 242-243
	 source_acceptance_test/conftest.py                     208     92    56%   36, 42-44, 49, 54, 77, 83, 89-91, 110, 115-117, 123-125, 131-132, 137-138, 143, 149, 158-167, 173-178, 193, 217, 248, 254, 262-267, 275-280, 288-301, 306-312, 319-330, 337-353
	 source_acceptance_test/plugin.py                        69     25    64%   22-23, 31, 36, 120-140, 144-148
	 source_acceptance_test/tests/test_core.py              402    115    71%   53, 58, 93-104, 109-116, 120-121, 125-126, 308, 346-363, 376-387, 391-396, 402, 435-440, 478-485, 528-530, 533, 598-606, 618-621, 626, 682-683, 689, 692, 728-738, 751-776
	 source_acceptance_test/tests/test_incremental.py       158     14    91%   52-59, 64-77, 240
	 source_acceptance_test/utils/asserts.py                 39      2    95%   62-63
	 source_acceptance_test/utils/common.py                  94     10    89%   16-17, 32-38, 72, 75
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/connector_runner.py       133     33    75%   24-27, 46-47, 50-54, 57-58, 73-75, 78-80, 83-85, 88-90, 93-95, 124-125, 159-161, 208
	 source_acceptance_test/utils/json_schema_helper.py     107     13    88%   30-31, 38, 41, 65-68, 96, 120, 192-194
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1603    336    79%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:63: Skipping TestIncremental.test_two_sequential_reads: not found in the config.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:377: The previous and actual discovered catalogs are identical.
============ 27 passed, 2 skipped, 29 warnings in 90.63s (0:01:30) =============

@grubberr
validate "Start Date"
0801207 
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
@grubberr
acceptance-test-config.yml new format
148da90 
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
@grubberr
Merge branch 'master' into grubberr/source-google-analytics-data-api-…
82f4183 
…improve-config-validation
@grubberr
re-implement incremental
888e519 
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
@grubberr
add incremental to SAT
3431a62 
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
@grubberr
Merge branch 'master' into grubberr/source-google-analytics-data-api-…
ae7280d 
…improve-config-validation
@grubberr
instance.saved_authenticator added
3155012 
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
@grubberr
Merge branch 'master' into grubberr/source-google-analytics-data-api-…
ebe423a 
…improve-config-validation
@grubberr
convert old datetime state format
f623891 
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
@grubberr grubberr changed the title Source: Google Analytics 4 (GA4) - improve config validation Source: Google Analytics 4 (GA4) - improve config validation, SAT Jan 4, 2023
@grubberr
Copy link
Contributor Author

grubberr commented Jan 4, 2023 •
edited by github-actions bot
Loading

/test connector=connectors/source-google-analytics-data-api

🕑 connectors/source-google-analytics-data-api https://github.com/airbytehq/airbyte/actions/runs/3837917611
❌ connectors/source-google-analytics-data-api https://github.com/airbytehq/airbyte/actions/runs/3837917611
🐛 https://gradle.com/s/4ackingi3o656

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestConnection::test_check[inputs0] - Failed: Timeout >3...
FAILED test_core.py::TestDiscovery::test_discover[inputs0] - Failed: Timeout ...
FAILED test_core.py::TestBasicRead::test_read[inputs0] - docker.errors.Contai...
FAILED test_full_refresh.py::TestFullRefresh::test_sequential_reads[inputs0]
FAILED test_incremental.py::TestIncremental::test_two_sequential_reads[inputs0]
FAILED test_incremental.py::TestIncremental::test_read_sequential_slices[inputs0]
ERROR test_core.py::TestDiscovery::test_defined_cursors_exist_in_schema[inputs0]
ERROR test_core.py::TestDiscovery::test_defined_refs_exist_in_schema[inputs0]
ERROR test_core.py::TestDiscovery::test_defined_keyword_exist_in_schema[inputs0-allOf]
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:377: The previous and actual discovered catalogs are identical.
======== 6 failed, 21 passed, 1 skipped, 3 errors in 875.67s (0:14:35) =========

@grubberr
google-analytics-v4.md updated
9ed7ddf 
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
@octavia-squidington-iv octavia-squidington-iv added the area/documentation Improvements or additions to documentation label Jan 4, 2023
@grubberr
GoogleAnalyticsDataApiTestConnectionStream -> GoogleAnalyticsDataApiM…
3a68b27 
…etadataStream

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
@grubberr
improve validation window_in_days
7bd9fcf 
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
@grubberr
Copy link
Contributor Author

grubberr commented Jan 6, 2023 •
edited by github-actions bot
Loading

/test connector=connectors/source-google-analytics-data-api

🕑 connectors/source-google-analytics-data-api https://github.com/airbytehq/airbyte/actions/runs/3853484703
❌ connectors/source-google-analytics-data-api https://github.com/airbytehq/airbyte/actions/runs/3853484703
🐛 https://gradle.com/s/yxnqhzxxz7nvm

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestSpec::test_backward_compatibility[inputs0] - source_...
FAILED test_core.py::TestConnection::test_check[inputs0] - Failed: Timeout >3...
FAILED test_core.py::TestDiscovery::test_discover[inputs0] - Failed: Timeout ...
FAILED test_core.py::TestBasicRead::test_read[inputs0] - Failed: Timeout >300.0s
FAILED test_full_refresh.py::TestFullRefresh::test_sequential_reads[inputs0]
FAILED test_incremental.py::TestIncremental::test_two_sequential_reads[inputs0]
FAILED test_incremental.py::TestIncremental::test_read_sequential_slices[inputs0]
ERROR test_core.py::TestDiscovery::test_defined_cursors_exist_in_schema[inputs0]
ERROR test_core.py::TestDiscovery::test_defined_refs_exist_in_schema[inputs0]
ERROR test_core.py::TestDiscovery::test_defined_keyword_exist_in_schema[inputs0-allOf]
ERROR test_core.py::TestDiscovery::test_backward_compatibility[inputs0] - doc...
============= 7 failed, 20 passed, 4 errors in 1094.45s (0:18:14) ==============

@grubberr
read_records removed
c30b863 
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
@grubberr
Copy link
Contributor Author

grubberr commented Jan 6, 2023 •
edited by github-actions bot
Loading

/test connector=connectors/source-google-analytics-data-api

🕑 connectors/source-google-analytics-data-api https://github.com/airbytehq/airbyte/actions/runs/3854952634
✅ connectors/source-google-analytics-data-api https://github.com/airbytehq/airbyte/actions/runs/3854952634
Python tests coverage:

Name                                                Stmts   Miss  Cover
-----------------------------------------------------------------------
source_google_analytics_data_api/__init__.py            2      0   100%
source_google_analytics_data_api/authenticator.py      44      3    93%
source_google_analytics_data_api/source.py            183     37    80%
source_google_analytics_data_api/utils.py              14      5    64%
-----------------------------------------------------------------------
TOTAL                                                 243     45    81%
	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          12      4    67%   16-19
	 source_acceptance_test/config.py                       141      5    96%   87, 93, 239, 243-244
	 source_acceptance_test/conftest.py                     211     95    55%   36, 42-44, 49, 54, 77, 83, 89-91, 110, 115-117, 123-125, 131-132, 137-138, 143, 149, 158-167, 173-178, 193, 217, 248, 254, 262-267, 275-285, 293-306, 311-317, 324-335, 342-358
	 source_acceptance_test/plugin.py                        69     25    64%   22-23, 31, 36, 120-140, 144-148
	 source_acceptance_test/tests/test_core.py              402    115    71%   53, 58, 93-104, 109-116, 120-121, 125-126, 308, 346-363, 376-387, 391-396, 402, 435-440, 478-485, 528-530, 533, 598-606, 618-621, 626, 682-683, 689, 692, 728-738, 751-776
	 source_acceptance_test/tests/test_incremental.py       160     14    91%   56-63, 68-81, 244
	 source_acceptance_test/utils/asserts.py                 39      2    95%   62-63
	 source_acceptance_test/utils/common.py                  94     10    89%   16-17, 32-38, 72, 75
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/connector_runner.py       133     33    75%   24-27, 46-47, 50-54, 57-58, 73-75, 78-80, 83-85, 88-90, 93-95, 124-125, 159-161, 208
	 source_acceptance_test/utils/json_schema_helper.py     107     13    88%   30-31, 38, 41, 65-68, 96, 120, 192-194
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1609    339    79%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:103: Backward compatibility tests are disabled for version 0.0.3.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:377: The previous and actual discovered catalogs are identical.
================== 29 passed, 2 skipped in 363.18s (0:06:03) ===================

@grubberr
both dimensions and metrics are required
73aa6c7 
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
@grubberr
Merge branch 'master' into grubberr/source-google-analytics-data-api-…
3a5db20 
…improve-config-validation
@grubberr
remove GoogleAnalyticsDataApiGenericStream class, keep only GoogleAna…
4c48e81 
…lyticsDataApiBaseStream

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
@grubberr
"date" dimension is mandatory
65cdf3a 
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
@grubberr
Copy link
Contributor Author

grubberr commented Jan 7, 2023 •
edited by github-actions bot
Loading

/test connector=connectors/source-google-analytics-data-api

🕑 connectors/source-google-analytics-data-api https://github.com/airbytehq/airbyte/actions/runs/3861912370
✅ connectors/source-google-analytics-data-api https://github.com/airbytehq/airbyte/actions/runs/3861912370
Python tests coverage:

Name                                                Stmts   Miss  Cover
-----------------------------------------------------------------------
source_google_analytics_data_api/__init__.py            2      0   100%
source_google_analytics_data_api/authenticator.py      44      3    93%
source_google_analytics_data_api/source.py            177     36    80%
source_google_analytics_data_api/utils.py              14      5    64%
-----------------------------------------------------------------------
TOTAL                                                 237     44    81%
	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          12      4    67%   16-19
	 source_acceptance_test/config.py                       141      5    96%   87, 93, 239, 243-244
	 source_acceptance_test/conftest.py                     211     95    55%   36, 42-44, 49, 54, 77, 83, 89-91, 110, 115-117, 123-125, 131-132, 137-138, 143, 149, 158-167, 173-178, 193, 217, 248, 254, 262-267, 275-285, 293-306, 311-317, 324-335, 342-358
	 source_acceptance_test/plugin.py                        69     25    64%   22-23, 31, 36, 120-140, 144-148
	 source_acceptance_test/tests/test_core.py              402    115    71%   53, 58, 93-104, 109-116, 120-121, 125-126, 308, 346-363, 376-387, 391-396, 402, 435-440, 478-485, 528-530, 533, 598-606, 618-621, 626, 682-683, 689, 692, 728-738, 751-776
	 source_acceptance_test/tests/test_incremental.py       160     14    91%   56-63, 68-81, 244
	 source_acceptance_test/utils/asserts.py                 39      2    95%   62-63
	 source_acceptance_test/utils/common.py                  94     10    89%   16-17, 32-38, 72, 75
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/connector_runner.py       133     33    75%   24-27, 46-47, 50-54, 57-58, 73-75, 78-80, 83-85, 88-90, 93-95, 124-125, 159-161, 208
	 source_acceptance_test/utils/json_schema_helper.py     107     13    88%   30-31, 38, 41, 65-68, 96, 120, 192-194
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1609    339    79%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:103: Backward compatibility tests are disabled for version 0.0.3.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:377: The previous and actual discovered catalogs are identical.
================== 29 passed, 2 skipped in 450.18s (0:07:30) ===================

@grubberr
check that custom dimensions and metrics are valid
402a123 
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
@grubberr
bump 0.1.0
6228510 
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
@grubberr
Copy link
Contributor Author

grubberr commented Jan 8, 2023 •
edited by github-actions bot
Loading

/test connector=connectors/source-google-analytics-data-api

🕑 connectors/source-google-analytics-data-api https://github.com/airbytehq/airbyte/actions/runs/3866372379
❌ connectors/source-google-analytics-data-api https://github.com/airbytehq/airbyte/actions/runs/3866372379
🐛 https://gradle.com/s/g76njztcnp7o2

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestConnection::test_check[inputs0] - Failed: Timeout >3...
FAILED test_core.py::TestDiscovery::test_discover[inputs0] - Failed: Timeout ...
FAILED test_incremental.py::TestIncremental::test_read_sequential_slices[inputs0]
ERROR test_core.py::TestDiscovery::test_defined_cursors_exist_in_schema[inputs0]
ERROR test_core.py::TestDiscovery::test_defined_refs_exist_in_schema[inputs0]
ERROR test_core.py::TestDiscovery::test_defined_keyword_exist_in_schema[inputs0-allOf]
ERROR test_core.py::TestDiscovery::test_backward_compatibility[inputs0] - doc...
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:103: Backward compatibility tests are disabled for version 0.0.3.
======== 3 failed, 23 passed, 1 skipped, 4 errors in 1068.45s (0:17:48) ========

@grubberr
should_retry 429 changed
55e5c1c 
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
@grubberr
Copy link
Contributor Author

grubberr commented Jan 9, 2023 •
edited by github-actions bot
Loading

/test connector=connectors/source-google-analytics-data-api

🕑 connectors/source-google-analytics-data-api https://github.com/airbytehq/airbyte/actions/runs/3872009586
❌ connectors/source-google-analytics-data-api https://github.com/airbytehq/airbyte/actions/runs/3872009586
🐛 https://gradle.com/s/mw3nudv3ie4sm

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestConnection::test_check[inputs0] - AssertionError: as...
FAILED test_core.py::TestDiscovery::test_discover[inputs0] - docker.errors.Co...
FAILED test_incremental.py::TestIncremental::test_two_sequential_reads[inputs0]
FAILED test_incremental.py::TestIncremental::test_read_sequential_slices[inputs0]
ERROR test_core.py::TestDiscovery::test_defined_cursors_exist_in_schema[inputs0]
ERROR test_core.py::TestDiscovery::test_defined_refs_exist_in_schema[inputs0]
ERROR test_core.py::TestDiscovery::test_defined_keyword_exist_in_schema[inputs0-allOf]
ERROR test_core.py::TestDiscovery::test_defined_keyword_exist_in_schema[inputs0-not]
ERROR test_core.py::TestDiscovery::test_primary_keys_exist_in_schema[inputs0]
ERROR test_core.py::TestDiscovery::test_streams_has_sync_modes[inputs0] - doc...
ERROR test_core.py::TestDiscovery::test_additional_properties_is_true[inputs0]
ERROR test_core.py::TestDiscovery::test_backward_compatibility[inputs0] - doc...
ERROR test_core.py::TestBasicRead::test_read[inputs0] - docker.errors.Contain...
ERROR test_full_refresh.py::TestFullRefresh::test_sequential_reads[inputs0]
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:103: Backward compatibility tests are disabled for version 0.0.3.
============= 4 failed, 16 passed, 1 skipped, 10 errors in 34.25s ==============

@grubberr
added doc string
0caca7f 
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
@grubberr
Copy link
Contributor Author

grubberr commented Jan 9, 2023 •
edited by github-actions bot
Loading

/publish connector=connectors/source-google-analytics-data-api

🕑 Publishing the following connectors:
connectors/source-google-analytics-data-api
https://github.com/airbytehq/airbyte/actions/runs/3872291544


Connector Did it publish? Were definitions generated?
connectors/source-google-analytics-data-api ❌ ❌

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@grubberr
self._stop_iteration added
f87f5e2 
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
@grubberr
Copy link
Contributor Author

grubberr commented Jan 9, 2023 •
edited by github-actions bot
Loading

/publish connector=connectors/source-google-analytics-data-api

🕑 Publishing the following connectors:
connectors/source-google-analytics-data-api
https://github.com/airbytehq/airbyte/actions/runs/3872793196


Connector Did it publish? Were definitions generated?
connectors/source-google-analytics-data-api ❌ ❌

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@grubberr
failed to get metadata, over quota, try later
931e364 
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
@grubberr
Copy link
Contributor Author

grubberr commented Jan 9, 2023 •
edited by github-actions bot
Loading

/publish connector=connectors/source-google-analytics-data-api

🕑 Publishing the following connectors:
connectors/source-google-analytics-data-api
https://github.com/airbytehq/airbyte/actions/runs/3873658474


Connector Did it publish? Were definitions generated?
connectors/source-google-analytics-data-api ✅ ✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets January 9, 2023 12:42 — with GitHub Actions Inactive
@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets January 9, 2023 12:42 — with GitHub Actions Inactive
@grubberr grubberr merged commit 4923edf into master Jan 9, 2023
@grubberr grubberr deleted the grubberr/source-google-analytics-data-api-improve-config-validation branch January 9, 2023 14:52
@github-actions github-actions bot mentioned this pull request Jan 9, 2023
Closed
@octavia-squidington-iii octavia-squidington-iii mentioned this pull request Jan 12, 2023
Merged
jbfbell pushed a commit that referenced this pull request Jan 13, 2023
@grubberr @jbfbell
Source: Google Analytics 4 (GA4) - improve config validation and SAT (#…
ad140b5 
…20889)

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bazarnov bazarnov bazarnov approved these changes

@davydov-d davydov-d Awaiting requested review from davydov-d

@darynaishchenko darynaishchenko Awaiting requested review from darynaishchenko

@arsenlosenko arsenlosenko Awaiting requested review from arsenlosenko

@lazebnyi lazebnyi Awaiting requested review from lazebnyi

@artem1205 artem1205 Awaiting requested review from artem1205

Assignees

@grubberr grubberr

Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/google-analytics-data-api
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@grubberr @bazarnov @octavia-squidington-iii @octavia-squidington-iv