SAT: check for nullity of docker runner in previous_discovered_catalog

[alafanechere]

What

When we create the previous_discovered_catalog_fixture we call discover on the previous_connector_docker_runner object. This object is None if we cannot find a previous connector version.
The existing fixture code did not check for nullity of the object and the AttributeError: 'NoneType' object has no attribute 'call_discover can be raised.

This bug is noticeable now because of the recent change of #20435 which accesses previous_discovered_catalog before checking the nullity of previous_connector_docker_runner.

How

Make the fixture return None if the previous docker runner is None (like we do for previous_connector_spec_fixture)

[github-actions]

Affected Connector Report

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to do the following as needed:

• Run integration tests
• Bump connector or module version
• Add changelog
• Publish the new version

✅ Sources (63)

Connector	Version	Changelog	Publish
source-airtable	0.1.3	✅	✅
source-amazon-ads	0.1.25	✅	✅
source-amazon-seller-partner	0.2.29	✅	✅
source-amazon-sqs	0.1.0	✅	✅
source-amplitude	0.1.19	✅	✅
source-appsflyer	0.1.0	✅	✅
source-asana	0.1.5	✅	✅
source-azure-table	0.1.3	✅	✅
source-braintree	0.1.3	✅	✅
source-cart	0.2.0	✅	✅
source-chargebee	0.1.16	✅	✅
source-commercetools	0.1.0	✅	✅
source-confluence	0.1.1	✅	✅
source-datadog	0.1.0	✅	✅
source-delighted	0.2.0	✅	✅
source-drift	0.2.5	✅	✅
source-facebook-marketing	0.2.79	✅	✅
source-freshcaller	0.1.0	✅	✅
source-freshsales	0.1.2	✅	✅
source-freshservice	0.1.1	✅	✅
source-github	0.3.10	✅	✅
source-gitlab	0.1.12	✅	✅
source-google-ads	0.2.5	✅	✅
source-google-search-console	0.1.18	✅	✅
source-greenhouse	0.3.0	✅	✅
source-harvest	0.1.12	✅	✅
source-instagram	1.0.0	✅	✅
source-iterable	0.1.22	✅	✅
source-klaviyo	0.1.10	✅	✅
source-lemlist	0.1.1	✅	✅
source-lever-hiring	0.1.3	✅	✅
source-linnworks	0.1.5	✅	✅
source-mailchimp	0.3.0	✅	✅
source-mailgun	0.1.0	✅	✅
source-monday	0.2.1	✅	✅
source-notion	0.1.10	✅	✅
source-okta	0.1.13	✅	✅
source-onesignal	0.1.2	✅	✅
source-openweather	0.1.6	✅	✅
source-outreach	0.1.2	✅	✅
source-pardot	0.1.1	✅	✅
source-paystack	0.1.1	✅	✅
source-pinterest	0.2.1	✅	✅
source-pipedrive	0.1.13	✅	✅
source-plaid	0.3.2	✅	✅
source-posthog	0.1.8	✅	✅
source-prestashop	0.3.0	✅	✅
source-quickbooks-singer	0.1.5	✅	✅
source-recharge	0.2.4	✅	✅
source-retently	0.1.3	✅	✅
source-salesforce	1.0.27	✅	✅
source-salesloft	0.1.3	✅	✅
source-sendgrid	0.2.16	✅	✅
source-sentry	0.1.7	✅	✅
source-strava	0.1.2	✅	✅
source-surveymonkey	0.1.13	✅	✅
source-tplcentral	0.1.1	✅	✅
source-twilio	0.1.14	✅	✅
source-weatherstack	0.1.0	✅	✅
source-youtube-analytics	0.1.3	✅	✅
source-zendesk-sunshine	0.1.1	✅	✅
source-zendesk-talk	0.1.5	✅	✅
source-zenloop	0.1.4	✅	✅

• See "Actionable Items" below for how to resolve warnings and errors.

✅ Destinations (0)

Connector	Version	Changelog	Publish

• See "Actionable Items" below for how to resolve warnings and errors.

✅ Other Modules (0)

Actionable Items

(click to expand)

Category	Status	Actionable Item
Version	❌ mismatch	The version of the connector is different from its normal variant. Please bump the version of the connector.
	⚠ doc not found	The connector does not seem to have a documentation file. This can be normal (e.g. basic connector like source-jdbc is not published or documented). Please double-check to make sure that it is not a bug.
Changelog	⚠ doc not found	The connector does not seem to have a documentation file. This can be normal (e.g. basic connector like source-jdbc is not published or documented). Please double-check to make sure that it is not a bug.
	❌ changelog missing	There is no chnagelog for the current version of the connector. If you are the author of the current version, please add a changelog.
Publish	⚠ not in seed	The connector is not in the seed file (e.g. source_definitions.yaml), so its publication status cannot be checked. This can be normal (e.g. some connectors are cloud-specific, and only listed in the cloud seed file). Please double-check to make sure that it is not a bug.
	❌ diff seed version	The connector exists in the seed file, but the latest version is not listed there. This usually means that the latest version is not published. Please use the /publish command to publish the latest version.

[evantahler]

There are few pending CDK PRs - just a reminder to make sure the version numbers are right :D

[alafanechere]

/publish connector=bases/source-acceptance-test auto-bump-version=false

🕑 Publishing the following connectors:
bases/source-acceptance-test
https://github.com/airbytehq/airbyte/actions/runs/3827896665

Connector	Did it publish?	Were definitions generated?
bases/source-acceptance-test	✅	❌

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️