🪟 🚦 E2E: Fix duplicated database object warning #20926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edmundito
reviewed
Jan 5, 2023
matter-q
suggested changes
Jan 12, 2023
Co-authored-by: Mark Berger <mark.berger@globallogic.com>
edmundito
approved these changes
Jan 12, 2023
jbfbell
pushed a commit
that referenced
this pull request
Jan 13, 2023
* replace "cypress-postgres" with "pg-promise" npm package * update cypress config * update userDefineConnection type and naming * Update airbyte-webapp-e2e-tests/cypress/plugins/index.ts Co-authored-by: Mark Berger <mark.berger@globallogic.com> Co-authored-by: Mark Berger <mark.berger@globallogic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Resolves #21221
In logs we have the warning:
WARNING: Creating a duplicate database object for the same connection.That happens because of 3rd party package we use for data manipulation in Postgres DB.
How
The PR replaces
"cypress-postgres"with"pg-promise"(which actually was used under the hood in "cypress-postgres")and updates the config to close the connection with DB after querying it.