Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source Salesforce: fix tests #20927

Merged
merged 8 commits into from
Jan 4, 2023
Merged

Source Salesforce: fix tests #20927

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
ec508a6
Source Salesforce: fix tests
artem1205 Dec 29, 2022
ed5cae3
Source Salesforce: update expected records
artem1205 Dec 30, 2022
f8833b0
Source Salesforce: update expected records
artem1205 Dec 30, 2022
f6c5d08
Source Salesforce: update docs; bump version
artem1205 Jan 2, 2023
e3250cf
Source Salesforce: update acceptance test reason
artem1205 Jan 4, 2023
d089d73
Merge branch 'master' into artem1205/source-salesforce-fix-build
artem1205 Jan 4, 2023
856e1aa
auto-bump connector version
octavia-squidington-iii Jan 4, 2023
31a31c4
Merge branch 'master' into artem1205/source-salesforce-fix-build
artem1205 Jan 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion airbyte-config/init/src/main/resources/seed/source_definitions.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1431,7 +1431,7 @@
- name: Salesforce
sourceDefinitionId: b117307c-14b6-41aa-9422-947e34922962
dockerRepository: airbyte/source-salesforce
dockerImageTag: 1.0.27
dockerImageTag: 1.0.28
documentationUrl: https://docs.airbyte.com/integrations/sources/salesforce
icon: salesforce.svg
sourceType: api
Expand Down
2 changes: 1 addition & 1 deletion airbyte-config/init/src/main/resources/seed/source_specs.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12857,7 +12857,7 @@
supportsNormalization: false
supportsDBT: false
supported_destination_sync_modes: []
- dockerImage: "airbyte/source-salesforce:1.0.27"
- dockerImage: "airbyte/source-salesforce:1.0.28"
spec:
documentationUrl: "https://docs.airbyte.com/integrations/sources/salesforce"
connectionSpecification:
Expand Down
2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/source-salesforce/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,5 +13,5 @@ RUN pip install .

ENTRYPOINT ["python", "/airbyte/integration_code/main.py"]

LABEL io.airbyte.version=1.0.27
LABEL io.airbyte.version=1.0.28
LABEL io.airbyte.name=airbyte/source-salesforce
2 changes: 2 additions & 0 deletions airbyte-integrations/connectors/source-salesforce/acceptance-test-config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,8 @@ acceptance_tests:
bypass_reason: "impossible to fill the stream with data because it is an organic traffic"
- name: "ActiveScratchOrgShare"
bypass_reason: "impossible to fill the stream with data because it is an organic traffic"
- name: "Describe"
bypass_reason: "Data is not permanent"
incremental:
tests:
- config_path: "secrets/config.json"
Expand Down
9,818 changes: 9,725 additions & 93 deletions airbyte-integrations/connectors/source-salesforce/integration_tests/expected_records.jsonl
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/source-salesforce/source_salesforce/api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -343,7 +343,7 @@ def load_schema(name: str, stream_options: Mapping[str, Any]) -> Tuple[str, Opti
stream_schemas = {}
for i in range(0, len(stream_names), self.parallel_tasks_size):
chunk_stream_names = stream_names[i : i + self.parallel_tasks_size]
with concurrent.futures.ThreadPoolExecutor(max_workers=len(chunk_stream_names)) as executor:
with concurrent.futures.ThreadPoolExecutor() as executor:
for stream_name, schema, err in executor.map(
lambda args: load_schema(*args), [(stream_name, stream_objects[stream_name]) for stream_name in chunk_stream_names]
):
Expand Down
1 change: 1 addition & 0 deletions docs/integrations/sources/salesforce.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,7 @@ Now that you have set up the Salesforce source connector, check out the followin

| Version | Date | Pull Request | Subject |
|:--------|:-----------|:---------------------------------------------------------|:---------------------------------------------------------------------------------------------------------------------------------|
| 1.0.28 | 2022-12-29 | [20927](https://github.com/airbytehq/airbyte/pull/20927) | Fix tests; add expected records |
| 1.0.27 | 2022-11-29 | [19869](https://github.com/airbytehq/airbyte/pull/19869) | Remove `AccountHistory` from unsupported BULK streams |
| 1.0.26 | 2022-11-15 | [19286](https://github.com/airbytehq/airbyte/pull/19286) | Bugfix: fallback to REST API if entity is not supported by BULK API |
| 1.0.25 | 2022-11-13 | [19294](https://github.com/airbytehq/airbyte/pull/19294) | Use the correct encoding for non UTF-8 objects and data |
Expand Down