fix(oauth): dont convert config values to string when building consent url #20932
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fixes OC issue https://github.com/airbytehq/oncall/issues/1250
If the configuration passed to generate the consent URL includes non-string values, they would be implicitly converted to strings when replacing masked values with secrets.
We noticed this happening specifically for Salesforce when re-authenticating the source, since it uses the
is_sandbox
field, which is a boolean. Issuing theget_consent_url
call for an already created connector would return a 422 status code with the following error:How
The
getOAuthFromDBIfNeeded
method was using a string map and callingJsons.deserializeToStringMap
, which basically converts all values to strings. In order to keep the original types, I reworked the implementation to use JsonNodes directly.