Destination Databricks: replicate into specified catalog using three level namespace #20954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
octavia-squidington-iv
added
area/connectors
IgSaf
reviewed
Feb 8, 2023
Comment on lines
190
to
195
| if (!useMetastore) { | ||
| queries.append(sqlOperations.copyTableQuery(database, String.format("%s.%s", catalogName, schemaName), tmpTableName, destTableName)); | ||
| } else { | ||
| queries.append(sqlOperations.copyTableQuery(database, schemaName, tmpTableName, destTableName)); | ||
| } | ||
| queries.append(sqlOperations.insertTableQuery(database, schemaName, tmpTableName, destTableName)); |
There was a problem hiding this comment.
I believe there should be insertTableQuery instead of copyTableQuery.
There was a problem hiding this comment.
@IgSaf you were right, I fixed the call and remove the unnecessary one in line 195
|
@mcfuhrt can you please rebase this PR with the latest changes so we can test it out? |
|
Closing due to lack of comment... and #24657 should also fix things |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
The Problem and solution can be found in the corresponding Issue: #20953
Recommended reading order
spec.jsonDatabricksDestinationConfig.javaDatabricksStreamCopier.javaDatabricksS3StreamCopier.javaDatabricksS3StreamCopierFactory.javaDatabricksAzureBlobStorageStreamCopier.javaDatabricksAzureBlobStorageStreamCopierFactory.javaDatabricksSqlOperations.java🚨 User Impact 🚨
Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.
Pre-merge Checklist
Expand the relevant checklist and delete the others.
Updating a connector
Community member or Airbyter
airbyte_secret./gradlew :airbyte-integrations:connectors:<name>:integrationTest.README.mdbootstrap.md. See description and examplesdocs/integrations/<source or destination>/<name>.mdincluding changelog. See changelog exampleAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>command is passing/publishcommand described hereTests
Unit
Put your unit tests output here.
Integration
Put your integration tests output here.
Acceptance
Put your acceptance tests output here.