Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better escape the select query for a case a schema name starts with a number #21051

Merged
merged 8 commits into from
Jan 12, 2023

Conversation

rodireich
Copy link
Contributor

What

Safer escaping for schema names starting with a number.

@rodireich rodireich requested a review from subodh1810 January 5, 2023 07:24
@rodireich rodireich marked this pull request as ready for review January 5, 2023 07:24
@rodireich rodireich requested a review from a team as a code owner January 5, 2023 07:24
Copy link
Contributor

@subodh1810 subodh1810 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved once we add a test case where we have a schema starting with a digit

@github-actions
Copy link
Contributor

github-actions bot commented Jan 5, 2023

Affected Connector Report

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to do the following as needed:

  • Run integration tests
  • Bump connector or module version
  • Add changelog
  • Publish the new version

✅ Sources (3)

Connector Version Changelog Publish
source-alloydb 1.0.34
source-alloydb-strict-encrypt 1.0.34 🔵
(ignored)
🔵
(ignored)
source-postgres-strict-encrypt 1.0.36 🔵
(ignored)
🔵
(ignored)
  • See "Actionable Items" below for how to resolve warnings and errors.

✅ Destinations (0)

Connector Version Changelog Publish
  • See "Actionable Items" below for how to resolve warnings and errors.

✅ Other Modules (0)

Actionable Items

(click to expand)

Category Status Actionable Item
Version
mismatch
The version of the connector is different from its normal variant. Please bump the version of the connector.

doc not found
The connector does not seem to have a documentation file. This can be normal (e.g. basic connector like source-jdbc is not published or documented). Please double-check to make sure that it is not a bug.
Changelog
doc not found
The connector does not seem to have a documentation file. This can be normal (e.g. basic connector like source-jdbc is not published or documented). Please double-check to make sure that it is not a bug.

changelog missing
There is no chnagelog for the current version of the connector. If you are the author of the current version, please add a changelog.
Publish
not in seed
The connector is not in the seed file (e.g. source_definitions.yaml), so its publication status cannot be checked. This can be normal (e.g. some connectors are cloud-specific, and only listed in the cloud seed file). Please double-check to make sure that it is not a bug.

diff seed version
The connector exists in the seed file, but the latest version is not listed there. This usually means that the latest version is not published. Please use the /publish command to publish the latest version.

@rodireich rodireich temporarily deployed to more-secrets January 5, 2023 07:48 — with GitHub Actions Inactive
@rodireich rodireich temporarily deployed to more-secrets January 5, 2023 07:49 — with GitHub Actions Inactive
@rodireich
Copy link
Contributor Author

rodireich commented Jan 5, 2023

/test connector=connectors/source-postgres

🕑 connectors/source-postgres https://github.com/airbytehq/airbyte/actions/runs/3844886081
✅ connectors/source-postgres https://github.com/airbytehq/airbyte/actions/runs/3844886081
Python tests coverage:

	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          12      4    67%   16-19
	 source_acceptance_test/config.py                       141      5    96%   87, 93, 239, 243-244
	 source_acceptance_test/conftest.py                     211     95    55%   36, 42-44, 49, 54, 77, 83, 89-91, 110, 115-117, 123-125, 131-132, 137-138, 143, 149, 158-167, 173-178, 193, 217, 248, 254, 262-267, 275-285, 293-306, 311-317, 324-335, 342-358
	 source_acceptance_test/plugin.py                        69     25    64%   22-23, 31, 36, 120-140, 144-148
	 source_acceptance_test/tests/test_core.py              402    115    71%   53, 58, 93-104, 109-116, 120-121, 125-126, 308, 346-363, 376-387, 391-396, 402, 435-440, 478-485, 528-530, 533, 598-606, 618-621, 626, 682-683, 689, 692, 728-738, 751-776
	 source_acceptance_test/tests/test_incremental.py       160     14    91%   56-63, 68-81, 244
	 source_acceptance_test/utils/asserts.py                 39      2    95%   62-63
	 source_acceptance_test/utils/common.py                  94     10    89%   16-17, 32-38, 72, 75
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/connector_runner.py       133     33    75%   24-27, 46-47, 50-54, 57-58, 73-75, 78-80, 83-85, 88-90, 93-95, 124-125, 159-161, 208
	 source_acceptance_test/utils/json_schema_helper.py     107     13    88%   30-31, 38, 41, 65-68, 96, 120, 192-194
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1609    339    79%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [2] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:94: The previous and actual specifications are identical.
SKIPPED [2] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:377: The previous and actual discovered catalogs are identical.
SKIPPED [2] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_incremental.py:22: `future_state` has a bypass reason, skipping.
================== 54 passed, 6 skipped in 715.49s (0:11:55) ===================

@rodireich rodireich temporarily deployed to more-secrets January 6, 2023 05:59 — with GitHub Actions Inactive
@rodireich rodireich temporarily deployed to more-secrets January 6, 2023 05:59 — with GitHub Actions Inactive
@rodireich rodireich enabled auto-merge (squash) January 6, 2023 06:41
@rodireich rodireich disabled auto-merge January 6, 2023 06:59
@rodireich rodireich temporarily deployed to more-secrets January 6, 2023 07:24 — with GitHub Actions Inactive
@rodireich rodireich temporarily deployed to more-secrets January 6, 2023 07:24 — with GitHub Actions Inactive
@rodireich rodireich temporarily deployed to more-secrets January 6, 2023 07:58 — with GitHub Actions Inactive
@rodireich rodireich temporarily deployed to more-secrets January 6, 2023 07:59 — with GitHub Actions Inactive
@rodireich rodireich temporarily deployed to more-secrets January 6, 2023 09:04 — with GitHub Actions Inactive
@rodireich rodireich temporarily deployed to more-secrets January 6, 2023 09:04 — with GitHub Actions Inactive
@rodireich rodireich temporarily deployed to more-secrets January 12, 2023 18:19 — with GitHub Actions Inactive
@rodireich rodireich temporarily deployed to more-secrets January 12, 2023 18:19 — with GitHub Actions Inactive
@rodireich rodireich temporarily deployed to more-secrets January 12, 2023 19:03 — with GitHub Actions Inactive
@rodireich rodireich temporarily deployed to more-secrets January 12, 2023 19:03 — with GitHub Actions Inactive
@rodireich rodireich temporarily deployed to more-secrets January 12, 2023 19:41 — with GitHub Actions Inactive
@rodireich rodireich temporarily deployed to more-secrets January 12, 2023 19:41 — with GitHub Actions Inactive
@rodireich rodireich merged commit b7af8ac into master Jan 12, 2023
@rodireich rodireich deleted the rodi-fix-null-cursor-value-query branch January 12, 2023 20:28
jbfbell pushed a commit that referenced this pull request Jan 13, 2023
… number (#21051)

* Better escape the select query for a case a schema name starts with a numebr.

* improve test

* fix unrelated build error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants