Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🪟 🎉 Add column selection UI to new stream table #21058

Merged
merged 24 commits into from
Jan 25, 2023
Merged
Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
cc625d2
add column selection UI to new stream table
josephkmh Jan 5, 2023
b79bb18
disable experiment by default
josephkmh Jan 5, 2023
a6c6b87
add option to toggle all selected fields
josephkmh Jan 5, 2023
94f331f
Merge branch 'master' into joey/column-selection-new-stream-table
josephkmh Jan 5, 2023
81a0330
fix header styling
josephkmh Jan 5, 2023
972be8f
Merge branch 'master' into joey/column-selection-new-stream-table
josephkmh Jan 5, 2023
84db0c0
fix missing dependencies
josephkmh Jan 5, 2023
625bb89
fix checkbox warnings
josephkmh Jan 5, 2023
9c6e31a
add ability to select/deselect all, ignoring pk and cursor
josephkmh Jan 5, 2023
e9d8a22
Merge branch 'master' into joey/column-selection-new-stream-table
josephkmh Jan 11, 2023
e6914ec
typo in merge
josephkmh Jan 11, 2023
59d0267
refactor method for single field toggle, add tests
josephkmh Jan 12, 2023
b123ed3
Merge branch 'master' into joey/column-selection-new-stream-table
josephkmh Jan 12, 2023
c0278a4
test that cursor & pk are selected when toggling all fields
josephkmh Jan 12, 2023
4b82714
support source defined pk & cursor
josephkmh Jan 12, 2023
25ebac7
Merge branch 'master' into joey/column-selection-new-stream-table
josephkmh Jan 12, 2023
706163d
disable field selection checkboxes in readonly mode
josephkmh Jan 16, 2023
d311cb9
omit selectedFields if field selection disabled
josephkmh Jan 16, 2023
05e56af
Merge branch 'master' into joey/column-selection-new-stream-table
josephkmh Jan 19, 2023
427a3b6
disable deselection of parent field when child is part of pk or is cu…
josephkmh Jan 19, 2023
cf5e863
Merge branch 'master' into joey/column-selection-new-stream-table
josephkmh Jan 23, 2023
16d0b57
Merge branch 'master' into joey/column-selection-new-stream-table
josephkmh Jan 24, 2023
22f08b4
fix disabling checkboxes in readonly mode
josephkmh Jan 24, 2023
b5769c8
missing dependency
josephkmh Jan 24, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
omit selectedFields if field selection disabled
josephkmh committed Jan 16, 2023
commit d311cb9b8064a38123a56fdc3aa7665d822102a8
Original file line number Diff line number Diff line change
@@ -32,6 +32,11 @@ export const CatalogTreeBody: React.FC<CatalogTreeBodyProps> = ({ streams, chang
if (streamNode) {
const newStreamNode = setIn(streamNode, "config", { ...streamNode.config, ...newConfig });

// config.selectedFields must be removed if fieldSelection is disabled
if (!newStreamNode.config.fieldSelectionEnabled) {
delete newStreamNode.config.selectedFields;
}

onStreamChanged(newStreamNode);
}
},