Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🪟 🔧 Update frontend typing of cloud api response #21086

Merged
merged 4 commits into from
Jan 10, 2023
Merged

🪟 🔧 Update frontend typing of cloud api response #21086

merged 4 commits into from
Jan 10, 2023

Conversation

josephkmh
Copy link
Contributor

@josephkmh josephkmh commented Jan 5, 2023 •
edited
Loading

What

Updates the type of an interface to match an upcoming cloud API change: https://github.com/airbytehq/airbyte-cloud/pull/3942#discussion_r1061790616

To be merged once https://github.com/airbytehq/airbyte-cloud/pull/3942 is merged

@josephkmh josephkmh requested a review from a team as a code owner January 5, 2023 22:49
@josephkmh josephkmh self-assigned this Jan 5, 2023
@josephkmh josephkmh requested review from pmossman and removed request for a team January 5, 2023 22:49
@octavia-squidington-iv octavia-squidington-iv added area/platform issues related to the platform area/frontend Related to the Airbyte webapp labels Jan 5, 2023
@krishnaglick
Copy link
Contributor

Is there any way to get this from generated types?

@josephkmh
Copy link
Contributor Author

Is there any way to get this from generated types?

No we unfortunately can't generate types from the cloud repo, if you look at this history of this file we manage these types manually.

@octavia-squidington-iv octavia-squidington-iv removed the area/platform issues related to the platform label Jan 9, 2023
timroes
timroes approved these changes Jan 10, 2023
View reviewed changes
Copy link
Collaborator

@timroes timroes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, have not tested locally

@josephkmh josephkmh enabled auto-merge (squash) January 10, 2023 13:43
@josephkmh josephkmh merged commit a8e1037 into master Jan 10, 2023
@josephkmh josephkmh deleted the joey/change-cloudworkspace-response-type branch January 10, 2023 13:56
@octavia-squidington-iii octavia-squidington-iii mentioned this pull request Jan 12, 2023
Merged
jbfbell pushed a commit that referenced this pull request Jan 13, 2023
@josephkmh @jbfbell
🪟 🔧 Update frontend typing of cloud api response (#21086)
c3d842f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timroes timroes timroes approved these changes

@pmossman pmossman Awaiting requested review from pmossman

Assignees

@josephkmh josephkmh

Labels
area/frontend Related to the Airbyte webapp
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@josephkmh @krishnaglick @timroes @octavia-squidington-iv