Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend connection list filtering #21094

Merged
merged 3 commits into from
Jan 9, 2023

Conversation

gosusnp
Copy link
Contributor

@gosusnp gosusnp commented Jan 6, 2023

What

Enable querying connections with a list of sources/destinations.

Closes #21024

How

  • Update DB layer to support list of sources and destinations
  • Update API definition

@gosusnp gosusnp requested a review from krishnaglick January 6, 2023 02:05
@gosusnp gosusnp requested a review from a team as a code owner January 6, 2023 02:05
@gosusnp gosusnp temporarily deployed to more-secrets January 6, 2023 02:05 — with GitHub Actions Inactive
@octavia-squidington-iv octavia-squidington-iv added area/api Related to the api area/documentation Improvements or additions to documentation area/platform issues related to the platform labels Jan 6, 2023
@gosusnp gosusnp temporarily deployed to more-secrets January 6, 2023 02:06 — with GitHub Actions Inactive
Copy link
Contributor

@krishnaglick krishnaglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, LGTM! Did an implementation here
The existing PR for this work will generate conflicts but that'll be easy for me to take care of 👍

@gosusnp gosusnp temporarily deployed to more-secrets January 9, 2023 17:51 — with GitHub Actions Inactive
@gosusnp gosusnp temporarily deployed to more-secrets January 9, 2023 17:51 — with GitHub Actions Inactive
Copy link
Contributor

@jdpgrailsdev jdpgrailsdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@gosusnp gosusnp temporarily deployed to more-secrets January 9, 2023 21:20 — with GitHub Actions Inactive
@gosusnp gosusnp temporarily deployed to more-secrets January 9, 2023 21:20 — with GitHub Actions Inactive
@gosusnp gosusnp merged commit 0d9a3ea into master Jan 9, 2023
@gosusnp gosusnp deleted the gosusnp/21024-extend-connection-list-filtering branch January 9, 2023 21:42
jbfbell pushed a commit that referenced this pull request Jan 13, 2023
* Update listWorkspaceStandardSyncs to support lists of sources/destinations

* Update API spec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/api Related to the api area/documentation Improvements or additions to documentation area/platform issues related to the platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

web_backend/v1/connections/list should allow filtering by multiple source or destination id's
4 participants