Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ISSUE #19981] testing version bump #21106

Merged
merged 19 commits into from
Jan 11, 2023
Merged

[ISSUE #19981] testing version bump #21106

merged 19 commits into from
Jan 11, 2023

Conversation

maxi297
Copy link
Contributor

@maxi297 maxi297 commented Jan 6, 2023 •
edited
Loading

What

This PR addresses #19981

Since we currently release in branches, it can lead to weird race conditions. This PR will:

  • Allow the release process to occur in master
  • Change the trigger from a slash command to a GitHub workflow

How

See #19981 (comment)

@maxi297 maxi297 force-pushed the issue-19981_avoid-race-condition-on-airbyte-cdk-release branch from cdcea27 to b768e06 Compare January 6, 2023 13:50
@maxi297 maxi297 temporarily deployed to more-secrets January 6, 2023 13:52 — with GitHub Actions Inactive
@maxi297 maxi297 temporarily deployed to more-secrets January 6, 2023 13:52 — with GitHub Actions Inactive
@maxi297 maxi297 temporarily deployed to more-secrets January 6, 2023 14:24 — with GitHub Actions Inactive
@maxi297 maxi297 temporarily deployed to more-secrets January 6, 2023 14:24 — with GitHub Actions Inactive
@maxi297 maxi297 force-pushed the issue-19981_avoid-race-condition-on-airbyte-cdk-release branch from f8b3fae to c008009 Compare January 6, 2023 14:27
@maxi297 maxi297 force-pushed the issue-19981_avoid-race-condition-on-airbyte-cdk-release branch from c008009 to 4ee20b0 Compare January 6, 2023 14:29
@maxi297 maxi297 temporarily deployed to more-secrets January 6, 2023 14:31 — with GitHub Actions Inactive
@maxi297 maxi297 temporarily deployed to more-secrets January 6, 2023 14:31 — with GitHub Actions Inactive
@maxi297 maxi297 temporarily deployed to more-secrets January 6, 2023 14:49 — with GitHub Actions Inactive
@maxi297 maxi297 temporarily deployed to more-secrets January 6, 2023 14:49 — with GitHub Actions Inactive
@maxi297 maxi297 temporarily deployed to more-secrets January 6, 2023 14:56 — with GitHub Actions Inactive
@maxi297 maxi297 temporarily deployed to more-secrets January 6, 2023 14:58 — with GitHub Actions Inactive
@maxi297 maxi297 temporarily deployed to more-secrets January 6, 2023 14:59 — with GitHub Actions Inactive
@maxi297 maxi297 force-pushed the issue-19981_avoid-race-condition-on-airbyte-cdk-release branch from 30d0310 to a0c697e Compare January 6, 2023 15:08
@maxi297 maxi297 force-pushed the issue-19981_avoid-race-condition-on-airbyte-cdk-release branch 2 times, most recently from 37e334e to 6e723c4 Compare January 6, 2023 18:11
@maxi297 maxi297 temporarily deployed to more-secrets January 6, 2023 18:13 — with GitHub Actions Inactive
@maxi297 maxi297 temporarily deployed to more-secrets January 6, 2023 18:13 — with GitHub Actions Inactive
@maxi297 maxi297 force-pushed the issue-19981_avoid-race-condition-on-airbyte-cdk-release branch 4 times, most recently from acfba2b to 70ea05f Compare January 6, 2023 18:28
@maxi297 maxi297 temporarily deployed to more-secrets January 9, 2023 15:05 — with GitHub Actions Inactive
@maxi297 maxi297 temporarily deployed to more-secrets January 9, 2023 15:06 — with GitHub Actions Inactive
@maxi297 maxi297 temporarily deployed to more-secrets January 9, 2023 15:42 — with GitHub Actions Inactive
@maxi297 maxi297 temporarily deployed to more-secrets January 9, 2023 15:43 — with GitHub Actions Inactive
sherifnada
sherifnada approved these changes Jan 10, 2023
View reviewed changes
Copy link
Contributor

@sherifnada sherifnada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming suggested changes + code cleanup

@maxi297 maxi297 temporarily deployed to more-secrets January 10, 2023 15:30 — with GitHub Actions Inactive
@maxi297 maxi297 temporarily deployed to more-secrets January 10, 2023 15:30 — with GitHub Actions Inactive
@maxi297 maxi297 temporarily deployed to more-secrets January 10, 2023 15:35 — with GitHub Actions Inactive
@maxi297 maxi297 temporarily deployed to more-secrets January 10, 2023 16:41 — with GitHub Actions Inactive
@maxi297 maxi297 temporarily deployed to more-secrets January 10, 2023 16:43 — with GitHub Actions Inactive
@maxi297 maxi297 temporarily deployed to more-secrets January 10, 2023 18:25 — with GitHub Actions Inactive
@maxi297 maxi297 temporarily deployed to more-secrets January 10, 2023 18:26 — with GitHub Actions Inactive
@maxi297 maxi297 temporarily deployed to more-secrets January 10, 2023 19:42 — with GitHub Actions Inactive
@maxi297 maxi297 temporarily deployed to more-secrets January 10, 2023 19:42 — with GitHub Actions Inactive
@maxi297 maxi297 temporarily deployed to more-secrets January 10, 2023 20:37 — with GitHub Actions Inactive
@maxi297 maxi297 temporarily deployed to more-secrets January 10, 2023 20:37 — with GitHub Actions Inactive
@maxi297 maxi297 merged commit f69a128 into master Jan 11, 2023
@maxi297 maxi297 deleted the issue-19981_avoid-race-condition-on-airbyte-cdk-release branch January 11, 2023 13:28
@octavia-squidington-iii octavia-squidington-iii mentioned this pull request Jan 12, 2023
Merged
jbfbell pushed a commit that referenced this pull request Jan 13, 2023
@maxi297 @jbfbell
[ISSUE #19981] testing version bump (#21106)
9918386 
* [ISSUE #19981] testing version bump

* [ISSUE #19981] debugging part-to-bump

* [ISSUE #19981] further debugging on part-to-bump

* [ISSUE #19981] further debugging on part-to-bump yet again

* [ISSUE #19981] further debugging on part-to-bump yet again and again

* [ISSUE #19981] improving on first successful attempt

* [ISSUE #19981] adding changelog and concurrency

* [ISSUE #19981] update version in .bumpversion.cfg

* [ISSUE #19981] testing Slack notification with working channel

* [ISSUE #19981] documentation and clean up before PR

* [ISSUE #19981] make changelog-message optional

* [ISSUE #19981] align version with new release

* [ISSUE #19981] code review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@girarda girarda girarda left review comments

@brianjlai brianjlai brianjlai approved these changes

@sherifnada sherifnada sherifnada approved these changes

Assignees
No one assigned
Labels
area/documentation Improvements or additions to documentation CDK Connector Development Kit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@maxi297 @brianjlai @girarda @sherifnada @octavia-squidington-iv