Connector builder server: Fix unit tests #21107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flash1293
temporarily deployed
to
more-secrets
GitHub Actions
Inactive
flash1293
temporarily deployed
to
more-secrets
GitHub Actions
Inactive
flash1293
requested review from
brianjlai and
girarda
and removed request for
brianjlai
girarda
approved these changes
Jan 10, 2023
jbfbell
pushed a commit
that referenced
this pull request
Jan 13, 2023
* fix stuff * add inferred schema to API * fix yaml changes * fix yaml formatting * add whitespace back * fix tests * reformat * add unit tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The unit tests weren't updated to work with the most recent CDK version which requires the "type" properties to be specified on all levels.
This PR makes sure the tests run with the latest CDK version 0.17.0 and also adds a little test for the newly introduced inferred_schema property.
Ideally these tests would run as part of the gradle build - I will handle that on a separate PR.