🪟🐛 Connector builder UI: Fix datetime stream slicer #21161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmossman
approved these changes
Jan 10, 2023
airbyte-webapp/src/components/connectorBuilder/Builder/StreamSlicerSection.tsx
Outdated
Show resolved
Hide resolved
airbyte-webapp/src/components/connectorBuilder/Builder/StreamSlicerSection.tsx
Outdated
Show resolved
Hide resolved
…licerSection.tsx Co-authored-by: Lake Mossman <lake@airbyte.io>
…licerSection.tsx Co-authored-by: Lake Mossman <lake@airbyte.io>
|
You can see how it failed the build here (before the fix with the unit tests was merged in): https://github.com/airbytehq/airbyte/actions/runs/3882948666/jobs/6623703102 |
jbfbell
pushed a commit
that referenced
this pull request
Jan 13, 2023
* fix datetime stream slicer * Update airbyte-webapp/src/components/connectorBuilder/Builder/StreamSlicerSection.tsx Co-authored-by: Lake Mossman <lake@airbyte.io> * Update airbyte-webapp/src/components/connectorBuilder/Builder/StreamSlicerSection.tsx Co-authored-by: Lake Mossman <lake@airbyte.io> Co-authored-by: Lake Mossman <lake@airbyte.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 0.16 upgrade of the CDK changed some fields in the datetime stream slicer. This PR adjusts the UI accordingly:
cursor_granularityDidn't add a better pattern for these inputs because the ISO standard for durations is a little more complex and I think a wrong pattern is worse than none, especially as the server is doing validation as well.
We can add one back in a later step.