Source Google Analytics Data API: slicer updated, unit tests added #21169

grubberr · 2023-01-09T17:44:26Z

Signed-off-by: Sergey Chvalyuk grubberr@gmail.com

What

re-implement slicing
add unit tests to cover 90% of codebase
google-analytics-v4.md updated

Pre-merge Checklist

Expand the relevant checklist and delete the others.

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

grubberr · 2023-01-09T17:45:00Z

/test connector=connectors/source-google-analytics-data-api

🕑 connectors/source-google-analytics-data-api https://github.com/airbytehq/airbyte/actions/runs/3876321617
✅ connectors/source-google-analytics-data-api https://github.com/airbytehq/airbyte/actions/runs/3876321617
Python tests coverage:

Name                                                Stmts   Miss  Cover
-----------------------------------------------------------------------
source_google_analytics_data_api/__init__.py            2      0   100%
source_google_analytics_data_api/authenticator.py      44      3    93%
source_google_analytics_data_api/source.py            204     41    80%
source_google_analytics_data_api/utils.py              14      5    64%
-----------------------------------------------------------------------
TOTAL                                                 264     49    81%
	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          12      4    67%   16-19
	 source_acceptance_test/config.py                       141      5    96%   87, 93, 239, 243-244
	 source_acceptance_test/conftest.py                     211     95    55%   36, 42-44, 49, 54, 77, 83, 89-91, 110, 115-117, 123-125, 131-132, 137-138, 143, 149, 158-167, 173-178, 193, 217, 248, 254, 262-267, 275-285, 293-306, 311-317, 324-335, 342-358
	 source_acceptance_test/plugin.py                        69     25    64%   22-23, 31, 36, 120-140, 144-148
	 source_acceptance_test/tests/test_core.py              402    115    71%   53, 58, 93-104, 109-116, 120-121, 125-126, 308, 346-363, 376-387, 391-396, 402, 435-440, 478-485, 528-530, 533, 598-606, 618-621, 626, 682-683, 689, 692, 728-738, 751-776
	 source_acceptance_test/tests/test_incremental.py       160     14    91%   56-63, 68-81, 244
	 source_acceptance_test/utils/asserts.py                 39      2    95%   62-63
	 source_acceptance_test/utils/common.py                  94     10    89%   16-17, 32-38, 72, 75
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/connector_runner.py       133     33    75%   24-27, 46-47, 50-54, 57-58, 73-75, 78-80, 83-85, 88-90, 93-95, 124-125, 159-161, 208
	 source_acceptance_test/utils/json_schema_helper.py     107     13    88%   30-31, 38, 41, 65-68, 96, 120, 192-194
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1609    339    79%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:94: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:377: The previous and actual discovered catalogs are identical.
================== 29 passed, 2 skipped in 361.49s (0:06:01) ===================

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

grubberr · 2023-01-09T18:56:40Z

/test connector=connectors/source-google-analytics-data-api

🕑 connectors/source-google-analytics-data-api https://github.com/airbytehq/airbyte/actions/runs/3876829464
❌ connectors/source-google-analytics-data-api https://github.com/airbytehq/airbyte/actions/runs/3876829464
🐛 https://gradle.com/s/zrwle3thngzx2

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestConnection::test_check[inputs0] - AssertionError: as...
FAILED test_core.py::TestDiscovery::test_discover[inputs0] - docker.errors.Co...
ERROR test_core.py::TestDiscovery::test_defined_cursors_exist_in_schema[inputs0]
ERROR test_core.py::TestDiscovery::test_defined_refs_exist_in_schema[inputs0]
ERROR test_core.py::TestDiscovery::test_defined_keyword_exist_in_schema[inputs0-allOf]
ERROR test_core.py::TestDiscovery::test_defined_keyword_exist_in_schema[inputs0-not]
ERROR test_core.py::TestDiscovery::test_primary_keys_exist_in_schema[inputs0]
ERROR test_core.py::TestDiscovery::test_streams_has_sync_modes[inputs0] - doc...
ERROR test_core.py::TestDiscovery::test_additional_properties_is_true[inputs0]
ERROR test_core.py::TestDiscovery::test_backward_compatibility[inputs0] - doc...
ERROR test_core.py::TestBasicRead::test_read[inputs0] - docker.errors.Contain...
ERROR test_full_refresh.py::TestFullRefresh::test_sequential_reads[inputs0]
ERROR test_incremental.py::TestIncremental::test_two_sequential_reads[inputs0]
ERROR test_incremental.py::TestIncremental::test_read_sequential_slices[inputs0]
ERROR test_incremental.py::TestIncremental::test_state_with_abnormally_large_values[inputs0]
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:94: The previous and actual specifications are identical.
============= 2 failed, 15 passed, 1 skipped, 13 errors in 32.33s ==============

grubberr · 2023-01-10T06:37:42Z

/test connector=connectors/source-google-analytics-data-api

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

grubberr · 2023-01-10T07:30:42Z

/test connector=connectors/source-google-analytics-data-api

🕑 connectors/source-google-analytics-data-api https://github.com/airbytehq/airbyte/actions/runs/3881166745
❌ connectors/source-google-analytics-data-api https://github.com/airbytehq/airbyte/actions/runs/3881166745
🐛 https://gradle.com/s/t7gx35jubtlcq

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestConnection::test_check[inputs0] - AssertionError: as...
FAILED test_core.py::TestDiscovery::test_discover[inputs0] - docker.errors.Co...
ERROR test_core.py::TestDiscovery::test_defined_cursors_exist_in_schema[inputs0]
ERROR test_core.py::TestDiscovery::test_defined_refs_exist_in_schema[inputs0]
ERROR test_core.py::TestDiscovery::test_defined_keyword_exist_in_schema[inputs0-allOf]
ERROR test_core.py::TestDiscovery::test_defined_keyword_exist_in_schema[inputs0-not]
ERROR test_core.py::TestDiscovery::test_primary_keys_exist_in_schema[inputs0]
ERROR test_core.py::TestDiscovery::test_streams_has_sync_modes[inputs0] - doc...
ERROR test_core.py::TestDiscovery::test_additional_properties_is_true[inputs0]
ERROR test_core.py::TestDiscovery::test_backward_compatibility[inputs0] - doc...
ERROR test_core.py::TestBasicRead::test_read[inputs0] - docker.errors.Contain...
ERROR test_full_refresh.py::TestFullRefresh::test_sequential_reads[inputs0]
ERROR test_incremental.py::TestIncremental::test_two_sequential_reads[inputs0]
ERROR test_incremental.py::TestIncremental::test_read_sequential_slices[inputs0]
ERROR test_incremental.py::TestIncremental::test_state_with_abnormally_large_values[inputs0]
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:94: The previous and actual specifications are identical.
============= 2 failed, 15 passed, 1 skipped, 13 errors in 32.82s ==============

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

grubberr · 2023-01-10T08:49:20Z

/test connector=connectors/source-google-analytics-data-api

🕑 connectors/source-google-analytics-data-api https://github.com/airbytehq/airbyte/actions/runs/3881673820
❌ connectors/source-google-analytics-data-api https://github.com/airbytehq/airbyte/actions/runs/3881673820
🐛 https://gradle.com/s/rbbu2q27yw2jw

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestConnection::test_check[inputs0] - AssertionError: as...
FAILED test_core.py::TestDiscovery::test_discover[inputs0] - docker.errors.Co...
ERROR test_core.py::TestDiscovery::test_defined_cursors_exist_in_schema[inputs0]
ERROR test_core.py::TestDiscovery::test_defined_refs_exist_in_schema[inputs0]
ERROR test_core.py::TestDiscovery::test_defined_keyword_exist_in_schema[inputs0-allOf]
ERROR test_core.py::TestDiscovery::test_defined_keyword_exist_in_schema[inputs0-not]
ERROR test_core.py::TestDiscovery::test_primary_keys_exist_in_schema[inputs0]
ERROR test_core.py::TestDiscovery::test_streams_has_sync_modes[inputs0] - doc...
ERROR test_core.py::TestDiscovery::test_additional_properties_is_true[inputs0]
ERROR test_core.py::TestDiscovery::test_backward_compatibility[inputs0] - doc...
ERROR test_core.py::TestBasicRead::test_read[inputs0] - docker.errors.Contain...
ERROR test_full_refresh.py::TestFullRefresh::test_sequential_reads[inputs0]
ERROR test_incremental.py::TestIncremental::test_two_sequential_reads[inputs0]
ERROR test_incremental.py::TestIncremental::test_read_sequential_slices[inputs0]
ERROR test_incremental.py::TestIncremental::test_state_with_abnormally_large_values[inputs0]
=================== 2 failed, 16 passed, 13 errors in 36.75s ===================

…a-api

grubberr · 2023-01-10T11:05:33Z

/test connector=connectors/source-google-analytics-data-api

🕑 connectors/source-google-analytics-data-api https://github.com/airbytehq/airbyte/actions/runs/3882834890
❌ connectors/source-google-analytics-data-api https://github.com/airbytehq/airbyte/actions/runs/3882834890
🐛 https://gradle.com/s/qjhbr7ywvc6ma

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestConnection::test_check[inputs0] - AssertionError: as...
FAILED test_core.py::TestDiscovery::test_discover[inputs0] - docker.errors.Co...
ERROR test_core.py::TestDiscovery::test_defined_cursors_exist_in_schema[inputs0]
ERROR test_core.py::TestDiscovery::test_defined_refs_exist_in_schema[inputs0]
ERROR test_core.py::TestDiscovery::test_defined_keyword_exist_in_schema[inputs0-allOf]
ERROR test_core.py::TestDiscovery::test_defined_keyword_exist_in_schema[inputs0-not]
ERROR test_core.py::TestDiscovery::test_primary_keys_exist_in_schema[inputs0]
ERROR test_core.py::TestDiscovery::test_streams_has_sync_modes[inputs0] - doc...
ERROR test_core.py::TestDiscovery::test_additional_properties_is_true[inputs0]
ERROR test_core.py::TestDiscovery::test_backward_compatibility[inputs0] - doc...
ERROR test_core.py::TestBasicRead::test_read[inputs0] - docker.errors.Contain...
ERROR test_full_refresh.py::TestFullRefresh::test_sequential_reads[inputs0]
ERROR test_incremental.py::TestIncremental::test_two_sequential_reads[inputs0]
ERROR test_incremental.py::TestIncremental::test_read_sequential_slices[inputs0]
ERROR test_incremental.py::TestIncremental::test_state_with_abnormally_large_values[inputs0]
=================== 2 failed, 16 passed, 13 errors in 36.90s ===================

grubberr · 2023-01-10T11:18:34Z

/test connector=connectors/source-google-analytics-data-api

🕑 connectors/source-google-analytics-data-api https://github.com/airbytehq/airbyte/actions/runs/3882821609
❌ connectors/source-google-analytics-data-api https://github.com/airbytehq/airbyte/actions/runs/3882821609
🐛 https://gradle.com/s/p4y3hxfrmljec

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestConnection::test_check[inputs0] - AssertionError: as...
FAILED test_core.py::TestDiscovery::test_discover[inputs0] - docker.errors.Co...
ERROR test_core.py::TestDiscovery::test_defined_cursors_exist_in_schema[inputs0]
ERROR test_core.py::TestDiscovery::test_defined_refs_exist_in_schema[inputs0]
ERROR test_core.py::TestDiscovery::test_defined_keyword_exist_in_schema[inputs0-allOf]
ERROR test_core.py::TestDiscovery::test_defined_keyword_exist_in_schema[inputs0-not]
ERROR test_core.py::TestDiscovery::test_primary_keys_exist_in_schema[inputs0]
ERROR test_core.py::TestDiscovery::test_streams_has_sync_modes[inputs0] - doc...
ERROR test_core.py::TestDiscovery::test_additional_properties_is_true[inputs0]
ERROR test_core.py::TestDiscovery::test_backward_compatibility[inputs0] - doc...
ERROR test_core.py::TestBasicRead::test_read[inputs0] - docker.errors.Contain...
ERROR test_full_refresh.py::TestFullRefresh::test_sequential_reads[inputs0]
ERROR test_incremental.py::TestIncremental::test_two_sequential_reads[inputs0]
ERROR test_incremental.py::TestIncremental::test_read_sequential_slices[inputs0]
ERROR test_incremental.py::TestIncremental::test_state_with_abnormally_large_values[inputs0]
=================== 2 failed, 16 passed, 13 errors in 47.02s ===================

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

grubberr · 2023-01-10T16:22:26Z

/test connector=connectors/source-google-analytics-data-api

🕑 connectors/source-google-analytics-data-api https://github.com/airbytehq/airbyte/actions/runs/3885218344
❌ connectors/source-google-analytics-data-api https://github.com/airbytehq/airbyte/actions/runs/3885218344
🐛 https://gradle.com/s/s42cxgaesxxeq

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestDiscovery::test_discover[inputs0] - docker.errors.Co...
FAILED test_core.py::TestBasicRead::test_read[inputs0] - docker.errors.Contai...
FAILED test_incremental.py::TestIncremental::test_two_sequential_reads[inputs0]
FAILED test_incremental.py::TestIncremental::test_read_sequential_slices[inputs0]
ERROR test_core.py::TestDiscovery::test_backward_compatibility[inputs0] - doc...
==================== 4 failed, 26 passed, 1 error in 44.72s ====================

grubberr · 2023-01-10T23:24:36Z

/test connector=connectors/source-google-analytics-data-api

🕑 connectors/source-google-analytics-data-api https://github.com/airbytehq/airbyte/actions/runs/3888139161
✅ connectors/source-google-analytics-data-api https://github.com/airbytehq/airbyte/actions/runs/3888139161
Python tests coverage:

Name                                                Stmts   Miss  Cover
-----------------------------------------------------------------------
source_google_analytics_data_api/__init__.py            2      0   100%
source_google_analytics_data_api/authenticator.py      44      3    93%
source_google_analytics_data_api/source.py            200     29    86%
source_google_analytics_data_api/utils.py              14      4    71%
-----------------------------------------------------------------------
TOTAL                                                 260     36    86%
	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          12      4    67%   16-19
	 source_acceptance_test/config.py                       141      5    96%   87, 93, 239, 243-244
	 source_acceptance_test/conftest.py                     211     95    55%   36, 42-44, 49, 54, 77, 83, 89-91, 110, 115-117, 123-125, 131-132, 137-138, 143, 149, 158-167, 173-178, 193, 217, 248, 254, 262-267, 275-285, 293-306, 311-317, 324-335, 342-358
	 source_acceptance_test/plugin.py                        69     25    64%   22-23, 31, 36, 120-140, 144-148
	 source_acceptance_test/tests/test_core.py              402    115    71%   53, 58, 93-104, 109-116, 120-121, 125-126, 308, 346-363, 376-387, 391-396, 402, 435-440, 478-485, 528-530, 533, 598-606, 618-621, 626, 682-683, 689, 692, 728-738, 751-776
	 source_acceptance_test/tests/test_incremental.py       160     14    91%   56-63, 68-81, 244
	 source_acceptance_test/utils/asserts.py                 39      2    95%   62-63
	 source_acceptance_test/utils/common.py                  94     10    89%   16-17, 32-38, 72, 75
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/connector_runner.py       133     33    75%   24-27, 46-47, 50-54, 57-58, 73-75, 78-80, 83-85, 88-90, 93-95, 124-125, 159-161, 208
	 source_acceptance_test/utils/json_schema_helper.py     107     13    88%   30-31, 38, 41, 65-68, 96, 120, 192-194
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1609    339    79%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:377: The previous and actual discovered catalogs are identical.
================== 30 passed, 1 skipped in 346.21s (0:05:46) ===================

…a-api

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

grubberr · 2023-01-11T07:51:46Z

/test connector=connectors/source-google-analytics-data-api

🕑 connectors/source-google-analytics-data-api https://github.com/airbytehq/airbyte/actions/runs/3890748772
❌ connectors/source-google-analytics-data-api https://github.com/airbytehq/airbyte/actions/runs/3890748772
🐛 https://gradle.com/s/ov2jw4wysdyx4

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestConnection::test_check[inputs0] - AssertionError: as...
FAILED test_core.py::TestDiscovery::test_discover[inputs0] - docker.errors.Co...
ERROR test_core.py::TestDiscovery::test_defined_cursors_exist_in_schema[inputs0]
ERROR test_core.py::TestDiscovery::test_defined_refs_exist_in_schema[inputs0]
ERROR test_core.py::TestDiscovery::test_defined_keyword_exist_in_schema[inputs0-allOf]
ERROR test_core.py::TestDiscovery::test_defined_keyword_exist_in_schema[inputs0-not]
ERROR test_core.py::TestDiscovery::test_primary_keys_exist_in_schema[inputs0]
ERROR test_core.py::TestDiscovery::test_streams_has_sync_modes[inputs0] - doc...
ERROR test_core.py::TestDiscovery::test_additional_properties_is_true[inputs0]
ERROR test_core.py::TestDiscovery::test_backward_compatibility[inputs0] - doc...
ERROR test_core.py::TestBasicRead::test_read[inputs0] - docker.errors.Contain...
ERROR test_full_refresh.py::TestFullRefresh::test_sequential_reads[inputs0]
ERROR test_incremental.py::TestIncremental::test_two_sequential_reads[inputs0]
ERROR test_incremental.py::TestIncremental::test_read_sequential_slices[inputs0]
ERROR test_incremental.py::TestIncremental::test_state_with_abnormally_large_values[inputs0]
=================== 2 failed, 16 passed, 13 errors in 36.69s ===================

grubberr · 2023-01-11T10:50:29Z

/test connector=connectors/source-google-analytics-data-api

grubberr · 2023-01-11T11:14:40Z

/test connector=connectors/source-google-analytics-data-api

🕑 connectors/source-google-analytics-data-api https://github.com/airbytehq/airbyte/actions/runs/3892257246
❌ connectors/source-google-analytics-data-api https://github.com/airbytehq/airbyte/actions/runs/3892257246
🐛 https://gradle.com/s/fdqorjlvdss5g

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestConnection::test_check[inputs0] - AssertionError: as...
FAILED test_core.py::TestDiscovery::test_discover[inputs0] - docker.errors.Co...
ERROR test_core.py::TestDiscovery::test_defined_cursors_exist_in_schema[inputs0]
ERROR test_core.py::TestDiscovery::test_defined_refs_exist_in_schema[inputs0]
ERROR test_core.py::TestDiscovery::test_defined_keyword_exist_in_schema[inputs0-allOf]
ERROR test_core.py::TestDiscovery::test_defined_keyword_exist_in_schema[inputs0-not]
ERROR test_core.py::TestDiscovery::test_primary_keys_exist_in_schema[inputs0]
ERROR test_core.py::TestDiscovery::test_streams_has_sync_modes[inputs0] - doc...
ERROR test_core.py::TestDiscovery::test_additional_properties_is_true[inputs0]
ERROR test_core.py::TestDiscovery::test_backward_compatibility[inputs0] - doc...
ERROR test_core.py::TestBasicRead::test_read[inputs0] - docker.errors.Contain...
ERROR test_full_refresh.py::TestFullRefresh::test_sequential_reads[inputs0]
ERROR test_incremental.py::TestIncremental::test_two_sequential_reads[inputs0]
ERROR test_incremental.py::TestIncremental::test_read_sequential_slices[inputs0]
ERROR test_incremental.py::TestIncremental::test_state_with_abnormally_large_values[inputs0]
=================== 2 failed, 16 passed, 13 errors in 37.22s ===================

grubberr · 2023-01-11T11:56:45Z

/test connector=connectors/source-google-analytics-data-api

🕑 connectors/source-google-analytics-data-api https://github.com/airbytehq/airbyte/actions/runs/3892547314
✅ connectors/source-google-analytics-data-api https://github.com/airbytehq/airbyte/actions/runs/3892547314
Python tests coverage:

Name                                                Stmts   Miss  Cover
-----------------------------------------------------------------------
source_google_analytics_data_api/utils.py              14      0   100%
source_google_analytics_data_api/__init__.py            2      0   100%
source_google_analytics_data_api/authenticator.py      44      3    93%
source_google_analytics_data_api/source.py            200     19    90%
-----------------------------------------------------------------------
TOTAL                                                 260     22    92%
	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          12      4    67%   16-19
	 source_acceptance_test/config.py                       141      5    96%   87, 93, 239, 243-244
	 source_acceptance_test/conftest.py                     211     95    55%   36, 42-44, 49, 54, 77, 83, 89-91, 110, 115-117, 123-125, 131-132, 137-138, 143, 149, 158-167, 173-178, 193, 217, 248, 254, 262-267, 275-285, 293-306, 311-317, 324-335, 342-358
	 source_acceptance_test/plugin.py                        69     25    64%   22-23, 31, 36, 120-140, 144-148
	 source_acceptance_test/tests/test_core.py              402    115    71%   53, 58, 93-104, 109-116, 120-121, 125-126, 308, 346-363, 376-387, 391-396, 402, 435-440, 478-485, 528-530, 533, 598-606, 618-621, 626, 682-683, 689, 692, 728-738, 751-776
	 source_acceptance_test/tests/test_incremental.py       160     14    91%   56-63, 68-81, 244
	 source_acceptance_test/utils/asserts.py                 39      2    95%   62-63
	 source_acceptance_test/utils/common.py                  94     10    89%   16-17, 32-38, 72, 75
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/connector_runner.py       133     33    75%   24-27, 46-47, 50-54, 57-58, 73-75, 78-80, 83-85, 88-90, 93-95, 124-125, 159-161, 208
	 source_acceptance_test/utils/json_schema_helper.py     107     13    88%   30-31, 38, 41, 65-68, 96, 120, 192-194
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1609    339    79%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:377: The previous and actual discovered catalogs are identical.
================== 30 passed, 1 skipped in 338.01s (0:05:38) ===================

…a-api

grubberr · 2023-01-11T12:21:42Z

/publish connector=connectors/source-google-analytics-data-api

🕑 Publishing the following connectors:
connectors/source-google-analytics-data-api
https://github.com/airbytehq/airbyte/actions/runs/3892740572

Connector	Did it publish?	Were definitions generated?
connectors/source-google-analytics-data-api	❌	❌

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

grubberr · 2023-01-11T12:52:31Z

/publish connector=connectors/source-google-analytics-data-api

🕑 Publishing the following connectors:
connectors/source-google-analytics-data-api
https://github.com/airbytehq/airbyte/actions/runs/3892973609

Connector	Did it publish?	Were definitions generated?
connectors/source-google-analytics-data-api	❌	❌

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

grubberr · 2023-01-11T14:36:15Z

/publish connector=connectors/source-google-analytics-data-api

🕑 Publishing the following connectors:
connectors/source-google-analytics-data-api
https://github.com/airbytehq/airbyte/actions/runs/3893807775

Connector	Did it publish?	Were definitions generated?
connectors/source-google-analytics-data-api	✅	✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

…21169) Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

test_token_rotation added

671410d

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

octavia-squidington-iv added area/connectors Connector related issues connectors/source/google-analytics-data-api labels Jan 9, 2023

grubberr self-assigned this Jan 9, 2023

grubberr linked an issue Jan 9, 2023 that may be closed by this pull request

Unit tests for Google Analytics Data API connector #20818

Closed

test_stream_slices added

0e0df29

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

stream_slices re-implemented

af21313

grubberr changed the title ~~Source Google Analytics Data API: unit tests added~~ Source Google Analytics Data API: slicer updated, unit tests added Jan 10, 2023

bump 0.1.1

d573083

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

octavia-squidington-iv added the area/documentation Improvements or additions to documentation label Jan 10, 2023

grubberr added 2 commits January 10, 2023 07:59

improve spec.json

c17df9d

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

setup.py updated

aeac6e9

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

Merge branch 'master' into grubberr/20818-source-google-analytics-dat…

dd03a3d

…a-api

grubberr added 5 commits January 10, 2023 11:43

first improvement

12951b4

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

change "Supported sync modes"

9f59b80

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

continue to update

bfbc6e2

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

google-analytics-v4.md updated

d37d8b6

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

alpha -> beta

a7b8fa6

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

grubberr temporarily deployed to more-secrets January 10, 2023 12:34 — with GitHub Actions Inactive

fix custom-reports url

b34b44e

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

grubberr temporarily deployed to more-secrets January 10, 2023 13:02 — with GitHub Actions Inactive

grubberr requested a review from lazebnyi January 10, 2023 13:41

lazebnyi approved these changes Jan 10, 2023

View reviewed changes

grubberr added 2 commits January 10, 2023 23:48

Merge branch 'master' into grubberr/20818-source-google-analytics-dat…

bec477c

…a-api

test_read_incremental added

cba0f5c

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

grubberr temporarily deployed to more-secrets January 11, 2023 07:53 — with GitHub Actions Inactive

Merge branch 'master' into grubberr/20818-source-google-analytics-dat…

d059d2c

…a-api

grubberr temporarily deployed to more-secrets January 11, 2023 12:18 — with GitHub Actions Inactive

grubberr temporarily deployed to more-secrets January 11, 2023 12:19 — with GitHub Actions Inactive

auto-bump connector version

706be68

octavia-squidington-iii temporarily deployed to more-secrets January 11, 2023 15:00 — with GitHub Actions Inactive

grubberr merged commit 59ff2a2 into master Jan 11, 2023

grubberr deleted the grubberr/20818-source-google-analytics-data-api branch January 11, 2023 16:26

octavia-squidington-iii mentioned this pull request Jan 12, 2023

Bump Airbyte version from 0.40.27 to 0.40.28 #21359

Merged

jbfbell pushed a commit that referenced this pull request Jan 13, 2023

Source Google Analytics Data API: slicer updated, unit tests added (#…

0084339

…21169) Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Source Google Analytics Data API: slicer updated, unit tests added #21169

Source Google Analytics Data API: slicer updated, unit tests added #21169

grubberr commented Jan 9, 2023 •

edited

Loading

grubberr commented Jan 9, 2023 •

edited by github-actions bot

Loading

grubberr commented Jan 9, 2023 •

edited by github-actions bot

Loading

grubberr commented Jan 10, 2023

grubberr commented Jan 10, 2023 •

edited by github-actions bot

Loading

grubberr commented Jan 10, 2023 •

edited by github-actions bot

Loading

grubberr commented Jan 10, 2023 •

edited by github-actions bot

Loading

grubberr commented Jan 10, 2023 •

edited by github-actions bot

Loading

grubberr commented Jan 10, 2023 •

edited by github-actions bot

Loading

grubberr commented Jan 10, 2023 •

edited by github-actions bot

Loading

grubberr commented Jan 11, 2023 •

edited by github-actions bot

Loading

grubberr commented Jan 11, 2023

grubberr commented Jan 11, 2023 •

edited by github-actions bot

Loading

grubberr commented Jan 11, 2023 •

edited by github-actions bot

Loading

grubberr commented Jan 11, 2023 •

edited by github-actions bot

Loading

grubberr commented Jan 11, 2023 •

edited by github-actions bot

Loading

grubberr commented Jan 11, 2023 •

edited by github-actions bot

Loading

Source Google Analytics Data API: slicer updated, unit tests added #21169

Source Google Analytics Data API: slicer updated, unit tests added #21169

Conversation

grubberr commented Jan 9, 2023 • edited Loading

What

Pre-merge Checklist

Community member or Airbyter

Airbyter

grubberr commented Jan 9, 2023 • edited by github-actions bot Loading

Build Passed

grubberr commented Jan 9, 2023 • edited by github-actions bot Loading

Build Failed

grubberr commented Jan 10, 2023

grubberr commented Jan 10, 2023 • edited by github-actions bot Loading

Build Failed

grubberr commented Jan 10, 2023 • edited by github-actions bot Loading

Build Failed

grubberr commented Jan 10, 2023 • edited by github-actions bot Loading

Build Failed

grubberr commented Jan 10, 2023 • edited by github-actions bot Loading

Build Failed

grubberr commented Jan 10, 2023 • edited by github-actions bot Loading

Build Failed

grubberr commented Jan 10, 2023 • edited by github-actions bot Loading

Build Passed

grubberr commented Jan 11, 2023 • edited by github-actions bot Loading

Build Failed

grubberr commented Jan 11, 2023

grubberr commented Jan 11, 2023 • edited by github-actions bot Loading

Build Failed

grubberr commented Jan 11, 2023 • edited by github-actions bot Loading

Build Passed

grubberr commented Jan 11, 2023 • edited by github-actions bot Loading

grubberr commented Jan 11, 2023 • edited by github-actions bot Loading

grubberr commented Jan 11, 2023 • edited by github-actions bot Loading

grubberr commented Jan 9, 2023 •

edited

Loading

grubberr commented Jan 9, 2023 •

edited by github-actions bot

Loading

grubberr commented Jan 9, 2023 •

edited by github-actions bot

Loading

grubberr commented Jan 10, 2023 •

edited by github-actions bot

Loading

grubberr commented Jan 10, 2023 •

edited by github-actions bot

Loading

grubberr commented Jan 10, 2023 •

edited by github-actions bot

Loading

grubberr commented Jan 10, 2023 •

edited by github-actions bot

Loading

grubberr commented Jan 10, 2023 •

edited by github-actions bot

Loading

grubberr commented Jan 10, 2023 •

edited by github-actions bot

Loading

grubberr commented Jan 11, 2023 •

edited by github-actions bot

Loading

grubberr commented Jan 11, 2023 •

edited by github-actions bot

Loading

grubberr commented Jan 11, 2023 •

edited by github-actions bot

Loading

grubberr commented Jan 11, 2023 •

edited by github-actions bot

Loading

grubberr commented Jan 11, 2023 •

edited by github-actions bot

Loading

grubberr commented Jan 11, 2023 •

edited by github-actions bot

Loading