🪟 🐛 Hide no credits banner for no billing accounts #21218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josephkmh
approved these changes
Jan 11, 2023
There was a problem hiding this comment.
I'm not sure I follow why a workspace could have remainingCredits <= 0 and simultaneously CreditStatus.POSITIVE? Are these special accounts where we are allowing negative credit balance but continuing syncs?
Approving because the change looks fine, I'm just missing some context.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Hide the "We stopped all your syncs because you ran out of credits" for accounts that actually are still working (no billing accounts). They will still have creditStatus on "positive" even when ran out. There's not real way we know those accounts before they ran out of credit, so we keep showing the "Low credit warning" still, but at least hide the banner that tells we stopped their syncs (which would not happen).