Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🪟 🐛 Fix broken switch UI state - when checked state provided as a "value" #21219

Merged
merged 2 commits into from
Jan 11, 2023

Conversation

dizel852
Copy link
Contributor

What

Fixed broken <Switch /> UI state

How

Handle the checked state if it was provided as a value

CPT2301102049-572x571

@octavia-squidington-iv octavia-squidington-iv added the area/frontend Related to the Airbyte webapp label Jan 10, 2023
@dizel852 dizel852 added team/frontend type/bug Something isn't working labels Jan 10, 2023
@dizel852 dizel852 requested a review from edmundito January 10, 2023 18:58
Co-authored-by: Krishna (kc) Glick <krishna@airbyte.io>
@dizel852 dizel852 self-assigned this Jan 10, 2023
Copy link
Contributor

@matter-q matter-q left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lmossman lmossman merged commit f3a70be into master Jan 11, 2023
@lmossman lmossman deleted the vlad/fix-broken-switch branch January 11, 2023 20:55
jbfbell pushed a commit that referenced this pull request Jan 13, 2023
…lue" (#21219)

* fix broken switch state - when checked state provided as a "value"

* Update airbyte-webapp/src/components/ui/Switch/Switch.tsx

Co-authored-by: Krishna (kc) Glick <krishna@airbyte.io>

Co-authored-by: Krishna (kc) Glick <krishna@airbyte.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/frontend Related to the Airbyte webapp type/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants