🪟 🔧 Use experiment for new streams table design #21230
Merged
+76
−97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update formConfig validationSchema to use a hook to get the feature flags directly * Add useNewTableDesignExperiment helper hook * Rename isNewStreamsTableEnabled -> isNewTableDesignEnabld * Cleanup tidyFormValues to take the existing schema in
krishnaglick
approved these changes
Jan 10, 2023
| @@ -59,7 +54,7 @@ export const ConnectionReplicationTab: React.FC = () => { | |||
| const { connection, schemaRefreshing, schemaHasBeenRefreshed, updateConnection, discardRefreshedSchema } = | |||
| useConnectionEditService(); | |||
| const { initialValues, mode, schemaError, getErrorMessage, setSubmitError } = useConnectionFormService(); | |||
| const allowSubOneHourCronExpressions = useFeature(FeatureItem.AllowSyncSubOneHourCronExpressions); | |||
| const validationSchema = useConnectionValidationSchema({ mode }); | |||
There was a problem hiding this comment.
Since this is done both here and in the create form I think this should be moved to the Connection Form Service.
jbfbell
pushed a commit
that referenced
this pull request
Jan 13, 2023
* Use experiment for new streams table design * Update formConfig validationSchema to use a hook to get the feature flags directly * Add useNewTableDesignExperiment helper hook * Rename isNewStreamsTableEnabled -> isNewTableDesignEnabld * Cleanup tidyFormValues to take the existing schema in * Fix var name in CatalogTreeTableHeader
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Resolves #20196
Updates flagging for new table design to use LaunchDarkly experiment.
How
Creates a helper hook that checks for the experiment or the current env variable. While there is work to make this easier, I decided to use this custom solution to enable this in cloud sooner.
Some changes were made to how the
validationSchemawas created to use the hook. Creating the schema validation is also a hook so that the flags and experiments don't need to be passed directly.tidyConnectionFormValuesalso now takes the generated validation schema instead of re-generating it.Recommended reading order
Top top bottom