Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🪟 🔧 Switch CI to use npm ci #21259

Merged
merged 1 commit into from
Jan 11, 2023
Merged

🪟 🔧 Switch CI to use npm ci #21259

merged 1 commit into from
Jan 11, 2023

Conversation

timroes
Copy link
Collaborator

@timroes timroes commented Jan 11, 2023

What

This enables our CI (i.e. when running npm via Gradle) to use npm ci instead of npm install for installing dependencies. This command will install dependencies, but make sure to clean the node_modules beforehand. Also (the main reason to switch) it will fail if it would need to change the package-lock.json file. This prevents us from running into situations where we commited a not up to date package-lock.json file.

@timroes timroes requested a review from a team as a code owner January 11, 2023 16:42
@octavia-squidington-iv octavia-squidington-iv added the area/frontend Related to the Airbyte webapp label Jan 11, 2023
josephkmh
josephkmh approved these changes Jan 11, 2023
View reviewed changes
Copy link
Contributor

@josephkmh josephkmh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is definitely the right way to do it 😄

@timroes timroes merged commit bf8428e into master Jan 11, 2023
@timroes timroes deleted the tim/npm-ci branch January 11, 2023 17:12
@octavia-squidington-iii octavia-squidington-iii mentioned this pull request Jan 12, 2023
Merged
jbfbell pushed a commit that referenced this pull request Jan 13, 2023
@timroes @jbfbell
Switch CI to use npm ci (#21259)
77b08a4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josephkmh josephkmh josephkmh approved these changes

@ambirdsall ambirdsall Awaiting requested review from ambirdsall

Assignees
No one assigned
Labels
area/frontend Related to the Airbyte webapp
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@timroes @josephkmh @octavia-squidington-iv