Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run Airbyte CI on pull_request #21266

Merged
merged 3 commits into from
Jan 12, 2023
Merged

Run Airbyte CI on pull_request #21266

merged 3 commits into from
Jan 12, 2023

Conversation

c-p-b
Copy link
Contributor

@c-p-b c-p-b commented Jan 11, 2023 •
edited
Loading

What

Currently this only runs on push. This causes external contributor pull requests to never trigger even though they are required.

How

Update the ci yaml to also trigger on pull request. Also make Airbyte CI only run on pushes to master instead of any branch to reduce amount of extraneous ci

@c-p-b c-p-b temporarily deployed to more-secrets January 11, 2023 18:31 — with GitHub Actions Inactive
@c-p-b c-p-b temporarily deployed to more-secrets January 11, 2023 18:31 — with GitHub Actions Inactive
@c-p-b c-p-b temporarily deployed to more-secrets January 11, 2023 18:31 — with GitHub Actions Inactive
@c-p-b c-p-b temporarily deployed to more-secrets January 11, 2023 18:32 — with GitHub Actions Inactive
@c-p-b c-p-b requested a review from perangel January 11, 2023 18:34
@c-p-b c-p-b temporarily deployed to more-secrets January 11, 2023 18:35 — with GitHub Actions Inactive
@c-p-b c-p-b temporarily deployed to more-secrets January 11, 2023 18:35 — with GitHub Actions Inactive
@c-p-b c-p-b enabled auto-merge (squash) January 11, 2023 18:52
@c-p-b c-p-b temporarily deployed to more-secrets January 11, 2023 19:16 — with GitHub Actions Inactive
@c-p-b c-p-b temporarily deployed to more-secrets January 11, 2023 19:16 — with GitHub Actions Inactive
@c-p-b c-p-b temporarily deployed to more-secrets January 11, 2023 19:58 — with GitHub Actions Inactive
@c-p-b c-p-b temporarily deployed to more-secrets January 11, 2023 19:59 — with GitHub Actions Inactive
@c-p-b c-p-b temporarily deployed to more-secrets January 12, 2023 15:13 — with GitHub Actions Inactive
@c-p-b c-p-b temporarily deployed to more-secrets January 12, 2023 15:13 — with GitHub Actions Inactive
@c-p-b c-p-b disabled auto-merge January 12, 2023 16:14
@c-p-b c-p-b merged commit 31a1333 into master Jan 12, 2023
@c-p-b c-p-b deleted the cpdeethree-patch-2 branch January 12, 2023 16:14
@octavia-squidington-iii octavia-squidington-iii mentioned this pull request Jan 12, 2023
Merged
jbfbell pushed a commit that referenced this pull request Jan 13, 2023
@jbfbell
Run Airbyte CI on pull_request (#21266)
6eaec8b 
* Run Airbyte CI on pull_request as well

* also only run on pushes to master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@perangel perangel perangel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@c-p-b @perangel