Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Low Code CDK] Add type annotations and cleanup usage of visited set #21268

Merged
merged 3 commits into from
Jan 12, 2023

Conversation

clnoll
Copy link
Contributor

@clnoll clnoll commented Jan 11, 2023

What

Adds type annotations and cleans up usage of visited set per unaddressed comments in #20893.

@clnoll clnoll requested a review from brianjlai January 11, 2023 18:57
@clnoll clnoll requested a review from a team as a code owner January 11, 2023 18:57
@octavia-squidington-iv octavia-squidington-iv added the CDK Connector Development Kit label Jan 11, 2023
Copy link
Contributor

@brianjlai brianjlai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@clnoll clnoll merged commit f675c6f into master Jan 12, 2023
@clnoll clnoll deleted the cdk-fwd-refs-update branch January 12, 2023 10:20
jbfbell pushed a commit that referenced this pull request Jan 13, 2023
#21268)

* [Low Code CDK] Add type annotations and cleanup usage of `visited` set

* 🤖 Bump minor version of Airbyte CDK
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CDK Connector Development Kit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants