Source Gnews: reorganize inline schema in gnews.yaml #21322

clnoll · 2023-01-12T15:14:25Z

What

Improve readability of the gnews manifest.

How

Now that we're supporting forward references, we can move the schemas key in to the bottom of the manifest, when using inline schemas.

Pre-merge Checklist

Changelog updated
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

clnoll · 2023-01-12T15:15:56Z

/test connector=connectors/source-gnews

🕑 connectors/source-gnews https://github.com/airbytehq/airbyte/actions/runs/3903559551
✅ connectors/source-gnews https://github.com/airbytehq/airbyte/actions/runs/3903559551
Python tests coverage:

Name                                                   Stmts   Miss  Cover
--------------------------------------------------------------------------
source_gnews/wait_until_midnight_backoff_strategy.py      16      0   100%
source_gnews/__init__.py                                   3      0   100%
source_gnews/source.py                                     4      1    75%
--------------------------------------------------------------------------
TOTAL                                                     23      1    96%
	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          12      4    67%   16-19
	 source_acceptance_test/config.py                       141      5    96%   87, 93, 239, 243-244
	 source_acceptance_test/conftest.py                     211     95    55%   36, 42-44, 49, 54, 77, 83, 89-91, 110, 115-117, 123-125, 131-132, 137-138, 143, 149, 158-167, 173-178, 193, 217, 248, 254, 262-267, 275-285, 293-306, 311-317, 324-335, 342-358
	 source_acceptance_test/plugin.py                        69     25    64%   22-23, 31, 36, 120-140, 144-148
	 source_acceptance_test/tests/test_core.py              402    115    71%   53, 58, 93-104, 109-116, 120-121, 125-126, 308, 346-363, 376-387, 391-396, 402, 435-440, 478-485, 528-530, 533, 598-606, 618-621, 626, 682-683, 689, 692, 728-738, 751-776
	 source_acceptance_test/tests/test_incremental.py       160     14    91%   56-63, 68-81, 244
	 source_acceptance_test/utils/asserts.py                 39      2    95%   62-63
	 source_acceptance_test/utils/common.py                  94     10    89%   16-17, 32-38, 72, 75
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/connector_runner.py       133     33    75%   24-27, 46-47, 50-54, 57-58, 73-75, 78-80, 83-85, 88-90, 93-95, 124-125, 159-161, 208
	 source_acceptance_test/utils/json_schema_helper.py     107     13    88%   30-31, 38, 41, 65-68, 96, 120, 192-194
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1609    339    79%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:94: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:377: The previous and actual discovered catalogs are identical.
============ 29 passed, 2 skipped, 31 warnings in 66.74s (0:01:06) =============

girarda

much better :)

clnoll · 2023-01-12T16:19:14Z

/publish connector=connectors/source-gnews

🕑 Publishing the following connectors:
connectors/source-gnews
https://github.com/airbytehq/airbyte/actions/runs/3904060548

Connector	Did it publish?	Were definitions generated?
connectors/source-gnews	❌	❌

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

clnoll · 2023-01-12T16:28:18Z

/publish connector=connectors/source-gnews

🕑 Publishing the following connectors:
connectors/source-gnews
https://github.com/airbytehq/airbyte/actions/runs/3904124804

Connector	Did it publish?	Were definitions generated?
connectors/source-gnews	❌	❌

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

clnoll · 2023-01-12T17:03:04Z

/publish connector=connectors/source-gnews

🕑 Publishing the following connectors:
connectors/source-gnews
https://github.com/airbytehq/airbyte/actions/runs/3904379818

Connector	Did it publish?	Were definitions generated?
connectors/source-gnews	❌	❌

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

github-actions · 2023-01-17T11:20:07Z

Airbyte Code Coverage

There is no coverage information present for the Files changed

Total Project Coverage	26.59%	🍏

clnoll · 2023-01-17T12:46:07Z

/test connector=connectors/source-gnews

🕑 connectors/source-gnews https://github.com/airbytehq/airbyte/actions/runs/3939364807
✅ connectors/source-gnews https://github.com/airbytehq/airbyte/actions/runs/3939364807
Python tests coverage:

Name                                                   Stmts   Miss  Cover
--------------------------------------------------------------------------
source_gnews/wait_until_midnight_backoff_strategy.py      16      0   100%
source_gnews/__init__.py                                   3      0   100%
source_gnews/source.py                                     4      1    75%
--------------------------------------------------------------------------
TOTAL                                                     23      1    96%
	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          12      4    67%   16-19
	 source_acceptance_test/config.py                       141      5    96%   87, 93, 239, 243-244
	 source_acceptance_test/conftest.py                     211     95    55%   36, 42-44, 49, 54, 77, 83, 89-91, 110, 115-117, 123-125, 131-132, 137-138, 143, 149, 158-167, 173-178, 193, 217, 248, 254, 262-267, 275-285, 293-306, 311-317, 324-335, 342-358
	 source_acceptance_test/plugin.py                        69     25    64%   22-23, 31, 36, 120-140, 144-148
	 source_acceptance_test/tests/test_core.py              402    115    71%   53, 58, 93-104, 109-116, 120-121, 125-126, 308, 346-363, 376-387, 391-396, 402, 435-440, 478-485, 528-530, 533, 598-606, 618-621, 626, 682-683, 689, 692, 728-738, 751-776
	 source_acceptance_test/tests/test_incremental.py       160     14    91%   58-65, 70-83, 246
	 source_acceptance_test/utils/asserts.py                 39      2    95%   62-63
	 source_acceptance_test/utils/common.py                  94     10    89%   16-17, 32-38, 72, 75
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/connector_runner.py       133     33    75%   24-27, 46-47, 50-54, 57-58, 73-75, 78-80, 83-85, 88-90, 93-95, 124-125, 159-161, 208
	 source_acceptance_test/utils/json_schema_helper.py     107     13    88%   30-31, 38, 41, 65-68, 96, 120, 192-194
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1609    339    79%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:94: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:377: The previous and actual discovered catalogs are identical.
============ 29 passed, 2 skipped, 31 warnings in 66.01s (0:01:06) =============

clnoll · 2023-01-17T13:53:14Z

/publish connector=connectors/source-gnews

🕑 Publishing the following connectors:
connectors/source-gnews
https://github.com/airbytehq/airbyte/actions/runs/3939918678

Connector	Did it publish?	Were definitions generated?
connectors/source-gnews	✅	❌

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

octavia-squidington-iv added area/connectors Connector related issues connectors/source/gnews labels Jan 12, 2023

clnoll force-pushed the source-gnews-use-schema-forward-reference branch from c0c8aec to 4bd392c Compare January 12, 2023 15:15

octavia-squidington-iv added the area/documentation Improvements or additions to documentation label Jan 12, 2023

clnoll requested review from brianjlai and girarda January 12, 2023 15:57

girarda approved these changes Jan 12, 2023

View reviewed changes

clnoll force-pushed the source-gnews-use-schema-forward-reference branch from ddd9127 to fc9fd60 Compare January 12, 2023 18:08

clnoll temporarily deployed to more-secrets January 12, 2023 18:10 — with GitHub Actions Inactive

clnoll force-pushed the source-gnews-use-schema-forward-reference branch 2 times, most recently from a3f9846 to f0cb5d7 Compare January 12, 2023 18:58

clnoll temporarily deployed to more-secrets January 12, 2023 19:01 — with GitHub Actions Inactive

clnoll and others added 2 commits January 12, 2023 19:17

[source-gnews] Reorganize gnews.yaml inline schemas

b19938e

Bump gnews.md version

f093d95

clnoll force-pushed the source-gnews-use-schema-forward-reference branch from 6a1780c to 3daafec Compare January 12, 2023 19:19

clnoll temporarily deployed to more-secrets January 12, 2023 19:21 — with GitHub Actions Inactive

clnoll temporarily deployed to more-secrets January 12, 2023 19:22 — with GitHub Actions Inactive

clnoll force-pushed the source-gnews-use-schema-forward-reference branch from 3daafec to f093d95 Compare January 12, 2023 20:37

clnoll temporarily deployed to more-secrets January 12, 2023 20:39 — with GitHub Actions Inactive

Merge branch 'master' into source-gnews-use-schema-forward-reference

2fc5cef

clnoll temporarily deployed to more-secrets January 13, 2023 10:37 — with GitHub Actions Inactive

Merge branch 'master' into source-gnews-use-schema-forward-reference

7aacebe

clnoll temporarily deployed to more-secrets January 17, 2023 11:08 — with GitHub Actions Inactive

Merge branch 'master' into source-gnews-use-schema-forward-reference

85edfb2

clnoll temporarily deployed to more-secrets January 17, 2023 11:46 — with GitHub Actions Inactive

clnoll temporarily deployed to more-secrets January 17, 2023 11:47 — with GitHub Actions Inactive

clnoll merged commit 9b7535e into master Jan 17, 2023

clnoll deleted the source-gnews-use-schema-forward-reference branch January 17, 2023 14:27

octavia-squidington-iii mentioned this pull request Jan 24, 2023

Bump Airbyte version from 0.40.28 to 0.40.29 #21767

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Source Gnews: reorganize inline schema in gnews.yaml #21322

Source Gnews: reorganize inline schema in gnews.yaml #21322

clnoll commented Jan 12, 2023 •

edited

Loading

clnoll commented Jan 12, 2023 •

edited by github-actions bot

Loading

girarda left a comment

clnoll commented Jan 12, 2023 •

edited by github-actions bot

Loading

clnoll commented Jan 12, 2023 •

edited by github-actions bot

Loading

clnoll commented Jan 12, 2023 •

edited by github-actions bot

Loading

github-actions bot commented Jan 17, 2023

clnoll commented Jan 17, 2023 •

edited by github-actions bot

Loading

clnoll commented Jan 17, 2023 •

edited by github-actions bot

Loading

Source Gnews: reorganize inline schema in gnews.yaml #21322

Source Gnews: reorganize inline schema in gnews.yaml #21322

Conversation

clnoll commented Jan 12, 2023 • edited Loading

What

How

Pre-merge Checklist

clnoll commented Jan 12, 2023 • edited by github-actions bot Loading

Build Passed

girarda left a comment

Choose a reason for hiding this comment

clnoll commented Jan 12, 2023 • edited by github-actions bot Loading

clnoll commented Jan 12, 2023 • edited by github-actions bot Loading

clnoll commented Jan 12, 2023 • edited by github-actions bot Loading

github-actions bot commented Jan 17, 2023

Airbyte Code Coverage

clnoll commented Jan 17, 2023 • edited by github-actions bot Loading

Build Passed

clnoll commented Jan 17, 2023 • edited by github-actions bot Loading

clnoll commented Jan 12, 2023 •

edited

Loading

clnoll commented Jan 12, 2023 •

edited by github-actions bot

Loading

clnoll commented Jan 12, 2023 •

edited by github-actions bot

Loading

clnoll commented Jan 12, 2023 •

edited by github-actions bot

Loading

clnoll commented Jan 12, 2023 •

edited by github-actions bot

Loading

clnoll commented Jan 17, 2023 •

edited by github-actions bot

Loading

clnoll commented Jan 17, 2023 •

edited by github-actions bot

Loading