Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

store env-var response #21327

Merged
merged 8 commits into from
Jan 12, 2023
Merged

store env-var response #21327

merged 8 commits into from
Jan 12, 2023

Conversation

colesnodgrass
Copy link
Member

@colesnodgrass colesnodgrass commented Jan 12, 2023 •
edited
Loading

What

  • address excess logging messages

How

  • store results of the feature-flag, instead of checking them constantly

Note

This is the quick fix, I'll create a long-term fix later today that will cache the env-var results within the EnvVariableFeatureFlags class itself. That way the real env-var is only checked once and the log message would only be generated once.

@colesnodgrass colesnodgrass temporarily deployed to more-secrets January 12, 2023 16:40 — with GitHub Actions Inactive
@colesnodgrass colesnodgrass temporarily deployed to more-secrets January 12, 2023 16:40 — with GitHub Actions Inactive
benmoriceau
benmoriceau approved these changes Jan 12, 2023
View reviewed changes
Copy link
Contributor

@benmoriceau benmoriceau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we set the logs to debug instead?

@colesnodgrass colesnodgrass temporarily deployed to more-secrets January 12, 2023 17:03 — with GitHub Actions Inactive
@colesnodgrass colesnodgrass temporarily deployed to more-secrets January 12, 2023 17:03 — with GitHub Actions Inactive
@colesnodgrass colesnodgrass temporarily deployed to more-secrets January 12, 2023 17:19 — with GitHub Actions Inactive
@colesnodgrass colesnodgrass temporarily deployed to more-secrets January 12, 2023 17:19 — with GitHub Actions Inactive
@colesnodgrass
Copy link
Member Author

colesnodgrass commented Jan 12, 2023 •
edited
Loading

Should we set the logs to debug instead?

@benmoriceau I think we should. I'm planning on cleaning this quick-fix up in a separate pr (if I can ever get these checks to pass on this pr 😞)

I changed it to debug in this PR, as the checks are still having issues passing.

@colesnodgrass colesnodgrass requested a review from a team as a code owner January 12, 2023 17:26
@colesnodgrass colesnodgrass temporarily deployed to more-secrets January 12, 2023 17:28 — with GitHub Actions Inactive
@colesnodgrass colesnodgrass temporarily deployed to more-secrets January 12, 2023 17:28 — with GitHub Actions Inactive
@colesnodgrass colesnodgrass temporarily deployed to more-secrets January 12, 2023 17:37 — with GitHub Actions Inactive
@colesnodgrass colesnodgrass temporarily deployed to more-secrets January 12, 2023 17:37 — with GitHub Actions Inactive
@colesnodgrass colesnodgrass temporarily deployed to more-secrets January 12, 2023 18:22 — with GitHub Actions Inactive
@colesnodgrass colesnodgrass temporarily deployed to more-secrets January 12, 2023 18:22 — with GitHub Actions Inactive
@colesnodgrass colesnodgrass merged commit 440a5e4 into master Jan 12, 2023
@colesnodgrass colesnodgrass deleted the cole/address-excess-ff-logging branch January 12, 2023 19:16
@octavia-squidington-iii octavia-squidington-iii mentioned this pull request Jan 12, 2023
Merged
jbfbell pushed a commit that referenced this pull request Jan 13, 2023
@colesnodgrass @jbfbell
store env-var response (#21327)
f715310 
* store env-var response

* fix formatting

* fix pmd issue

* change log message to debug

* fix file change error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benmoriceau benmoriceau benmoriceau approved these changes

@gosusnp gosusnp gosusnp approved these changes

@jdpgrailsdev jdpgrailsdev Awaiting requested review from jdpgrailsdev

@alovew alovew Awaiting requested review from alovew

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@colesnodgrass @gosusnp @benmoriceau