Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ISSUE #19981] use github user with access to push on master #21345

Merged
merged 4 commits into from
Jan 14, 2023
Merged

[ISSUE #19981] use github user with access to push on master #21345

merged 4 commits into from
Jan 14, 2023

Conversation

maxi297
Copy link
Contributor

@maxi297 maxi297 commented Jan 12, 2023

What

Currently, the publish pipeline can't be executed in master because it uses the default GITHUB_TOKEN (the robot users that triggers workflows) which does not have access to push on master. Based on Peter Hu's comment:

  • airbyteio is admin for the airbytehq/airbyte repository
  • admins have access to push on protected branches

@maxi297 maxi297 temporarily deployed to more-secrets January 12, 2023 19:01 — with GitHub Actions Inactive
@maxi297 maxi297 temporarily deployed to more-secrets January 12, 2023 19:01 — with GitHub Actions Inactive
@maxi297 maxi297 requested a review from clnoll January 12, 2023 19:18
@brianjlai
Copy link
Contributor

just noting some failing CI checks but at least the connectors base stuff seems unrelated to your change

@erohmensing erohmensing temporarily deployed to more-secrets January 13, 2023 21:37 — with GitHub Actions Inactive
@erohmensing erohmensing temporarily deployed to more-secrets January 13, 2023 21:38 — with GitHub Actions Inactive
@erohmensing erohmensing temporarily deployed to more-secrets January 13, 2023 22:16 — with GitHub Actions Inactive
@erohmensing erohmensing temporarily deployed to more-secrets January 13, 2023 22:16 — with GitHub Actions Inactive
@erohmensing erohmensing enabled auto-merge (squash) January 14, 2023 00:40
@erohmensing erohmensing temporarily deployed to more-secrets January 14, 2023 00:43 — with GitHub Actions Inactive
@erohmensing erohmensing temporarily deployed to more-secrets January 14, 2023 00:43 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

There is no coverage information present for the Files changed

Total Project Coverage 26.58% 🍏

@erohmensing erohmensing merged commit d16e329 into master Jan 14, 2023
@erohmensing erohmensing deleted the issue-19981_set-user-with-access-to-push-on-master branch January 14, 2023 01:19
@octavia-squidington-iii octavia-squidington-iii mentioned this pull request Jan 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianjlai brianjlai brianjlai approved these changes

@clnoll clnoll Awaiting requested review from clnoll

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maxi297 @brianjlai @erohmensing