Source Klaviyo: enable SAT high strictness #21374

arsenlosenko · 2023-01-13T08:51:39Z

What

Resolving:
#19052

How

Enable SAT high strictness level accordingly to instructions set in the issue linked above.

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub by running the /publish command described here
After the connector is published, connector added to connector index as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

Connector Generator

Issue acceptance criteria met
PR name follows PR naming conventions
If adding a new generator, add it to the list of scaffold modules being tested
The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
Documentation which references the generator is updated as needed

Tests

Unit

Put your unit tests output here.

Integration

Put your integration tests output here.

Acceptance

Put your acceptance tests output here.

…r high strictness

arsenlosenko · 2023-01-13T12:15:39Z

/test connector=connectors/source-klaviyo

🕑 connectors/source-klaviyo https://github.com/airbytehq/airbyte/actions/runs/3911197403
❌ connectors/source-klaviyo https://github.com/airbytehq/airbyte/actions/runs/3911197403
🐛 https://gradle.com/s/gq54degzqqxr2

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestBasicRead::test_read[inputs0] - Failed: Stream flows...
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:377: The previous and actual discovered catalogs are identical.
============== 1 failed, 30 passed, 1 skipped in 63.97s (0:01:03) ==============

arsenlosenko · 2023-01-13T14:42:04Z

/test connector=connectors/source-klaviyo

lazebnyi · 2023-01-13T18:28:51Z

/test connector=connectors/source-klaviyo

🕑 connectors/source-klaviyo https://github.com/airbytehq/airbyte/actions/runs/3913934548
✅ connectors/source-klaviyo https://github.com/airbytehq/airbyte/actions/runs/3913934548
Python tests coverage:

Name                         Stmts   Miss  Cover
------------------------------------------------
source_klaviyo/__init__.py       2      0   100%
source_klaviyo/streams.py      136     10    93%
source_klaviyo/source.py        16      3    81%
------------------------------------------------
TOTAL                          154     13    92%
	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          12      4    67%   16-19
	 source_acceptance_test/config.py                       141      5    96%   87, 93, 239, 243-244
	 source_acceptance_test/conftest.py                     211     95    55%   36, 42-44, 49, 54, 77, 83, 89-91, 110, 115-117, 123-125, 131-132, 137-138, 143, 149, 158-167, 173-178, 193, 217, 248, 254, 262-267, 275-285, 293-306, 311-317, 324-335, 342-358
	 source_acceptance_test/plugin.py                        69     25    64%   22-23, 31, 36, 120-140, 144-148
	 source_acceptance_test/tests/test_core.py              402    115    71%   53, 58, 93-104, 109-116, 120-121, 125-126, 308, 346-363, 376-387, 391-396, 402, 435-440, 478-485, 528-530, 533, 598-606, 618-621, 626, 682-683, 689, 692, 728-738, 751-776
	 source_acceptance_test/tests/test_incremental.py       160     14    91%   56-63, 68-81, 244
	 source_acceptance_test/utils/asserts.py                 39      2    95%   62-63
	 source_acceptance_test/utils/common.py                  94     10    89%   16-17, 32-38, 72, 75
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/connector_runner.py       133     33    75%   24-27, 46-47, 50-54, 57-58, 73-75, 78-80, 83-85, 88-90, 93-95, 124-125, 159-161, 208
	 source_acceptance_test/utils/json_schema_helper.py     107     13    88%   30-31, 38, 41, 65-68, 96, 120, 192-194
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1609    339    79%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:377: The previous and actual discovered catalogs are identical.
=================== 31 passed, 1 skipped in 66.00s (0:01:05) ===================

evantahler

🥳

Confirmed that Klaviyo account only has test/mock data
confirmed that expected_records only has test/mock data (some.email.that.dont.exist.9@airbyte.io)
Confirmed that only one stream is bypassed and there's a good reason

* Source Klaviyo: change configuration of acceptance-test-config.yml for high strictness * Add metrics stream to configured_catalog, add metrics expected records * Update future state * Remove expected records for flows stream

Source Klaviyo: change configuration of acceptance-test-config.yml fo…

0dabae3

…r high strictness

arsenlosenko self-assigned this Jan 13, 2023

octavia-squidington-iv added the area/connectors Connector related issues label Jan 13, 2023

arsenlosenko linked an issue Jan 13, 2023 that may be closed by this pull request

Source Klaviyo: enable high test strictness level in SAT #19052

Closed

octavia-squidington-iv added the connectors/source/klaviyo label Jan 13, 2023

arsenlosenko added 2 commits January 13, 2023 13:54

Add metrics stream to configured_catalog, add metrics expected records

16b2d95

Update future state

5943ffa

arsenlosenko requested review from bazarnov and lazebnyi January 13, 2023 12:18

lazebnyi requested a review from evantahler January 13, 2023 12:26

lazebnyi approved these changes Jan 13, 2023

View reviewed changes

Remove expected records for flows stream

f9eb9d0

evantahler approved these changes Jan 13, 2023

View reviewed changes

lazebnyi removed the request for review from bazarnov January 13, 2023 18:47

lazebnyi merged commit 617c8d8 into master Jan 13, 2023

lazebnyi deleted the arsenlosenko/source-klaviyo-high-strictness branch January 13, 2023 18:47

octavia-squidington-iii mentioned this pull request Jan 24, 2023

Bump Airbyte version from 0.40.28 to 0.40.29 #21767

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Source Klaviyo: enable SAT high strictness #21374

Source Klaviyo: enable SAT high strictness #21374

arsenlosenko commented Jan 13, 2023

arsenlosenko commented Jan 13, 2023 •

edited by github-actions bot

Loading

arsenlosenko commented Jan 13, 2023

lazebnyi commented Jan 13, 2023 •

edited by github-actions bot

Loading

evantahler left a comment

Source Klaviyo: enable SAT high strictness #21374

Source Klaviyo: enable SAT high strictness #21374

Conversation

arsenlosenko commented Jan 13, 2023

What

How

Recommended reading order

🚨 User Impact 🚨

Pre-merge Checklist

Community member or Airbyter

Airbyter

Community member or Airbyter

Airbyter

Tests

arsenlosenko commented Jan 13, 2023 • edited by github-actions bot Loading

Build Failed

arsenlosenko commented Jan 13, 2023

lazebnyi commented Jan 13, 2023 • edited by github-actions bot Loading

Build Passed

evantahler left a comment

Choose a reason for hiding this comment

arsenlosenko commented Jan 13, 2023 •

edited by github-actions bot

Loading

lazebnyi commented Jan 13, 2023 •

edited by github-actions bot

Loading