Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introduce code coverage report step #21376

Merged
merged 4 commits into from
Jan 13, 2023
Merged

introduce code coverage report step #21376

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b9896d8
introduce code coverage report step
mfsiega-airbyte Jan 13, 2023
b2d5417
remove airbyte-queue jacoco report since it isn't being generated by …
mfsiega-airbyte Jan 13, 2023
e200637
Merge branch 'master' into msiega/introduce-coverage-report4
mfsiega-airbyte Jan 13, 2023
0924536
leave pointer to wildcard support and tweak coverage threshold
mfsiega-airbyte Jan 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 37 additions & 0 deletions .github/workflows/gradle.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -643,6 +643,43 @@ jobs:
attempt_limit: 3
attempt_delay: 5000 # in ms

- name: Add coverage to PR
if: github.event_name == 'pull_request'
id: jacoco
uses: madrapps/jacoco-report@v1.3
with:
# todo(mfsiega-airbyte): when v1.4 is released, use wildcards per https://github.com/Madrapps/jacoco-report/issues/20.
paths: |
${{ github.workspace }}/airbyte-analytics/build/reports/jacoco/test/jacocoTestReport.xml,
Copy link
Contributor

@c-p-b c-p-b Jan 13, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we do a glob and make this a little less wordy? e.g. ${{ github.workspace }}/**/build/reports/jacoco/**

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sadly not: https://github.com/airbytehq/airbyte/actions/runs/3914203500/jobs/6691026776

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RIP in peace :(

Madrapps/jacoco-report#20

${{ github.workspace }}/airbyte-api/build/reports/jacoco/test/jacocoTestReport.xml,
${{ github.workspace }}/airbyte-bootloader/build/reports/jacoco/test/jacocoTestReport.xml,
${{ github.workspace }}/airbyte-commons/build/reports/jacoco/test/jacocoTestReport.xml,
${{ github.workspace }}/airbyte-commons-cli/build/reports/jacoco/test/jacocoTestReport.xml,
${{ github.workspace }}/airbyte-commons-docker/build/reports/jacoco/test/jacocoTestReport.xml,
${{ github.workspace }}/airbyte-commons-protocol/build/reports/jacoco/test/jacocoTestReport.xml,
${{ github.workspace }}/airbyte-commons-temporal/build/reports/jacoco/test/jacocoTestReport.xml,
${{ github.workspace }}/airbyte-commons-worker/build/reports/jacoco/test/jacocoTestReport.xml,
${{ github.workspace }}/airbyte-config/init/build/reports/jacoco/test/jacocoTestReport.xml,
${{ github.workspace }}/airbyte-config/specs/build/reports/jacoco/test/jacocoTestReport.xml,
${{ github.workspace }}/airbyte-config/config-persistence/build/reports/jacoco/test/jacocoTestReport.xml,
${{ github.workspace }}/airbyte-config/config-models/build/reports/jacoco/test/jacocoTestReport.xml,
${{ github.workspace }}/airbyte-container-orchestrator/build/reports/jacoco/test/jacocoTestReport.xml,
${{ github.workspace }}/airbyte-db/db-lib/build/reports/jacoco/test/jacocoTestReport.xml,
${{ github.workspace }}/airbyte-json-validation/build/reports/jacoco/test/jacocoTestReport.xml,
${{ github.workspace }}/airbyte-metrics/reporter/build/reports/jacoco/test/jacocoTestReport.xml,
${{ github.workspace }}/airbyte-metrics/metrics-lib/build/reports/jacoco/test/jacocoTestReport.xml,
${{ github.workspace }}/airbyte-notification/build/reports/jacoco/test/jacocoTestReport.xml,
${{ github.workspace }}/airbyte-oauth/build/reports/jacoco/test/jacocoTestReport.xml,
${{ github.workspace }}/airbyte-persistence/job-persistence/build/reports/jacoco/test/jacocoTestReport.xml,
${{ github.workspace }}/airbyte-protocol/protocol-models/build/reports/jacoco/test/jacocoTestReport.xml,
${{ github.workspace }}/airbyte-server/build/reports/jacoco/test/jacocoTestReport.xml,
${{ github.workspace }}/airbyte-test-utils/build/reports/jacoco/test/jacocoTestReport.xml,
${{ github.workspace }}/airbyte-workers/build/reports/jacoco/test/jacocoTestReport.xml
token: ${{ secrets.GITHUB_TOKEN }}
min-coverage-overall: 25
min-coverage-changed-files: 60
debug-mode: false

- name: Integration test
uses: Wandalen/wretry.action@master
with:
Expand Down