🎉 Source GoogleSheets - migrated SAT to strictness level #21399

midavadim · 2023-01-13T15:59:14Z

What

Describe what the change is solving
It helps to add screenshots if it affects the frontend.

How

Describe the solution

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub by running the /publish command described here
After the connector is published, connector added to connector index as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

Connector Generator

Issue acceptance criteria met
PR name follows PR naming conventions
If adding a new generator, add it to the list of scaffold modules being tested
The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
Documentation which references the generator is updated as needed

Tests

Unit

Put your unit tests output here.

Integration

Put your integration tests output here.

Acceptance

Put your acceptance tests output here.

CLAassistant · 2023-01-13T15:59:20Z

All committers have signed the CLA.

midavadim · 2023-01-13T16:30:46Z

/test connector=connectors/source-google-sheets

🕑 connectors/source-google-sheets https://github.com/airbytehq/airbyte/actions/runs/3913113601
❌ connectors/source-google-sheets https://github.com/airbytehq/airbyte/actions/runs/3913113601
🐛 https://gradle.com/s/whi4xpey4euto

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestBasicRead::test_read[inputs0] - Failed: Stream Sheet...
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:63: Skipping TestIncremental.test_two_sequential_reads: Incremental sync are not supported on this connector
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:94: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:377: The previous and actual discovered catalogs are identical.
============= 1 failed, 27 passed, 3 skipped in 185.89s (0:03:05) ==============

midavadim · 2023-01-13T20:23:37Z

/test connector=connectors/source-google-sheets

🕑 connectors/source-google-sheets https://github.com/airbytehq/airbyte/actions/runs/3914665368
❌ connectors/source-google-sheets https://github.com/airbytehq/airbyte/actions/runs/3914665368
🐛 https://gradle.com/s/qbu2bwxnyfd7g

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestBasicRead::test_read[inputs0] - Failed: Stream Sheet...
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:63: Skipping TestIncremental.test_two_sequential_reads: Incremental sync are not supported on this connector
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:94: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:377: The previous and actual discovered catalogs are identical.
============= 1 failed, 27 passed, 3 skipped in 164.59s (0:02:44) ==============

midavadim · 2023-01-17T21:13:42Z

/test connector=connectors/source-google-sheets

midavadim · 2023-01-17T21:30:56Z

/test connector=connectors/source-google-sheets

🕑 connectors/source-google-sheets https://github.com/airbytehq/airbyte/actions/runs/3943460701
✅ connectors/source-google-sheets https://github.com/airbytehq/airbyte/actions/runs/3943460701
Python tests coverage:

Name                                                Stmts   Miss  Cover
-----------------------------------------------------------------------
google_sheets_source/models/spreadsheet_values.py      12      0   100%
google_sheets_source/models/spreadsheet.py             34      0   100%
google_sheets_source/models/__init__.py                 2      0   100%
google_sheets_source/__init__.py                        2      0   100%
google_sheets_source/helpers.py                       139     26    81%
google_sheets_source/client.py                         23      6    74%
google_sheets_source/google_sheets_source.py          107     85    21%
-----------------------------------------------------------------------
TOTAL                                                 319    117    63%
	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          12      4    67%   16-19
	 source_acceptance_test/config.py                       141      5    96%   87, 93, 239, 243-244
	 source_acceptance_test/conftest.py                     211     95    55%   36, 42-44, 49, 54, 77, 83, 89-91, 110, 115-117, 123-125, 131-132, 137-138, 143, 149, 158-167, 173-178, 193, 217, 248, 254, 262-267, 275-285, 293-306, 311-317, 324-335, 342-358
	 source_acceptance_test/plugin.py                        69     25    64%   22-23, 31, 36, 120-140, 144-148
	 source_acceptance_test/tests/test_core.py              402    115    71%   53, 58, 93-104, 109-116, 120-121, 125-126, 308, 346-363, 376-387, 391-396, 402, 435-440, 478-485, 528-530, 533, 598-606, 618-621, 626, 682-683, 689, 692, 728-738, 751-776
	 source_acceptance_test/tests/test_incremental.py       160     14    91%   56-63, 68-81, 244
	 source_acceptance_test/utils/asserts.py                 39      2    95%   62-63
	 source_acceptance_test/utils/common.py                  94     10    89%   16-17, 32-38, 72, 75
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/connector_runner.py       133     33    75%   24-27, 46-47, 50-54, 57-58, 73-75, 78-80, 83-85, 88-90, 93-95, 124-125, 159-161, 208
	 source_acceptance_test/utils/json_schema_helper.py     107     13    88%   30-31, 38, 41, 65-68, 96, 120, 192-194
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1609    339    79%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:63: Skipping TestIncremental.test_two_sequential_reads: Incremental sync are not supported on this connector
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:94: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:377: The previous and actual discovered catalogs are identical.
================== 28 passed, 3 skipped in 188.46s (0:03:08) ===================

bazarnov

I guess we can improve some aspects here. First, is the number of records we expect, we don't need so much data of the same structure, let's keep 1-5 records of the same structure, WDYT?

airbyte-integrations/connectors/source-iterable/acceptance-test-config.yml

bazarnov · 2023-01-17T22:49:18Z

airbyte-integrations/connectors/source-google-sheets/integration_tests/expected_records.jsonl

+{"stream":"Sheet6-4000-rows","data":{"ID":"2657","Name":"WsDCfjVjR"},"emitted_at":1673989572000}
+{"stream":"Sheet6-4000-rows","data":{"ID":"2658","Name":"IRqDptXBg"},"emitted_at":1673989572000}
+{"stream":"Sheet6-4000-rows","data":{"ID":"2659","Name":"QmmhfvOaQ"},"emitted_at":1673989572000}
+{"stream"


Do we really need the 4033 same-structure records? Can we leave 1? Could we also use *.txt instead of *.jsonl?

evantahler

👍 no bypass reasons, and all expected_records are gibberish!

* migrated SAT to strictness level * fixed expected records * revert file from another source * changed extension to txt * changed extension to txt

* api changes for writing discover catalog * api changes * format * worker change 1 * change return type of the API to return catalogId * worker to call api * typo * 🎉 Source GoogleSheets - migrated SAT to strictness level (#21399) * migrated SAT to strictness level * fixed expected records * revert file from another source * changed extension to txt * changed extension to txt * 🐛Destination-Bigquery: Added an explicit error message if sync fails due to a config issue (#21144) * [19998] Destination-Bigquery: Added an explicit error message in sync fails due to a config issue * ci-connector-ops: split workflows(#21474) * CI: nightly build alpha sources and destinations (#21562) * Revert "Change main class in strict-encrypt destination and bump versions on both destinations to keep them in sync (#21509)" (#21567) This reverts commit 1d202d1. * Fixes webhook updating logic (#21519) * ci_credentials: disable tooling test run by tox (#21580) * disable tox * rename steps * revert changes on experimental workflow * do not install tox * Revert "CI: nightly build alpha sources and destinations (#21562)" (#21589) This reverts commit 61f88f3. * Security update of default docker images (#21407) Because there is a lot of CVEs in those releases. Co-authored-by: Topher Lubaway <asimplechris@gmail.com> * 📝 add docs for how to add normalization (#21563) * add docs * add schema link * update based on feedback * 🪟 🚦 E2E tests: clean up matchers (#20887) * improve serviceTypeDropdownOption selector * add test ids to PathPopout component(s) * add unique id's to table dropdowns * extend submitButtonClick to support optional click options * update dropdown(pathPopout) matchers * add test-id to Overlay component * remove redundant function brackets * revert changes onSubmit button click * fix dropDown overlay issue * move all duplicated intercepters to beforeEach * add test id's to Connections, Sources and Destinations tables * add table helper functions * update source page actions * intercepter fixes * update createTestConnection function with optional replication settings * remove extra Connection name check * replace "cypress-postgres" with "pg-promise" npm package * update cypress config * Revert "update createTestConnection function with optional replication settings" This reverts commit 8e47c78. * Revert "remove extra Connection name check" This reverts commit dfb19c7. * replace openSourceDestinationFromGrid with specific selector * replace openSourceDestinationFromGrid with specific selector * turn on test * add test-id's * fix selectors * update test * update test snapshots * fix lost data-testid after resolve merge conflicts * remove extra check * move clickOnCellInTable helper to common.ts file * remove empty line and comments * fix dropdownType * replace partial string check with exact * extract interceptors and waiters to separate file * fix selector for predefined PK * fix selector * add comment regarding dropdown * 🪟 🎨 [Free connectors] Update modal copy (#21600) * move start/end time options out of optional block (#21541) * lingering fix * reflecting api changes * test fix * worker to call api to do discover work * recovered deleted html * self review * more converters refactor * fix connector test * fix test * fix * fix integration test * add unit test for converter * static fix * api client needs to have a timeout in case request does not get responded --------- Co-authored-by: midavadim <midavadim@yahoo.com> Co-authored-by: Eugene <etsybaev@gmail.com> Co-authored-by: Augustin <augustin@airbyte.io> Co-authored-by: Greg Solovyev <grishick@users.noreply.github.com> Co-authored-by: Yatsuk Bogdan <yatsukbogdan@gmail.com> Co-authored-by: Hervé Commowick <github@herve.commowick.fr> Co-authored-by: Topher Lubaway <asimplechris@gmail.com> Co-authored-by: Pedro S. Lopez <pedroslopez@me.com> Co-authored-by: Vladimir <volodymyr.s.petrov@globallogic.com> Co-authored-by: Joey Marshment-Howell <josephkmh@users.noreply.github.com> Co-authored-by: Lake Mossman <lake@airbyte.io>

* api changes for writing discover catalog * api changes * format * worker change 1 * change return type of the API to return catalogId * worker to call api * typo * 🎉 Source GoogleSheets - migrated SAT to strictness level (#21399) * migrated SAT to strictness level * fixed expected records * revert file from another source * changed extension to txt * changed extension to txt * 🐛Destination-Bigquery: Added an explicit error message if sync fails due to a config issue (#21144) * [19998] Destination-Bigquery: Added an explicit error message in sync fails due to a config issue * ci-connector-ops: split workflows(#21474) * CI: nightly build alpha sources and destinations (#21562) * Revert "Change main class in strict-encrypt destination and bump versions on both destinations to keep them in sync (#21509)" (#21567) This reverts commit 1d202d1. * Fixes webhook updating logic (#21519) * ci_credentials: disable tooling test run by tox (#21580) * disable tox * rename steps * revert changes on experimental workflow * do not install tox * Revert "CI: nightly build alpha sources and destinations (#21562)" (#21589) This reverts commit 61f88f3. * Security update of default docker images (#21407) Because there is a lot of CVEs in those releases. Co-authored-by: Topher Lubaway <asimplechris@gmail.com> * 📝 add docs for how to add normalization (#21563) * add docs * add schema link * update based on feedback * 🪟 🚦 E2E tests: clean up matchers (#20887) * improve serviceTypeDropdownOption selector * add test ids to PathPopout component(s) * add unique id's to table dropdowns * extend submitButtonClick to support optional click options * update dropdown(pathPopout) matchers * add test-id to Overlay component * remove redundant function brackets * revert changes onSubmit button click * fix dropDown overlay issue * move all duplicated intercepters to beforeEach * add test id's to Connections, Sources and Destinations tables * add table helper functions * update source page actions * intercepter fixes * update createTestConnection function with optional replication settings * remove extra Connection name check * replace "cypress-postgres" with "pg-promise" npm package * update cypress config * Revert "update createTestConnection function with optional replication settings" This reverts commit 8e47c78. * Revert "remove extra Connection name check" This reverts commit dfb19c7. * replace openSourceDestinationFromGrid with specific selector * replace openSourceDestinationFromGrid with specific selector * turn on test * add test-id's * fix selectors * update test * update test snapshots * fix lost data-testid after resolve merge conflicts * remove extra check * move clickOnCellInTable helper to common.ts file * remove empty line and comments * fix dropdownType * replace partial string check with exact * extract interceptors and waiters to separate file * fix selector for predefined PK * fix selector * add comment regarding dropdown * 🪟 🎨 [Free connectors] Update modal copy (#21600) * move start/end time options out of optional block (#21541) * lingering fix * reflecting api changes * test fix * reset to master * routing changes * remove unexpected merge * resolve dependency micronaut * resolve dependency * format * fix test * rename and refactor location of test files * test * redo the routing service * add test to config repository * query workspace not connection for discover/check * remove unused bean --------- Co-authored-by: midavadim <midavadim@yahoo.com> Co-authored-by: Eugene <etsybaev@gmail.com> Co-authored-by: Augustin <augustin@airbyte.io> Co-authored-by: Greg Solovyev <grishick@users.noreply.github.com> Co-authored-by: Yatsuk Bogdan <yatsukbogdan@gmail.com> Co-authored-by: Hervé Commowick <github@herve.commowick.fr> Co-authored-by: Topher Lubaway <asimplechris@gmail.com> Co-authored-by: Pedro S. Lopez <pedroslopez@me.com> Co-authored-by: Vladimir <volodymyr.s.petrov@globallogic.com> Co-authored-by: Joey Marshment-Howell <josephkmh@users.noreply.github.com> Co-authored-by: Lake Mossman <lake@airbyte.io>

migrated SAT to strictness level

679a046

octavia-squidington-iv added area/connectors Connector related issues connectors/source/google-sheets labels Jan 13, 2023

midavadim linked an issue Jan 13, 2023 that may be closed by this pull request

Source Google Sheets: enable high test strictness level in SAT #19045

Closed

fixed expected records

1578295

octavia-squidington-iv added the connectors/source/iterable label Jan 17, 2023

bazarnov reviewed Jan 17, 2023

View reviewed changes

revert file from another source

410d239

midavadim requested a review from bazarnov January 18, 2023 14:55

bazarnov requested review from a team January 18, 2023 14:59

bazarnov approved these changes Jan 18, 2023

View reviewed changes

midavadim added 2 commits January 18, 2023 17:19

changed extension to txt

45b3d59

changed extension to txt

7ab513c

evantahler approved these changes Jan 18, 2023

View reviewed changes

sherifnada removed the request for review from a team January 18, 2023 22:05

midavadim merged commit f49266f into master Jan 18, 2023

midavadim deleted the midavadim/19045_google_sheets_strict_sat branch January 18, 2023 22:45

octavia-squidington-iii mentioned this pull request Jan 24, 2023

Bump Airbyte version from 0.40.28 to 0.40.29 #21767

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🎉 Source GoogleSheets - migrated SAT to strictness level #21399

🎉 Source GoogleSheets - migrated SAT to strictness level #21399

midavadim commented Jan 13, 2023

CLAassistant commented Jan 13, 2023 •

edited

Loading

midavadim commented Jan 13, 2023 •

edited by github-actions bot

Loading

midavadim commented Jan 13, 2023 •

edited by github-actions bot

Loading

midavadim commented Jan 17, 2023

midavadim commented Jan 17, 2023 •

edited by github-actions bot

Loading

bazarnov left a comment

bazarnov Jan 17, 2023 •

edited

Loading

evantahler left a comment

🎉 Source GoogleSheets - migrated SAT to strictness level #21399

🎉 Source GoogleSheets - migrated SAT to strictness level #21399

Conversation

midavadim commented Jan 13, 2023

What

How

Recommended reading order

🚨 User Impact 🚨

Pre-merge Checklist

Community member or Airbyter

Airbyter

Community member or Airbyter

Airbyter

Tests

CLAassistant commented Jan 13, 2023 • edited Loading

midavadim commented Jan 13, 2023 • edited by github-actions bot Loading

Build Failed

midavadim commented Jan 13, 2023 • edited by github-actions bot Loading

Build Failed

midavadim commented Jan 17, 2023

midavadim commented Jan 17, 2023 • edited by github-actions bot Loading

Build Passed

bazarnov left a comment

Choose a reason for hiding this comment

bazarnov Jan 17, 2023 • edited Loading

Choose a reason for hiding this comment

evantahler left a comment

Choose a reason for hiding this comment

CLAassistant commented Jan 13, 2023 •

edited

Loading

midavadim commented Jan 13, 2023 •

edited by github-actions bot

Loading

midavadim commented Jan 13, 2023 •

edited by github-actions bot

Loading

midavadim commented Jan 17, 2023 •

edited by github-actions bot

Loading

bazarnov Jan 17, 2023 •

edited

Loading