🪟 🐛 Fix jest tests to fail build correctly #21408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krishnaglick
approved these changes
Jan 13, 2023
jbfbell
pushed a commit
that referenced
this pull request
Jan 13, 2023
* Fix jest tests to fail build correctly * Add failing test for demo * Update StatusCell.test.tsx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Jests tests currently don't fail the
:airbyte-webapp:testtask correctly, since specifying--watchand--watchAll=falseto jest will cause it to always return 0 exit codes, despite the--watchbeing overwritten otherwise in behavior by--watchAll=false.How
This creates a new
test:cinpm task that will be called from gradle, to make sure we're not specifying both arguments.To test you can make sure that
SUB_BUILD=PLATFORM ./gradlew :airbyte-webapp:testwill now correctly fail if there's a jest test failure.