🪟 🔧 remove cyclic dependencies with cloud routes #21424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teallarson
changed the title
teallarson
changed the title
teallarson
commented
Jan 13, 2023
Comment on lines
+1
to
+19
| export enum CloudRoutes { | ||
| Root = "/", | ||
| AuthFlow = "/auth_flow", | ||
|
|
||
| Metrics = "metrics", | ||
| SelectWorkspace = "workspaces", | ||
| Credits = "credits", | ||
|
|
||
| // Auth routes | ||
| Signup = "/signup", | ||
| Login = "/login", | ||
| ResetPassword = "/reset-password", | ||
|
|
||
| // Firebase action routes | ||
| // These URLs come from Firebase emails, and all have the same | ||
| // action URL ("/verify-email") with different "mode" parameter | ||
| // TODO: use a better action URL in Firebase email template | ||
| FirebaseAction = "/verify-email", | ||
| } |
There was a problem hiding this comment.
I can't think of a reason this needs to be an object as const as opposed to an enum (and the OSS routePaths is an enum so it seems right?)
timroes
approved these changes
Jan 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Removes cyclic dependency in our cloud routes to unblock part of #21421
How
Updates our cloud routes to use
cloudRoutePathsin the same manner that OSS usesroutePathsRecommended reading order
cloudRoutePaths.tsx